Commit graph

775 commits

Author SHA1 Message Date
Ole Laursen 0aa8f8a7cc Don't automatically open a new review request if there's already
another open request in the team
 - Legacy-Id: 12086
2016-10-05 13:34:15 +00:00
Ole Laursen a177dc616b Fix a couple of bugs, add test for reviewer overview page
- Legacy-Id: 12081
2016-10-04 20:22:11 +00:00
Ole Laursen 4c7b2847ba Add a utility function for extracting information about review
requests for a given set of teams/reviewers (making it trivial to
compute statistics), revamp the related doc event code to support this
by referencing the review request directly, add a reviewer overview
page with recent performance for each reviewer as well as
settings/unavailable periods. Fix some bugs and shuffle some of the
review code a bit around.

Finish the importer from the previous Perl-based review tool,
importing log entries, figuring out whether a given review is
early/telechat/last call and fixing corner cases.
 - Legacy-Id: 12080
2016-10-03 15:52:32 +00:00
Ole Laursen c586feb579 Fix an old bug in draft resurrection, it was using the long gone
doc.idinternal in an explanation
 - Legacy-Id: 12027
2016-09-23 15:29:27 +00:00
Ole Laursen 99beb58291 Implement a round-robin rotation scheme for reviewers instead of
relying on when they last reviewed. In-order assignments automatically
move the rotation forwards while out-of-order assignments increment
the skip next of the assigned reviewer. Include rotation in open
review assignments email. Fix a couple of issues in the importer.
 - Legacy-Id: 12015
2016-09-21 16:52:50 +00:00
Ole Laursen 6da25e6bd9 Add personal review overview page for reviewers, add page for editing
reviewer availability settings, emailing the reviewer/secretary as
necessary, add tests for these pages. Fix a bunch of bugs.
 - Legacy-Id: 11998
2016-09-19 16:05:32 +00:00
Ole Laursen 74a02be9bf Create new branch from trunk@r11921, and merge review-tracker-r11360 into it
- Legacy-Id: 11923
2016-09-06 10:17:12 +00:00
Henrik Levkowetz 14607c977d Fixed a blowup which could happen if an rfc doesn't have its standard level set.
- Legacy-Id: 11916
2016-09-01 08:57:49 +00:00
Henrik Levkowetz a939936a10 Fixed document methods .get_file_path() and .href() for historic meeting documents, to make urls like /doc/minutes-96-detnet/1/ work.
- Legacy-Id: 11912
2016-08-31 16:19:05 +00:00
Henrik Levkowetz fae136cfc3 Made migration doc:0013 more robust.
- Legacy-Id: 11903
2016-08-31 13:48:00 +00:00
Henrik Levkowetz f97204ceee Fixed a number of places where events were given the document time, but the document had not been given a new time yet, after the eventsave refactoring code changes of [11841]. Fixes issue #2004.
- Legacy-Id: 11901
Note: SVN reference [11841] has been migrated to Git commit d868371aff
2016-08-31 10:54:27 +00:00
Henrik Levkowetz 9fb2ec22c6 Added handling for an exception which could occur for charter documents which does not have a matching chartered group.
- Legacy-Id: 11886
2016-08-26 14:07:50 +00:00
Henrik Levkowetz 7d0fd4cb29 Merged in [11859] from rjsparks@nostrum.com:
Put WG summary information on the rechartering page. Fixes #2000.
 - Legacy-Id: 11881
Note: SVN reference [11859] has been migrated to Git commit b6978debb6
2016-08-26 10:31:03 +00:00
Henrik Levkowetz c8917f51aa Changed the migration progress indication to a tqdm progress bar.
- Legacy-Id: 11862
2016-08-25 05:48:04 +00:00
Henrik Levkowetz a90af1e9e3 Added a migration to capture an additional DocEvent type string.
- Legacy-Id: 11861
2016-08-25 05:22:59 +00:00
Robert Sparks b6978debb6 Put WG summary information on the rechartering page. Fixes #2000. Commit ready for merge.
- Legacy-Id: 11859
2016-08-24 18:43:15 +00:00
Henrik Levkowetz cf5ac68b09 Renumbered and updated the migrations merged in from the eventsaving work. Made the dochistory-adding migration idempotent, and added progress indication as this migration may take as much as an hour to run.
- Legacy-Id: 11854
2016-08-24 15:37:25 +00:00
Ole Laursen 24dd268a81 Show on document page if teams are not going to review that version
- Legacy-Id: 11851
2016-08-24 09:08:37 +00:00
Ole Laursen dd190b87fe Follow replacements when displaying reviews for a draft on the
document page, too. Add a test to check that recursive replacements
are handled correctly. Polish the display a bit.
 - Legacy-Id: 11847
2016-08-23 14:55:42 +00:00
Ole Laursen 0958bcba4a Fill in the list_email attribute on the test review team
- Legacy-Id: 11845
2016-08-23 14:05:45 +00:00
Henrik Levkowetz 4b0a9360f0 Merged in ^/branch/iola/event-saving-refactor-r10291, which refactors document saving to always use doc.save_with_history(events), and requires accompanying events. This branch also provides refactoring of recurring regexes in url patterns into a dictionary. As part of the merge, also refactored new code which didn't use the save_with_history() method.
- Legacy-Id: 11840
2016-08-23 10:52:08 +00:00
Ole Laursen 8b65c3ad65 Support adding CC's to the complete review email
- Legacy-Id: 11826
2016-08-19 16:37:46 +00:00
Henrik Levkowetz 6f05b23837 Merged in [11778] from rjsparks@nostrum.com:
Enabled and refined document_main view for bluesheets.
Improved migration for 95 and 96 bluesheets, adding DocAlias and DocEvent creation.
Added bluesheet upload to the session details view.
Moved a function out of secr/proceedings/views into its own util.py file to allow reusing it in other modules without introducing circular imports.
 - Legacy-Id: 11811
Note: SVN reference [11778] has been migrated to Git commit 0611444b36bc071e8db068a093cc1ad93bb69659
2016-08-17 18:28:02 +00:00
Ole Laursen 426542771a Turn ReviewRequest.deadline into a date field with no time
- Legacy-Id: 11801
2016-08-17 15:10:39 +00:00
Ole Laursen 3ecaf54d51 Pre-fill the review type when requesting a review
- Legacy-Id: 11798
2016-08-17 14:42:57 +00:00
Ole Laursen 0e808518bc Make it possible to request review for more than one team at the time,
auto-select the team for team secretaries/delegates
 - Legacy-Id: 11786
2016-08-15 16:05:56 +00:00
Ole Laursen 8a5d9d7a72 Make it more obvious that a review is not completed yet, include
ongoing reviews in the list on the review document page
 - Legacy-Id: 11785
2016-08-15 15:46:11 +00:00
Ole Laursen 9454c8bb9c Show other reviews of document on the review document page
- Legacy-Id: 11784
2016-08-15 14:41:12 +00:00
Ole Laursen 1ae302ca07 Add info about last call/scheduled telechat to the request review page, fix a bug
- Legacy-Id: 11782
2016-08-15 10:31:50 +00:00
Robert Sparks 44cd9e0920 Moved the materials start, cutoff, and revision dates into the Meeting object
- Legacy-Id: 11760
2016-08-05 20:44:05 +00:00
Ole Laursen 78062adc2f Use request.build_absolute_uri instead of grabbing the domain from the
current Site in the review code
 - Legacy-Id: 11753
2016-08-03 15:13:55 +00:00
Henrik Levkowetz b420ef220c Merged in [11721] from bartosz.balazinski@interdigital.com:
Annotated the document state selection list with indications of
whether the state is an IETF or IRTF state. Fixes #1968.
 - Legacy-Id: 11722
Note: SVN reference [11721] has been migrated to Git commit 0925e8e242
2016-07-20 09:14:27 +00:00
Bartosz Balazinski 0925e8e242 Annotated the document state selection list with indications of
whether the state is an IETF or IRTF state. Fixes #1968. 
Commit ready to merge.
 - Legacy-Id: 11721
2016-07-20 00:02:45 +00:00
Henrik Levkowetz f2150df76a Merged in [11687], [11710] from presnick@qti.qualcomm.com:
Generate a message to Secretary and IESG when AD changes a draft state
to 'Approved'.  Fixes issue #796.
 - Legacy-Id: 11714
Note: SVN reference [11687] has been migrated to Git commit ae87e84610

Note: SVN reference [11710] has been migrated to Git commit 65bb1f2738
2016-07-19 10:48:13 +00:00
Pete Resnick 65bb1f2738 Added a test for the document approved by AD action. Related to issue
#796.  Commit ready for merge
 - Legacy-Id: 11710
2016-07-18 20:12:12 +00:00
Pete Resnick ae87e84610 Generate message to Secretary and IESG when AD changes a draft state to "Approved".
Fixes issue #796. Commit ready for merge.
 - Legacy-Id: 11687
2016-07-16 17:09:21 +00:00
Henrik Levkowetz d5d9d10017 Merged in [11663] from housley@vigilsec.com:
Clarify that the consensus field is talking about whether the doument will include the consensus boilerplate when it is published as an RFC. Fixes #1955.
 - Legacy-Id: 11684
Note: SVN reference [11663] has been migrated to Git commit 9d5a94713e
2016-07-16 14:52:57 +00:00
Russ Housley 9d5a94713e Clarify that the consensus field is talking about whether the doument will include the consensus boilerplate when it is published as an RFC. Fixes #1955.
- Legacy-Id: 11663
2016-07-16 09:53:54 +00:00
Robert Sparks 030ea1c939 Enhanced factories to simplify test writing. Commit ready for merge.
- Legacy-Id: 11656
2016-07-15 12:30:08 +00:00
Robert Sparks 992aba1aec Call out downreferences in autogenerated last call text. Fixes #1982. Commit ready for merge.
- Legacy-Id: 11654
2016-07-14 18:09:22 +00:00
Ole Laursen 308b854d66 Change the naming algorithm for review documents a bit
- Legacy-Id: 11635
2016-07-12 16:02:35 +00:00
Ole Laursen e7ee08069e Swap the sort order on the displayed revisions when completing a review
- Legacy-Id: 11632
2016-07-12 15:06:49 +00:00
Ole Laursen db4ea01e20 Take a bunch of factors into account when sorting reviewers for
assignment to a review request
 - Legacy-Id: 11626
2016-07-12 13:04:14 +00:00
Henrik Levkowetz 45b19a585b Fixed various issues with the interim approval request email text when used for non-WG groups (RGs, for instance). Added supporting template filter functions. Related to issues #1979 and #1980.
- Legacy-Id: 11581
2016-07-09 20:02:28 +00:00
Henrik Levkowetz 8b6d8c9f44 Replaced the hardcoded 'Area Director' approval role with a group-dependent list of approval roles. Fixes issue #1980.
- Legacy-Id: 11575
2016-07-09 16:59:50 +00:00
Henrik Levkowetz 1ddd6e7a09 Merged in [11530] from rjsparks@nostrum.com:
Adds a publisher to the digital preservation feed.
 - Legacy-Id: 11570
Note: SVN reference [11530] has been migrated to Git commit aafd1dc1ed
2016-07-08 13:17:02 +00:00
Henrik Levkowetz ad9d5d72f9 Fixed an error in a docstring.
- Legacy-Id: 11534
2016-07-07 12:19:59 +00:00
Henrik Levkowetz a4b5bbc5cf Removed an unnecessary pyflakes:ignore.
- Legacy-Id: 11533
2016-07-07 12:19:02 +00:00
Henrik Levkowetz 2b55d20371 Added a filter 'nbsp' to turn spaces into nonbreaking-space characters.
- Legacy-Id: 11532
2016-07-07 12:18:21 +00:00
Ole Laursen 5c8be91b08 Improve review assignment slightly by sorting reviewers by latest
review - still missing a bunch of factors, and unassignment is now
temporarily gone
 - Legacy-Id: 11531
2016-07-07 12:17:55 +00:00