Jennifer Richards
08e953995a
feat: better reject null characters in forms ( #7472 )
...
* feat: subclass ModelMultipleChoiceField to reject nuls
* refactor: Use custom ModelMultipleChoiceField
* fix: handle value=None
2024-05-28 10:34:55 -05:00
Robert Sparks
cedd58f950
feat: obviate ghostlinkd ( #7336 )
...
* wip: identify whats needed to obviate ghostlinkd
* fix: hardlink new charter files to ftp directory
* fix: hardlink new charter files to ftp directory (continued)
* chore: bring settings comment up to date
* chore: add archive and ftp dirs to setup of various environments
* fix: test charter submits write to ftp dir
* chore: remove debug
* fix: test charter approval writes to ftp dir
* fix: link review revisions into ftp dir
* fix: link to all archive and ftp on submission post
* chore: clean comments, move action to github issue
* fix: link idindex files to all archive and ftp
* chore: deflake
* chore: remove TODO comment
* fix: use settings
* chore: rename new setting
2024-04-19 16:18:52 -05:00
Paul Selkirk
b445119428
fix: Properly set AD as action holder when submitting to IESG for publication ( #6854 )
...
* fix: Properly set AD as action holder when submitting to IESG for publication (#5227 )
The clear intent of `to_iesg` is that
a) the document AD should be the group AD, if not already set, and
b) the document Action Holder should be the document AD;
but there was an order-of-operation error,
such that the Action Holder remained empty.
* refactor: Don't take values out of the parent scope, don't insert values into the parent scope
* refactor: Streamline DocEvent creation
2024-01-03 16:30:06 -06:00
Robert Sparks
ab931f0510
chore: merge main into feat/rfc
2023-10-12 15:11:02 -05:00
Paul Selkirk
72fef7bc69
fix: Don't allow ADs to set docs to -sent states ( #6445 )
2023-10-10 10:09:04 -05:00
Lars Eggert
7dbfc0208a
feat: Remove document notes from the datatracker ( #6387 )
...
* Remove doc.note
* Address comments from @rjsparks
* Consistently display doc notes
2023-10-09 12:15:18 -05:00
Robert Sparks
4946430159
chore: checkpoint: halfway through removing docalias
2023-08-15 09:11:53 -05:00
Robert Sparks
8ff14419c2
chore: continued refactoring
2023-06-16 16:59:20 -05:00
Robert Sparks
d6f58b3e67
chore: use more expressive related_name
2023-06-16 15:26:52 -05:00
Robert Sparks
769d85a6c4
chore: explore architecture change in RelatedDocument
2023-06-16 14:58:42 -05:00
Lars Eggert
f8b48f4c43
fix: use Internet-Draft more consistently across the UI ( #5104 )
...
* s/Internet Draft/Internet-Draft/i
* s/draft/Internet-Draft/i or s/draft/I-D/i
* s/ID/I-D/
* Fix tests
* a -> an
* Undo case-change to ASCII
* Address code review comments
* Add migrations
* Add merged migration
* fix: straighten out migrations
* fix: finish straightening out migrations
---------
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2023-02-11 10:09:28 -06:00
Robert Sparks
afac1f8f19
feat: enable editorial stream adoption and balloting ( #5011 )
...
* feat: enable editorial stream adoption and balloting
* fix: bring tests into line with refactor
* feat: force intended_std_level to Informational when adopting into a non-ietf stream.
* fix: improve blocking position labels and email content
* fix: simplify pointer to group on doc main page for rswg docs
* fix: recover from merge typos
* fix: correct defer and clear ballot behavior
* fix: improve publication request access logic
* fix: clean up broken editorial state
* fix: adjust test to match migrations
2023-01-31 13:50:51 -06:00
Robert Sparks
5560c28c82
fix: only show irtf stream ballot and publication buttons to the IRTF chair ( #5036 )
2023-01-25 15:10:31 -06:00
Lars Eggert
f870715a80
fix: Allow more email addresses in notification lists ( #4792 )
...
* fix: Allow more email addresses in notification lists
Fixes #4736
* Do what @rjsparks suggested
* Number migration
* Number migration
* Fix tests and apply for all doc types
2022-12-08 15:46:35 -06:00
Jennifer Richards
d55280d0b1
Merge pull request #4638 from ietf-tools/main
...
chore: merge main into feat/tzaware
2022-10-24 12:57:11 -03:00
Lars Eggert
160ca9286a
fix: Don't say that IESG processing has started ( #4609 )
...
* fix: Don't say that IESG processing has started
Fixes #4286
* Update ietf/doc/views_draft.py
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
* Update ietf/doc/views_draft.py
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-10-20 09:02:09 -05:00
Jennifer Richards
69447d0ba0
Merge branch 'feat/tzaware' into jennifer/main-for-tzaware-merge
...
# Conflicts:
# ietf/name/fixtures/names.json
# ietf/utils/management/commands/send_gdpr_consent_request.py
2022-10-18 16:57:42 -03:00
Robert Sparks
cbb8da73c8
fix: regenerate correct shepherd template. Fixes #4558 ( #4595 )
...
* fix: regenerate correct shepherd template
* chore: remove unnecessary extra whitespace
* fix: improve readability of code per review comments
2022-10-18 07:57:08 -05:00
Jennifer Richards
32054111df
fix: fix failing tests and eliminate naive datetime warnings ( #4402 )
...
* test: fix timestamp construction in several doc tests
* refactor: rename date2datetime to datetime_from_date and clarify code
* chore: helper to get tzinfo for PRODUCTION_TIMEZONE
* fix: fix timezone handling in make_last_call()
* test: fix datetime generation in doc.tests_charter
* refactor: remove PRODUCTION_TIMEZONE setting
Replaces the PRODUCTION_TIMEZONE setting with a constant,
DEADLINE_TZINFO, in ietf.utils.timezone.
* test: be more careful about timezone in tests_charter.py
* test: be more careful about timezone in doc/tests.py
* fix: fix timezone handling affecting doc.tests_draft
* fix: fix timezone handling affecting tests_irsg_ballot.py
* fix: fix timezone handling affecting tests_review.py
* fix: fix timezone handling affecting last ietf.doc tests
* fix: fix timezone handling affecting last ietf.group tests
* fix: fix timezone handling affecting ietf.iesg tests
* fix: handle timezones in get_8989_eligibility_querysets
* fix: handle timezones affecting ietfauth tests
* fix: return tz-aware datetime from utc_from_string
* fix: specify timezone for constants in ipr_rfc_number()
* fix: specify tz for ipr deadlines
* fix: handle timezones affecting liaisons tests
* fix: treat leap day in get_8989_eligibility_querysets()
Manual cherry-pick of 248d6474
* test: treat leap day properly in nomcom tests
* fix: fix timezone handling affecting nomcom tests
* test: fix timezone handling in review tests
* fix: fix timezone handling affecting secr.meetings tests
* fix: handle both pytz and zoneinfo timezones in ietf.utils.timezone
* fix: fix timezone handling affecting secr.proceedings tests
* refactor: use make_aware() helper in secr.meetings tests
* test: fix timezone handling in secr.telechat tests
* fix: fix timezone handling affecting stats tests
* fix: eliminate tz-naive helpers affecting sync email parsing
* fix: include timezone data when serializing DeletedEvent data
* fix: fix timezone handling affecting sync tests
* style: remove unused import
2022-09-01 13:07:28 -03:00
Jennifer Richards
ebebdbed3e
refactor: replace datetime.now and datetime.today with timezone.now ( #4211 )
...
* refactor: replace datetime.now with timezone.now
* refactor: migrate model fields to use timezone.now as default
* refactor: replace datetime.today with timezone.now
datetime.datetime.today() is equivalent to datetime.datetime.now(); both
return a naive datetime with the current local time.
* refactor: rephrase datetime.now(tz) as timezone.now().astimezone(tz)
This is effectively the same, but is less likely to encourage accidental
use of naive datetimes.
* refactor: revert datetime.today() change to old migrations
* refactor: change a missed datetime.now to timezone.now
* chore: renumber timezone_now migration
* chore: renumber migrations
2022-08-25 13:45:16 -03:00
Robert Sparks
0f703a695e
fix: correctly render wg shepherd writeups and test it. ( #4316 )
2022-08-11 16:21:52 -05:00
Lars Eggert
3d49384213
fix: Make the "submit to IESG" workflow less surprising to @LPardue :-) ( #4254 )
...
* fix: Make the "submit to IESG" workflow less surprising to @LPardue :-)
Fixes #4209
* Merge part of #4256
2022-07-24 11:28:27 -05:00
Lars Eggert
1ba87890ba
feat: Render the document shepherd writeup templates at two new URLs ( #4225 )
...
* feat: Render the document shepherd writeup templates at two new URL.
Those being `/doc/shepherdwriteuptemplate/group` and
`/doc/shepherdwriteuptemplate/individual`.
* Address review comments from @jennifer-richards
* Fixes
* Remove debug statement
* Make bleach sanitizer not strip the `start` attribute of `ol` tags
Also rearrange the code a bit
* Don't sanitize the `python_markdown` output, it destroys wanted formatting
* Restore bleach
* Don't bleach tag `id`s.
2022-07-22 13:43:02 -05:00
Jennifer Richards
fc9864114b
Allow pre-ADs to be assigned as responsible for document. Fixes #3229 . Commit ready for merge.
...
- Legacy-Id: 19383
2021-09-22 18:42:00 +00:00
Jennifer Richards
b08110b838
Allow external resources to be set/suggested during submission process. Fixes #3068 . Commit ready for merge.
...
- Legacy-Id: 18960
2021-04-19 20:21:19 +00:00
Jennifer Richards
e11583a87f
Allow assignment of Person as "action holder" for a Doc, plus rudimentary automation of assignment. Fixes #3146 . Commit ready for merge.
...
- Legacy-Id: 18829
2021-02-12 20:31:00 +00:00
Robert Sparks
3697180cc1
Reverted merge of timezone-aware migration efforts.
...
- Legacy-Id: 18792
2021-01-12 16:54:20 +00:00
Henrik Levkowetz
774e752a54
Snapshot of timezone-aware datatracker code. Tests pass, and the test-crawler shows only expected differences. Trunk changes merged in up to r18768.
...
- Legacy-Id: 18770
2020-12-16 23:53:37 +00:00
Robert Sparks
7e384a8aea
Send email to new mailtrigger controlled destinations when iana expert review state changes. Fixes #3121 . Commit ready for merge.
...
- Legacy-Id: 18714
2020-11-18 21:32:48 +00:00
Henrik Levkowetz
0fa1500f52
Changed the format of email addresses added to the document notifications filed when the document shepherd is set. Fixes issue #3079 .
...
- Legacy-Id: 18494
2020-09-14 13:31:39 +00:00
Henrik Levkowetz
57938b039d
Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403.
...
- Legacy-Id: 18339
2020-08-06 10:59:52 +00:00
Robert Sparks
066ee27505
preparing to merge forward
...
- Legacy-Id: 18143
2020-07-09 20:29:45 +00:00
Robert Sparks
7e57be2bd3
merged forward ^/personal/rjs/explore-extref
...
- Legacy-Id: 17840
2020-05-19 18:47:47 +00:00
Robert Sparks
7587d564d4
Added GroupExtResources to the group about page, and added the ability to edit them.
...
- Legacy-Id: 17685
2020-04-24 21:47:24 +00:00
Robert Sparks
2de9eb93b5
Added validation to the migrations. Added external resources to the draft display page. Built an editor for DocExternalResources.
...
- Legacy-Id: 17683
2020-04-24 16:14:43 +00:00
Henrik Levkowetz
726fcbf27d
Removed all __future__ imports.
...
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz
a7baacf519
Added missing .as_strings() to some gather_address_lists() calls, in order to assign strings rather than lists to Message CharField instances. Fixed a Message content_type setting.
...
- Legacy-Id: 17337
2020-02-26 16:59:18 +00:00
Henrik Levkowetz
32e9692f54
Fixed a py2/py3 issue in sync.rfceditor.post_approved_draft(), and enhanced tests to execute the failing code (with Mock functions) instead of skipping the code.
...
- Legacy-Id: 17265
2020-01-28 22:37:50 +00:00
Robert Sparks
0c0cc5dcf5
Allow document Additional URLs to become empty. Fixes #2864 . Commit ready for merge.
...
- Legacy-Id: 17227
2020-01-13 19:03:58 +00:00
Ryan Cross
9882d7fda8
Fix issue where draft resurrect feature does not move most recent draft file from the archive directory back to the current draft directory. Fixes #2646 . Commit ready for merge
...
- Legacy-Id: 17027
2019-11-16 05:15:03 +00:00
Henrik Levkowetz
1edc863969
Merged in [16763] from rjsparks@nostrum.com:
...
Allow responsible AD to be None for documents in iesg states idexists and dead. Fixes #2803 and #993 .
- Legacy-Id: 16838
Note: SVN reference [16763] has been migrated to Git commit 9f54af355d4e2b17404caa1755be74d22b5edad1
2019-10-07 19:54:56 +00:00
Robert Sparks
e45a32e49f
Add IANA expert review tracking. Commit ready for merge.
...
- Legacy-Id: 16656
2019-08-15 20:36:07 +00:00
Henrik Levkowetz
a5e31c3f40
Py2/3 compatibility: Added __future__ import.
...
- Legacy-Id: 16452
2019-07-15 15:52:18 +00:00
Henrik Levkowetz
ff6997df2b
Fixed a case of indeterminate ordering.
...
- Legacy-Id: 16343
2019-06-30 20:58:26 +00:00
Henrik Levkowetz
3ec7e864be
Converted leading tabs to spaces in ietf/**/*.py
...
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz
d7f5c84182
Initial 2to3 patch with added copyright statement updates.
...
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz
56543d565c
Changed sending of PubReq messages to explicitly use on-behalf-of, without Reply-To. Reply-To is picked up as requestor by RT. Fixes issue #2691 anew.
...
- Legacy-Id: 16034
2019-03-14 21:31:40 +00:00
Henrik Levkowetz
682ddee8e4
Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
...
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Henrik Levkowetz
435a0da12d
Added on_behalf_of() calls for from addresses needing it throughout the code.
...
- Legacy-Id: 15992
2019-03-04 20:14:19 +00:00
Henrik Levkowetz
b57ad67041
Updated code and templates to use the new docman and groupman group features.
...
- Legacy-Id: 15922
2019-01-30 15:59:00 +00:00