Commit graph

47 commits

Author SHA1 Message Date
Jennifer Richards 07e26dd52e
refactor: Replace deprecated force_text with force_str 2023-05-09 15:21:50 -03:00
Robert Sparks 6ed4ea0f93
feat: point to Zulip chat rather than jabber. (#4218)
* feat: point to Zulip chat rather than jabber.

* fix: Address review comments from Jennifer and Nick
2022-07-15 13:48:54 -05:00
Jennifer Richards 53dde975ec
fix: validate group type/acronym properly in admin. Fixes #4028. (#4070)
* fix: validate group type/acronym properly in admin

* chore: remove unused import
2022-06-13 11:14:26 -05:00
Jennifer Richards 1054f90873 Snapshot of dev work to add session purpose annotation
- Legacy-Id: 19415
2021-10-12 17:08:58 +00:00
Robert Sparks c01fea3920 Show groupman_authroles in the GroupFeatures admin list. Commit ready for merge.
- Legacy-Id: 19254
2021-07-21 20:10:30 +00:00
Jennifer Richards 2a2e5f0c24 Clean up handling of non-WG groups on the group edit page; restrict parent/child group relationships by type. Fixes #3253. Commit ready for merge.
- Legacy-Id: 19075
2021-06-04 17:31:53 +00:00
Robert Sparks 404d115934 Merged in [18936] from rjsparks@nostrum.com:
Retain strict acronym validation, specifically disallowing hyphens, for new groups of types that create documents, while allowing existing groups and new non-document-creating groups to validate when they contain hyphens. Fixes #3236. Commit
 - Legacy-Id: 18945
Note: SVN reference [18936] has been migrated to Git commit 04f5b4ae4dcbbf8a39281f0b79b1a6271439fd1a
2021-04-12 17:08:58 +00:00
Henrik Levkowetz 57938b039d Converted many cases of plain-text 403 messages to use a properly styled page instead, with a login link when appropriate. Also changed some API endpoint 400 responses to a more correct 403.
- Legacy-Id: 18339
2020-08-06 10:59:52 +00:00
Henrik Levkowetz 068493d8bd Merged in [18205] from rjsparks@nostrum.com:
Add rudimentary validation to the admin group form acronym field. Partially addresses #3026.
 - Legacy-Id: 18215
Note: SVN reference [18205] has been migrated to Git commit 82928b8033
2020-07-21 20:06:56 +00:00
Robert Sparks 82928b8033 Add rudimentary validation to the admin group form acronym field. Partially addresses #3026. Commit ready for merge.
- Legacy-Id: 18205
2020-07-20 20:00:05 +00:00
Robert Sparks bf53bf1057 Merged forward. Added some missing parts to the XMPPURLValidator.
- Legacy-Id: 18050
2020-06-24 19:01:45 +00:00
Robert Sparks c69556efe1 Improve admin form validation for used_roles. Commit ready for merge.
- Legacy-Id: 17992
2020-06-15 19:14:42 +00:00
Robert Sparks 02e1226a03 Added appropriate Admin classes
- Legacy-Id: 17870
2020-05-21 20:48:03 +00:00
Henrik Levkowetz 726fcbf27d Removed all __future__ imports.
- Legacy-Id: 17391
2020-03-05 23:53:42 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz 240d5bc64d Replaced force_unicode() with force_text()
- Legacy-Id: 16313
2019-06-27 18:08:56 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 720943af72 Removed the has_dependencies GroupFeature, and used has_documents instead in the one place it was used.
- Legacy-Id: 15934
2019-02-07 15:56:48 +00:00
Henrik Levkowetz 0885422534 Added new docman and groupman GroupFeature fields.
- Legacy-Id: 15920
2019-01-30 15:55:23 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Henrik Levkowetz 2daef52bea This commit replaces the code defined group features with features held
in a database table:

- Added a GroupFeatures model to the group models, and removed the old 
  features.py
- Added a agenda type for future use in showing different group types on
  different agendas.
- Renamed the group feature has_materials to has_nonsession_materials.
- Added API resources and admin support for the new tables.
- Added a Directorate (with reviews) group type as complement to
  Directorate, to distinguish between directorates with and without reviews.
- Adjusted tests as needed.
- Updated the fixtures, and fixed the generate_fixtures script to include
  the new AgendaTypeName objects.

There still exists about 70 instances of code comparing the group type
with a list of types; most of these should probably be replaced with new
features, instead, to make it possible to add new group types through the
database table, rather than having to edit the code.  That was the purpose
of this refactoring from the start, but the presence of this large number
of comparisons of group type against lists of types defeats the goal until
we add appropriate features and replace the group type list comparisons.
 - Legacy-Id: 15316
2018-07-12 10:51:48 +00:00
Henrik Levkowetz 4dad8cdf9a Added a test to check for missing admin models, and added the admin models that were currently missing.
- Legacy-Id: 14021
2017-08-01 14:00:29 +00:00
Henrik Levkowetz aa5e61d958 Updated all urlpatterns to use ietf.utils.urls.url() instead of django's,
in order to autogenerate dotted path url pattern names.  Updated a number
of url reverses to use dotted path, and removed explicit url pattern names
as needed.

Changed some imports to prevent import of ietf.urls before django
initialization was complete.


Changed 3 cases of form classes being curried to functions; django 1.10
didn't accept that.

Started converting old-style middleware classes to new-style middleware
functions (incomplete).

Tweaked a nomcom decorator to preserve function names and attributes, like
a good decorator should.

Replaced the removed django templatetag 'removetags' with our own version
which uses bleach, and does sanitizing in addition to removing explicitly
mentionied html tags.

Rewrote the filename argument handling in a management command which had
broken with the upgrade.
 - Legacy-Id: 12818
2017-02-11 14:43:01 +00:00
Henrik Levkowetz 7b95411f58 The context_instance parameter to render_to_response() and render_to_string() is now deprecated. Fixed this, and generally changed the idiom render_to_response('template.html', {}, RequestContext(request)) to the newer and simpler render(request, 'template.html', {}). About 200 instances.
- Legacy-Id: 12637
2017-01-09 21:26:30 +00:00
Henrik Levkowetz 5cc3b6448e Django 1.9: Removed additional instances of deprecated django.conf.urls.patterns()
- Legacy-Id: 12623
2016-12-22 18:14:57 +00:00
Lars Eggert eabe46b3f8 Fix a "RemovedInDjango19Warning" warning. Commit ready for merge.
- Legacy-Id: 10671
2016-01-13 12:17:36 +00:00
Henrik Levkowetz e379df0053 Removed the obsolete field Group._ad, and added a migration for the change.
- Legacy-Id: 9147
2015-03-04 17:50:18 +00:00
Robert Sparks 4c9db8f250 This is the first step towards using Role to represent Area directors. It
- Migrates the information captured in GroupInfo.ad to Role objects.
- Renames GroupInfo.ad to GroupInfo._ad (retaining the current column name) to prepare for deletion of that field.
- Provides ad property accessor and setter methods implemented using the group's role_set (so that the existing view code continues to work with minimal changes)
- Improved selection in many querysets that assumed only groups of type 'area' would have area directors.

Related to #1557 and #1555.

Commit ready to merge.
 - Legacy-Id: 8851
2015-01-08 20:22:23 +00:00
Henrik Levkowetz 2a551bb35b Made ietf/group/ pyflakes-clean.
- Legacy-Id: 7465
2014-03-15 17:02:52 +00:00
Ole Laursen ce3e6c59de ._meta.module_name -> ._meta.model_name
- Legacy-Id: 6978
2013-12-18 12:07:04 +00:00
Ole Laursen 99aa5e98f3 Import update_wrapper from functools instead of from Django
- Legacy-Id: 6886
2013-12-11 17:10:26 +00:00
Ole Laursen cfa0d47ca0 Port to new class-based generic redirect and simple template views, remove utils.lazy.reverse_lazy, it's now included in Django
- Legacy-Id: 6878
2013-12-11 16:36:09 +00:00
Henrik Levkowetz bd0c07290a Merged in branch/iola/milestones, which provides datatracker support for management of WG milestones.
- Legacy-Id: 5739
2013-05-15 22:07:23 +00:00
Henrik Levkowetz bcee56d238 Tweaked group/admin.py to show some additional group and group event columns
when listing entries.
 - Legacy-Id: 5685
2013-04-23 15:40:32 +00:00
Ole Laursen b19f6d8060 Merge in milestones branch
- Legacy-Id: 5091
2012-12-03 14:36:30 +00:00
Henrik Levkowetz b5ae9c563f Tweak the GroupHistoryAdmin list_display.
- Legacy-Id: 4914
2012-10-15 20:58:40 +00:00
Henrik Levkowetz 01e20724db Added search fields for 2 GroupEvent admin views.
- Legacy-Id: 4643
2012-07-27 22:15:44 +00:00
Henrik Levkowetz a732ebf8e2 Added admin interface for GroupEvents.
- Legacy-Id: 4619
2012-07-19 14:02:11 +00:00
Ole Laursen 22ce2e709a Make sure milestone.docs is also raw edit to avoid biggish drop down
- Legacy-Id: 4541
2012-06-28 13:57:48 +00:00
Ole Laursen 6c1e87b773 Move milestones branch out of the way to prepare for merge with trunk to get latest charter changes in
[[Split portion of a mixed commit.]]
 - Legacy-Id: 4514.1
2012-06-26 17:47:53 +00:00
Ole Laursen 21c52a34ae Add admin support for GroupHistory and GroupURL.
- Legacy-Id: 4097
2012-03-15 18:07:55 +00:00
Henrik Levkowetz 85e1cfed80 Add filtering by group for Role list page in admin.
- Legacy-Id: 4068
2012-03-07 13:40:57 +00:00
Ole Laursen 562773a081 Turn Group acronym into a SlugField, make the admin prepopulate the acronym
- Legacy-Id: 4012
2012-03-01 13:07:47 +00:00
Ole Laursen dbf5e6ab84 Remove a bunch of old admin files, fix a couple of issues with the new ones, add admin for meeting
- Legacy-Id: 3995
2012-02-28 17:29:52 +00:00
Ole Laursen 29df970cbb Fix RoleAdmin.search_fields to search for the actual contents on
related models instead of the models themselves
 - Legacy-Id: 3889
2012-02-01 17:32:36 +00:00
Ole Laursen 980d4e6444 Move new schema models from redesign/ to ietf/
- Legacy-Id: 3855
2012-01-24 17:17:24 +00:00
Renamed from redesign/group/admin.py (Browse further)