Commit graph

11294 commits

Author SHA1 Message Date
Robert Sparks 07bfa68a75
feat: explicitly model session attendance (#4025)
* feat: add model to track session attendance

* feat: add model to track session attendance

* feat: add api to set session attendees

* fix: use user pk instead off person pk in the attended api.

* feat: calculate three of five from attended

* feat: management utility to populate Attended model history

* docs: document why nomcom calculations don't use Attended yet.

* fix: add migration to add new personalapikey endpoint to choices

* test: verify very old last login prevents api key use,

* chore: address review nits

* chore: comment on some idiosyncracies of the expected input to populate_attended

* fix: add unique_together constraint for the Attended model

* fix: correctly handle empty querysets passed to three_of_five_eligible functions.
2022-06-20 10:46:36 -05:00
Lars Eggert 86e548c952
chore: remove ietf/group/colors.py, which is unused (#4100)
* chore: remove ietf/group/colors.py, which is unused

* Rip out more
2022-06-20 10:31:20 -05:00
rpcross 698f031b7f
feat: separate MeetingRegistration rows for each registration type. updates the registration API (#3641)
* Registration API Update

- change MeetingRegistration.reg_type field to hold only one type
- allow multiple MeetingRegistration records per person/meeting
  (one for each reg_type)

* Fix scope claims

* Add meeting 114 to MeetingRegistration migration

* fix: update stats views for MeetingRegistration model use changes

* refactor: remove unused imports
2022-06-16 15:39:34 -05:00
Lars Eggert 411b5f4747
fix: Fix some HTML validation errors that came in via #4035 (#4066)
* fix: Fix some HTML validation errors that came in via #4035

Also make validation errors display a bit better.

* content -> color for mask-icon (caught by @jennifer-richards; thanks)
2022-06-16 11:59:12 -05:00
Lars Eggert 01c73b8c7c
fix: Make attention indicators less subtle again (#4069)
* fix: Make attention indicators less subtle again

Fixes #4009

* Go back to per-action-holder badges, but make them smaller
2022-06-15 13:47:28 -05:00
Lars Eggert 6e97628a64
fix(ui): badge -> badge rounded-pill (#4076)
* ui: badge -> badge rounded-pill

To make badges look a little less like small buttons.

* Rip out copy&paste error
2022-06-15 13:43:49 -05:00
Lars Eggert 7fc601ee69
fix: Don't let the sort chevron wrap (#4075)
I couldn't figure out a way to not let it wrap *and* float it to the right,
however,

Fixes #4071
2022-06-14 17:37:06 -05:00
Lars Eggert d0e6fd62cb
fix: Make document revisions in timeline clickable again (#4065)
Fixes #4064
2022-06-13 11:16:41 -05:00
Jennifer Richards 53dde975ec
fix: validate group type/acronym properly in admin. Fixes #4028. (#4070)
* fix: validate group type/acronym properly in admin

* chore: remove unused import
2022-06-13 11:14:26 -05:00
Lars Eggert 3d9310818b
fix: Don't allow sorting milestone by order if group doesn't use dates (#4074)
Fixes #4072
2022-06-13 11:08:23 -05:00
Lars Eggert 514944d24e
fix: Fix ballot icon overlapping document title (#4077) 2022-06-13 11:01:06 -05:00
Lars Eggert 7f4a6c19fb
fix: Fix some more underlined whitespace around links (#4053)
* fix: Fix some more underlined whitespace around links

* Another one

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-06-03 11:52:41 -05:00
Robert Sparks 7dfb645678
fix: improve how status is displayed for old draft versions. Fixes #3974. (#4055) 2022-06-03 11:45:01 -05:00
Robert Sparks 13ae0738bf
fix: test web manifest (#4047) 2022-06-02 11:10:11 -05:00
Robert Sparks 02942a6954
chore: bring test names fixture up to match the current database (#4054) 2022-06-02 11:09:47 -05:00
Lars Eggert 525ce6bc68
fix: Correctly scroll to URL fragment after augmenting tables (#4040)
* fix: Correctly scroll to URL fragment after augmenting tables

* feat: Only add search field to longer tables

* Tweak vertical whitespace around search field

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-06-01 11:56:25 -05:00
Lars Eggert 8b339b74e4
fix: Fix include of bootstrap-icons (#4039)
This got broken in #4035, which included some things it wasn't meant to.
2022-06-01 10:55:01 -05:00
Lars Eggert 60ba38defe
fix: Nav links got broken in #3980 (#4032)
Righthand-nav links were no longer clickable since #3980. Fix that.
2022-05-31 17:06:15 -05:00
Lars Eggert 74f2a85d64
refactor: replace flot with highcharts (#4030)
* chore: Replace flot with highcharts

Since flot hasn't been updated since 2014 and was only used in one
place. Simplify how highcharts is initialized and used, and re-enable
pre-bs5 export functionality.

* Fix tests

* Remove some console.log statements
2022-05-31 17:05:27 -05:00
Lars Eggert 337d2ad387
feat: Switch to SVG logo; use it (and new bitmaps) in more places (#4035)
* feat: Switch to SVG logo; use it (and new bitmaps) in more places

* Run images through image_optim

* Copy icons from base template

* Tint icons red when in dev mode
2022-05-31 17:03:43 -05:00
Lars Eggert 159f89ebf3
chore: Remove six and pathlib2 from deps (#4031)
Fixes: #3895 and #3892
2022-05-31 09:12:45 -05:00
Robert Sparks 2f4b493575
fix: Don't show To Subscribe on group about when there's no url to subscribe with. Fixes #4022. (#4023) 2022-05-25 14:52:44 -05:00
Robert Sparks 0e599ea864
fix: show session name on meeting/upcoming. Fixes #4010. (#4017)
* fix: show session name on meeting/upcoming. Fixes #4010.

* fix: remove stray right paren
2022-05-24 15:23:47 -05:00
Lars Eggert bf22223877
Update d3 (#4016)
* Over to slate

* Port to d3@4

* Port to d3@5

* Port to d3@7 (current release)

* Fix axis font size
2022-05-24 11:07:14 -05:00
Lars Eggert 9a24ee7e94
fix: Make AD position colors more noticeable (#4013)
* fix: Make AD position colors more noticeable

Also remove the striping of the table, which makes it easier to notice which
documents are missing a ballot.

* Make "yes" a bit darker

* Stripe the table for non-ADs
2022-05-24 09:51:34 -05:00
Lars Eggert 0a8641cc75
fix: Fix whitespace at end of link (#4015) 2022-05-24 08:55:59 -05:00
Robert Sparks 49cf639f16
fix: improve person selection when receiving IANA email (#3993) 2022-05-20 16:20:26 -05:00
Robert Sparks c89f7c89c5
feat: begin supporting the new rfc editor model (#3960)
* feat: restructure rfcedtype groups. add rpc, rswg, rsab.

* feat: show rfc editor groups on menu

* feat: add the editorial stream

* fix: repair broken html and extent dest coverage.

* chore: address Lars review comment

* chore: update copyright notices.
2022-05-20 12:22:17 -05:00
Lars Eggert fa17ddd705
refactor: tweak the horrible code in SearchableField (#3957)
* Fix: Tweak the horrible code in SearchableField so another corner case works

Fixes #3940. Hopefully doesn't break anything.

* fix: remove incorrect remaining loop.

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-05-19 12:38:10 -05:00
Lars Eggert 8ef92312d0
fix: Don't urlencode all resource URLs (#3988)
While this does suppress errors, it breaks even valid URLs. Instead, just
suppress the validation error for those few cases in the database.
2022-05-19 12:31:29 -05:00
Lars Eggert f39e70a0a0
fix: Don't add newlines at EOF, it cause visible whitespace for HTML includes (#3989) 2022-05-19 08:21:12 -05:00
Lars Eggert a1518e4dcb
fix(ui): debounce the scroll event to make chrome happy (#3958)
* fix: Debounce the scroll event, to make Chrome happy

* Address review comments

* fix: Prevent overscrolling from scrolling the main content

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-05-18 14:01:22 -05:00
Lars Eggert de6d8b2b2a
fix: Prevent righthand-nav from overlapping the footer on short screens (#3980)
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
2022-05-18 13:19:23 -05:00
Lars Eggert de7ff7e84e
test: fix more validation issues (#3975)
* fix: Avoid numeric IDs on NomCom pages

* fix: Correctly group last names with lowercase/i18n parts

* Remove some unneeded CSS

* fix: Remove extra div closing tag
2022-05-18 10:58:39 -05:00
Jennifer Richards 4a5583845e
fix(ui): import moment.js library with moment-timezone support in wrapper (#3977)
* fix: import moment.js library with moment-timezone support in wrapper

Packaging changes broke the mechanism used to make moment.tz available
to javascript code. This eliminates the separate moment.js and
moment-timezone-with-data-10-year-range.js wrappers and instead
imports the timezone-augmented version directly. This provides both
the timezone support and the regular moment features.

* refactor: put moment on window instead of global for consistency
2022-05-18 09:23:07 -05:00
Robert Sparks 249db17ae7
chore: keep the database in sync with django-simple-history (#3967) 2022-05-14 08:12:35 -05:00
Nicolas Giard 8a7f67d4d1
test: make tests run without root access (#3968) 2022-05-14 08:11:44 -05:00
Lars Eggert f4ce041dcc
fix: Add whitespace before "for" (#3951) 2022-05-13 14:13:14 -05:00
Lars Eggert 75a32d2210
fix: Link to reviews from search status column (#3955)
* fix: Link to reviews from search status column

Fixes #3953

* fix: Make the notices about exceeded state times less obtrusive

* Fix tests
2022-05-13 14:05:42 -05:00
Lars Eggert b265bac1fe
fix: Fix action holder form buttons (#3956)
Fixes #3943
2022-05-13 14:01:14 -05:00
Lars Eggert 39525a1cd0
fix: escape the ballot comments (#3952)
I wonder if other fields that have class `pasted` would need to be escaped, too?
2022-05-12 12:17:48 -05:00
Jennifer Richards cb996c5c0b
fix: refactor/correct calculation of week-view event start/end times (#3947)
* fix: use DST-friendly tz calculation for TimeSlot end times

Around DST changes, localize(time + duration).astimezone() is not
the same as localize(time).astimezone() + duration. The latter allows
tz-aware times to do their magic and give correct clock times.

* fix: refactor/correct calculation of week-view event start/end times

There were bugs in the timestamp calculations around DST switchover.
This corrects those and tries to clarify and improve documentation in
the relevant code.
2022-05-11 16:08:47 -05:00
Lars Eggert 5f8d4ed718
More HTML nitfixing (#3934)
* Unicode messages are triggered by both db content and tests

* Make ids unique

* Avoid "No value found" message on page

* Strip HTML from history entries, it's often broken

* Check HTML sources for occurrences of "** No value found for" and fix them

* Fix another occurrence of "** No value found for"

* Fix more occurrences of "** No value found for"

* Fix document revision stripping

* Force breaks of long (garbage) words

* Check URL validity before urlizing them

* Handle some additional corner cases

* Linkify action items

* Don't create profile/email links for System

* Handle headings with HTML elements in them better

* Fix comment

* Fix another occurrence of "** No value found for"

* Better I-D URLization that handles more edge cases. Also, test for them.

* Remove print

* Handle charters better

* Cache for one day
2022-05-10 12:37:14 -05:00
Robert Sparks 47b89c1112
chore: alter CSP to enable analytics (#3941) 2022-05-09 13:38:50 -05:00
Robert Sparks cdd86b9d5e
ci: show makemigrations output (#3932)
* ci: show makemigrations output

* chore: remove unused releasetest settings
2022-05-03 20:54:25 -05:00
Robert Sparks def13a872a
chore: catchup with pytz country (#3933) 2022-05-03 20:54:02 -05:00
Robert Sparks d4ebbe41e8
feat: improve notes imports by using de-gfm -4. Related to #3851. (#3930) 2022-05-03 18:04:48 -05:00
Lars Eggert 5598762608
fix: add more HTML validation & fixes (#3891)
* Update vnu.jar

* Fix py2 -> py3 issue

* Run pyupgrade

* test: Add default-jdk to images

* test: Add option to also validate HTML with vnu.jar

Since it's already installed in bin. Don't do this by default, since it
increases the time needed for tests by ~50%.

* fix: Stop the urlizer from urlizing in linkified mailto: text

* More HTML fixes

* More HTML validation fixes

* And more HTML fixes

* Fix floating badge

* Ignore unicode errors

* Only URLize docs that are existing

* Final fixes

* Don't URLize everything during test-crawl

* Feed HTML into vnu using python rather than Java to speed things up

* Allow test-crawl to start vnu on a different port

* Increase retry count to vnu. Restore batch size to 30.

* More HTML validation fixes

* Use urllib3 to make requests to vnu, since overriding requests_mock is tricky

* Undo commit of unmodified file

* Also urlize ftp links

* Fix matching of file name

* More HTML fixes

* Add `is_valid_url` filter

* weekday -> data-weekday

* urlencode URLs

* Add and use vnu_fmt_message. Bump vnu max buffer.

* Simplify doc_exists

* Don't add tab link to mail archive if the URL is invalid

* Run urlize_ietf_docs before linkify

Reduces the possibility of generating incorrect HTML

* Undo superfluous change

* Runner fixes

* Consolidate vnu message filtering into vnu_filter_message

* Correctly handle multiple persons with same name

* Minimze diff

* Fix HTML nits

* Print source snippet in vnu_fmt_message

* Only escape if there is something to escape

* Fix snippet

* Skip crufty old IPR declarations

* Only include modal when needed. Add handles.

* Fix wordwrap+linkification

* Update ietf/doc/templatetags/ietf_filters.py

* Update ietf/doc/templatetags/tests_ietf_filters.py

* Don't right-align second column
2022-05-03 13:55:48 -05:00
Lars Eggert 19796c56c9
fix: Stretch righthand-nav to viewport edge (#3921)
* fix: Stretch righthand-nav to viewport edge

Fixes #3848

* Also improve tz-select display, while we're here

* Change func name
2022-05-03 09:35:10 -05:00
Lars Eggert 169ab1c10f
fix: Adopt -> Manage adoption (#3922)
Fixes #3877
2022-05-03 09:32:24 -05:00