Fix#2478 - When completing review, show which addresses it is posted to.
- Legacy-Id: 16795
Note: SVN reference [16688] has been migrated to Git commit 68ea11a916
Fix#2354 - Make review_completed configurable per team and review type
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
- Legacy-Id: 16794
Note: SVN reference [16680] has been migrated to Git commit 1390ae073c
Fix#2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
- Legacy-Id: 16793
Note: SVN reference [16672] has been migrated to Git commit 88b7b45b0e
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
Commit ready for merge.
- Legacy-Id: 16792
Fix#2590 - Allow secretary to adjust date when completing a review.
This also fixes other issues identified in #2590, around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
created, set to current date/time.
- When the secretary records a review in the datatracker, they may
set a different completion date, which is autofilled if an email
is selected. One event is generated for the original completion
date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
existing events.
- Legacy-Id: 16791
Note: SVN reference [16670] has been migrated to Git commit 3942f9acc7
Fix#2560 - Sort names in history when changing list of members.
- Legacy-Id: 16789
Note: SVN reference [16668] has been migrated to Git commit de9cde9e43
Guard against attempts to use the review request view with a ReviewRequest id that does not match the document for the ReviewRequest. This would have exposed #2776 much earlier.
- Legacy-Id: 16710
Note: SVN reference [16649] has been migrated to Git commit 01ceeba131
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes#2776.
- Legacy-Id: 16708
Note: SVN reference [16647] has been migrated to Git commit 87de06c97c
Don't manually linewrap when looking at feedback - let the pasted styling do that. Fixes#2761.
- Legacy-Id: 16706
Note: SVN reference [16646] has been migrated to Git commit 33838840d1
The interleaved_migrations_test currently fails due to the various
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
Commit ready for merge.
- Legacy-Id: 16705
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
- Legacy-Id: 16704
This fixes a syntax error and a Python 3 incompatibility, and adds
send-review-reminders to the daily cron script.
Important notes:
- I have not tested to what degree the existing reminders work as they
should, as that's out of scope. It does have tests.
- I can't assess whether the virtualenv activation works in the
production setup, and it may be obsolete as bin/daily also
activates the virtualenv.
- The same Python 3 incompatibility (execfile() no longer exists) seems
to exist in various other scripts.
Commit ready for merge.
- Legacy-Id: 16703
Rework how we are labeling constraints to provide a quick-fix for session requests at IETF106. Turned off several javascript functions that added/enforced old (possibly no longer correct) semantics for the session request forms. Fixes#2754.
- Legacy-Id: 16699
Note: SVN reference [16630] has been migrated to Git commit 10422f87d2
Removing unused template. I think it was an artifact of the Django 1.2 to 1.6 conversion from 6 years ago.
- Legacy-Id: 16698
Note: SVN reference [16629] has been migrated to Git commit 798a57c9ab
Improved so that new draft diffs (from the working group drafts page) work correctly for both -00 drafts and later revisions. Fixes issue #2697.
- Legacy-Id: 16693
Note: SVN reference [16614] has been migrated to Git commit 390ff04722
Look at all scheduled sessions for a group when deciding to display a cancelled banner. Fixes#2764.
- Legacy-Id: 16691
Note: SVN reference [16604] has been migrated to Git commit aea3c1a55b1b14f9da90d0cfb03891e7129f8632
This includes a migration to change mailtrigger slugs to be up to 64
characters instead of 32, as some slugs would not fit and require clunky
abbreviations.
A data migration creates triggers for existing teams, and they are also
created on the fly if a trigger does not exist yet, providing a safe
fallback for new review teams. The review_completed mailtrigger serves
as the template for new triggers.
This commit also includes tests for gather_address_lists(), as none
existed.
Commit ready for merge.
- Legacy-Id: 16680
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
Commit ready for merge.
- Legacy-Id: 16672
This also fixes other issues identified in #2590, around the
modification of historical document events. The behaviour is now:
- When the assigned reviewer posts a review, a single event is
created, set to current date/time.
- When the secretary records a review in the datatracker, they may
set a different completion date, which is autofilled if an email
is selected. One event is generated for the original completion
date, and one for the secretary's action.
- Each revision generates a new event, rather than updating previous
existing events.
- Legacy-Id: 16670
Remove a debug statement from the command
- Legacy-Id: 16661
Note: SVN reference [16603] has been migrated to Git commit d27096f39022e9bee1ffa84631d5ae847af9be3e
A management command to correct the state of several slide presentations uploaded during IETF105, and perform some missed powerpoint to pdf conversions.
- Legacy-Id: 16659
Note: SVN reference [16601] has been migrated to Git commit a14188d95cf200dfbdd93485b89808f3336b0649
Fixed a subtle bug in the code that converts slides to PDF that was writing back into settings.
- Legacy-Id: 16645
Note: SVN reference [16600] has been migrated to Git commit b4714f95579efcb5051438239a5df002036c9975
Correct the uploaded_filename for slides that go through the approve-proposed-slides workflow.
- Legacy-Id: 16644
Note: SVN reference [16599] has been migrated to Git commit f6b05ae963b9933dc8522f5db86eb33086d8f040
Add the ppt* to pdf conversion to the approve-suggested-slides workflow. Fixes#2762.
- Legacy-Id: 16643
Note: SVN reference [16598] has been migrated to Git commit c43dcaa8ea707c089fc66f52c361944cef1d4874
Use unversioned slide link from the materials popup from the agenda page. Fixes#2756.
- Legacy-Id: 16612
Note: SVN reference [16594] has been migrated to Git commit 51a874dec4a06a707eb3547f6dd443cfbed94bd4
Sort the documents in the agenda, minutes, bluesheets section of the session_details view. Fixes#2759.
- Legacy-Id: 16611
Note: SVN reference [16593] has been migrated to Git commit f2dd064afdc77168c12897a630600a17631b390f
Change how the session details page links to documents to not link to a specific version. Fixes#2758. See also #2756.
- Legacy-Id: 16610
Note: SVN reference [16592] has been migrated to Git commit c6c086b122dbd57cb6a55ed7f68be4a8dfd877b6
Example of using webtest. The full testcase was not converted because the add_rule form is modified in-flight by javascript when a control value is changed.
- Legacy-Id: 16609
Note: SVN reference [16590] has been migrated to Git commit e89f200abc0d9af7609e4bff3592f87eddee1359
Restore ability to remove documents while managing a personal list. Required updating code to match the recent change to Document's primary key. Fixes#2757.
- Legacy-Id: 16608
Note: SVN reference [16583] has been migrated to Git commit 821609888a2c8a6db67867dd334103b034157d20
Add quotes around document name in the mailarchive search link on a document's main page. Fixes#2659.
- Legacy-Id: 16606
Note: SVN reference [16569] has been migrated to Git commit b4a40313c95511693ae8a361aabb355878555fb7
