Commit graph

215 commits

Author SHA1 Message Date
Henrik Levkowetz 1656b0012c Merged in [16819] from sasha@dashcare.nl:
Fix #2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to 'requested', which means
it will be shown as an unassigned review in all interfaces.
 - Legacy-Id: 16881
Note: SVN reference [16819] has been migrated to Git commit fdb4c2a055
2019-10-21 13:45:03 +00:00
Henrik Levkowetz 7728231f74 Migration for help text changes for a couple of ReviewTeamSettings and ReviewerSettings fields.
- Legacy-Id: 16868
2019-10-15 17:22:52 +00:00
Henrik Levkowetz 4d7db7e1d4 Rearranged some migrations.
- Legacy-Id: 16864
2019-10-15 16:46:42 +00:00
Henrik Levkowetz a66fa82b06 Fixed some review reminders issues.
- Legacy-Id: 16863
2019-10-15 16:46:12 +00:00
Henrik Levkowetz 985397803b Corrected some migration numbers.
- Legacy-Id: 16851
2019-10-09 14:33:33 +00:00
Henrik Levkowetz be641ac22a Merged in [16792] from sasha@dashcare.nl:
Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.
 - Legacy-Id: 16846
Note: SVN reference [16792] has been migrated to Git commit 486b6daa29
2019-10-08 15:57:28 +00:00
Henrik Levkowetz 9361b7d540 Turned the ReviewAssignmentAdmin.review field into a raw_id_field, to avoid a form that lists all documents in the database in a drop-down. Fixes issue #2810.
- Legacy-Id: 16843
2019-10-08 13:57:25 +00:00
Henrik Levkowetz 0763dc3856 Merged in [16771] from rjsparks@nostrum.com:
Add migration intended for r16770. Related to #2782.
 - Legacy-Id: 16842
Note: SVN reference [16771] has been migrated to Git commit f3fb0f8c20941710d675ca4bb2873635c2fa8624
2019-10-08 13:12:29 +00:00
Henrik Levkowetz 678f8a5787 Merged in [16765] from sasha@dashcare.nl:
Refs #2277 - Send daily reminders of overdue reviews to secretaries
 - Legacy-Id: 16839
Note: SVN reference [16765] has been migrated to Git commit cc64992204
2019-10-08 10:41:37 +00:00
Henrik Levkowetz 09e38dffa0 Merged in [16705] from sasha@dashcare.nl:
Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.
 - Legacy-Id: 16823
Note: SVN reference [16705] has been migrated to Git commit ec56a03ec6
2019-10-04 17:09:57 +00:00
Henrik Levkowetz 4c3e869d5c Merged in [16704] from sasha@dashcare.nl:
Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
 - Legacy-Id: 16822
Note: SVN reference [16704] has been migrated to Git commit 179c151f9e
2019-10-04 14:07:54 +00:00
Sasha Romijn fdb4c2a055 Fix #2186 - Return review req to 'requested' status if no review assignments are open.
If a review assignment is rejected, withdrawn, marked no response, etc.,
and this leaves a review request without any assigned/accepted/completed
review assignments, return the request state to "requested", which means
it will be shown as an unassigned review in all interfaces.

Commit ready for merge.
 - Legacy-Id: 16819
2019-10-03 09:02:34 +00:00
Henrik Levkowetz 70380cb8ea Merged in [16672] from sasha@dashcare.nl:
Fix #2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.
 - Legacy-Id: 16793
Note: SVN reference [16672] has been migrated to Git commit 88b7b45b0e
2019-10-01 13:06:48 +00:00
Sasha Romijn 486b6daa29 Fix #2475 - Send opt-in reminders for unconfirmed review assignments.
If enabled for a team, reminders will be sent every X days to reviewers
for review assignments they have not accepted or rejected.

Commit ready for merge.
 - Legacy-Id: 16792
2019-10-01 13:01:19 +00:00
Henrik Levkowetz 10c8596664 Merged in [16667] from sasha@dashcare.nl:
Fix #2071 - Add optional comment field for close request.
 - Legacy-Id: 16786
Note: SVN reference [16667] has been migrated to Git commit 4669b0934b
2019-09-30 20:55:16 +00:00
Henrik Levkowetz 33e8733b91 Fixed up mypy issues or added type:ignore comments as needed for a clean mypy run.
- Legacy-Id: 16772
2019-09-30 15:42:18 +00:00
Sasha Romijn cc64992204 Refs #2277 - Send daily reminders of overdue reviews to secretaries
Commit ready for merge.
 - Legacy-Id: 16765
2019-09-30 12:27:43 +00:00
Henrik Levkowetz 3349d64479 Merged in [16647] from rjsparks@nostrum.com:
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes #2776.
 - Legacy-Id: 16708
Note: SVN reference [16647] has been migrated to Git commit 87de06c97c
2019-09-05 21:26:54 +00:00
Sasha Romijn ec56a03ec6 Fix #2337 - Send periodic reminders of open reviews every X days (opt-in)
The interleaved_migrations_test currently fails due to the various 
migrations that have been added for individual tickets/commits (unless
--permit-mixed-migrations is set). I think this is better fixed in a
later cleanup, as doing it now could cause confusion when merging
individual commits, and more migrations are likely to be added soon.

Commit ready for merge.
 - Legacy-Id: 16705
2019-09-05 15:02:56 +00:00
Sasha Romijn 179c151f9e Fix #2231 - Send reminders before long UnavailabilityPeriods expire
A notification is sent to the team secretary and reviewer, if an
unavailability period lasting 30 days or more will end in 3 days.
Commit ready for merge.
 - Legacy-Id: 16704
2019-09-05 11:59:40 +00:00
Sasha Romijn 88b7b45b0e Fix #2328 - Use mailtriggers to find destinations in review app
As the review app has several conditionals that don't fit
entirely well within mailtriggers, the templates use a bit
of extra context to figure out who exactly to include. This also
extends the tests for review, to check for correct recipients.
It also adds a tiny feature to mailtrigger to entirely exclude
certain addresses, as required by the review-generated mails.

Commit ready for merge.
 - Legacy-Id: 16672
2019-08-27 15:15:13 +00:00
Sasha Romijn 4669b0934b Fix #2071 - Add optional comment field for close request. Commit ready for merge.
- Legacy-Id: 16667
2019-08-23 11:37:41 +00:00
Robert Sparks 87de06c97c Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes #2776. Commit ready for merge.
- Legacy-Id: 16647
2019-08-13 18:13:50 +00:00
Henrik Levkowetz 8e313e4ed5 Adjusted migrations for Python2/3 compatibility.
- Legacy-Id: 16633
2019-08-08 17:11:14 +00:00
Henrik Levkowetz bdc73e771a Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz ea8c84d2f6 Python2/3 compatibility: used @python_2_unicode_compatible to provide __unicode__() versions of __str__() methods.
- Legacy-Id: 16455
2019-07-15 18:01:26 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz 36cac48063 Fixed a bunch of str/bytes issues.
- Legacy-Id: 16341
2019-06-30 20:54:09 +00:00
Henrik Levkowetz 4b080c8042 Added a simple functional test for hash_list_message_id()
- Legacy-Id: 16337
2019-06-30 17:55:54 +00:00
Henrik Levkowetz 484dcece5f Changed all model __unicode__() methods to __str__()
- Legacy-Id: 16330
2019-06-28 21:07:08 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz 7270d5f67a Added the option to order API resource lists by primary key, for stable ordering when paging through a list.
- Legacy-Id: 16284
2019-06-18 12:40:19 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz a2cafded25 Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz cfbaf5b1a9 Fixed a pyflakes issue.
- Legacy-Id: 16193
2019-05-06 14:38:34 +00:00
Henrik Levkowetz fae7444df8 Updated the ReviewAssignment api resource to match the current model.
- Legacy-Id: 16189
2019-05-06 13:36:16 +00:00
Henrik Levkowetz 9282195d6c Fixed some migrations issues that prevented the review assignment refactoring migrations from being reversed and re-applied.
- Legacy-Id: 16182
2019-05-02 13:49:14 +00:00
Henrik Levkowetz ca1f3340c0 Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability.
- Legacy-Id: 16181
2019-05-02 12:38:41 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz 3ec9d7b678 Updated the role handling to use GroupFeatures.groupman_roles consistently for group management access. Fixes a IRTF RG delegate permissions issue.
- Legacy-Id: 16160
2019-04-25 13:19:30 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com:
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Henrik Levkowetz 82672519df Undid previous merge
- Legacy-Id: 16113
2019-03-28 11:05:25 +00:00
Henrik Levkowetz 6a159ebdfd Merged in [16094] from magnus.westerlund@ericsson.com:
Added sortable columns to Review Team Reviewers page. Partially addresses issue #2656
 - Legacy-Id: 16112
Note: SVN reference [16094] has been migrated to Git commit 0c0e75861e
2019-03-28 11:02:52 +00:00
Robert Sparks 6dc25cae1a Bring time series stats back into line with what was before. Note there was an off-by-one-day bug in the month-binning in prior releases.
- Legacy-Id: 16075
2019-03-20 20:04:06 +00:00
Robert Sparks 81c5b5091a Made some docevent creation more consistent. Addressed the TODOs added during the refactor.
- Legacy-Id: 16049
2019-03-19 18:48:05 +00:00
Robert Sparks da3174ab68 Improved several views.
- Legacy-Id: 16038
2019-03-18 19:41:07 +00:00