Robert Sparks
87de06c97c
Corrected a view that was looking at review assignment ids when it should have been looking at request review ids. Fixes #2776 . Commit ready for merge.
...
- Legacy-Id: 16647
2019-08-13 18:13:50 +00:00
Henrik Levkowetz
bdc73e771a
Python2/3 compatibility: replaced six.ensure_text() with either six.text_type or django's force_text(), depending on the case, and fixed a variable scope issue.
...
- Legacy-Id: 16461
2019-07-16 13:20:05 +00:00
Henrik Levkowetz
8c6eb3a30a
Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
...
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz
d7f5c84182
Initial 2to3 patch with added copyright statement updates.
...
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz
a2cafded25
Changed DocAlias to be many-to-many, in order to be able to handle STD aliases referring to multiple RFCs.
...
- Legacy-Id: 16249
2019-06-14 20:38:14 +00:00
Henrik Levkowetz
815602351f
This is a series of 50 migrations that changes the Document and DocAlias
...
primary keys from character strings to integers, and makes corresponding code
changes.
This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.
Changing the primary keys to integers should also improve efficiency.
Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time. The total set of migrations are expected to have
a runtime on the order of 2 hours.
- Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz
ca1f3340c0
Changed a ReviewAssignmentDocEvent type from 'closed_review_request' to 'closed_review_assignment', for consistency and readability.
...
- Legacy-Id: 16181
2019-05-02 12:38:41 +00:00
Henrik Levkowetz
8726e74709
Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
...
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz
3ec9d7b678
Updated the role handling to use GroupFeatures.groupman_roles consistently for group management access. Fixes a IRTF RG delegate permissions issue.
...
- Legacy-Id: 16160
2019-04-25 13:19:30 +00:00
Henrik Levkowetz
bb4fe3fbbf
Undid previous commit
...
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz
cfcefc2e32
Merged in [16144] from housley@vigilsec.com:
...
Remove some clutter from I-D upload page. The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057 .
- Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Robert Sparks
6dc25cae1a
Bring time series stats back into line with what was before. Note there was an off-by-one-day bug in the month-binning in prior releases.
...
- Legacy-Id: 16075
2019-03-20 20:04:06 +00:00
Robert Sparks
81c5b5091a
Made some docevent creation more consistent. Addressed the TODOs added during the refactor.
...
- Legacy-Id: 16049
2019-03-19 18:48:05 +00:00
Robert Sparks
da3174ab68
Improved several views.
...
- Legacy-Id: 16038
2019-03-18 19:41:07 +00:00
Robert Sparks
4b147f2ef8
More cleanup and correction. Caught a pervasive misuse of a state-name
...
- Legacy-Id: 16036
2019-03-15 20:39:06 +00:00
Robert Sparks
3678d20b0b
Some cleanup around stats. Things are well except for the time series graphs.
...
- Legacy-Id: 16035
2019-03-15 16:50:59 +00:00
Robert Sparks
a4db66564c
Checkpoint. Ended up chasing group.views_review before stats.
...
- Legacy-Id: 16030
2019-03-13 22:02:10 +00:00
Robert Sparks
073ce55f6c
Checkpoint. ReviewTests pass, but others still fail of course. Next step is to address stats.
...
- Legacy-Id: 16021
2019-03-12 17:48:19 +00:00
Henrik Levkowetz
682ddee8e4
Reverted earlier application of on_behalf_of() at mail sending call points, and instead did all on_behalf_of processing in condition_message(). Added insertion of Reply-To header fields in this case. Changed all use of the mail-sending 'extra' parameters to use value lists. Updated a bunch of tests accordingly.
...
- Legacy-Id: 16020
2019-03-11 17:01:33 +00:00
Robert Sparks
b85052fe63
Checkpoint. Lots of tests will still fail. Reordered some migrations. Brought about half of the ietf.doc.views_review views into line with the new models. Next step is the other half.
...
- Legacy-Id: 16012
2019-03-07 23:08:14 +00:00
Henrik Levkowetz
8a669909bc
Changed ietf/utils/mail.py to use unicode strings, and changed a call in ietf/reviv/utils.py to use unicode for mail Subject, to fix a server 500 issue.
...
- Legacy-Id: 16007
2019-03-06 16:57:00 +00:00
Henrik Levkowetz
435a0da12d
Added on_behalf_of() calls for from addresses needing it throughout the code.
...
- Legacy-Id: 15992
2019-03-04 20:14:19 +00:00
Robert Sparks
e91d706d5b
Checkpointing. This is an incomplete idea. The tests will fail massively.
...
- Legacy-Id: 15985
2019-03-01 23:19:47 +00:00
Henrik Levkowetz
57a4c9f41f
Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
...
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Henrik Levkowetz
e024cca8c4
Merged in [15708] and [15730] from housley@vigilsec.com:
...
Added a mail alias for all review team secretaries. Fixes #2139 . Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15747
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 20:32:42 +00:00
Henrik Levkowetz
3b811ecb41
Merged in [15708] and [15730] from housley@vigilsec.com:
...
Added a mail alias for all review team secretaries. Fixes #2139 . Use
the alias if there is one for email about review request changes. Added
a test for the review team secretary alias functionality.
- Legacy-Id: 15746
Note: SVN reference [15708] has been migrated to Git commit 6067dcbfef
Note: SVN reference [15730] has been migrated to Git commit d525ade0b0
2018-11-10 19:30:32 +00:00
Henrik Levkowetz
89ef806013
Merged in [15701] from kivinen@iki.fi:
...
Changed format of the reviewer statistics in lists. Fixes #2131 .
- Legacy-Id: 15735
Note: SVN reference [15701] has been migrated to Git commit 56acd00c6c
2018-11-07 05:24:25 +00:00
Russ Housley
d525ade0b0
Use review team secretary alias if there is one for email about review request changes. Add test for review team secretary alias. Commit ready for merge.
...
- Legacy-Id: 15730
2018-11-06 07:26:30 +00:00
Tero Kivinen
56acd00c6c
Changed format of the reviewer statistics in lists. Fixes #2131 . Commit ready for merge.
...
- Legacy-Id: 15701
2018-11-03 09:04:57 +00:00
Robert Sparks
fd8af4b6f7
Review assignment email includes a link to the review request that ensures the reviewer is logged in. Fixes #2543 . Commit ready for merge
...
- Legacy-Id: 15444
2018-09-06 21:39:10 +00:00
Henrik Levkowetz
080f6b4385
Added group links to the past meetings page, and also important dates links to IETF meetings with important-date pages.
...
- Legacy-Id: 15053
2018-04-18 13:15:30 +00:00
Henrik Levkowetz
838ad9cf44
Added page counts for open review requests on the reviewer assignment drop-downs of /group/*/reviews/manage/unassigned/. Fixes issue #2449 .
...
- Legacy-Id: 14644
2018-02-15 18:39:39 +00:00
Robert Sparks
7b89db153e
Take a different approach to avoiding the crash when a team secretary uses the bulk assignment form to unassign a request. Reverts r14570. Fixes #2443 . Commit ready for merge.
...
- Legacy-Id: 14623
2018-02-07 17:58:27 +00:00
Henrik Levkowetz
eb6341d826
Removed the possibility of choosing '(None)' as reviewer from the bulk review request edit form; this prevents a crash on line 1474 of ietf/group/views.py, in manage_review_request(). The view code needs further care in order make it possible to unassign an assignment here.
...
- Legacy-Id: 14570
2018-01-25 15:58:59 +00:00
Robert Sparks
ba8b4d3a38
Allow those people who can make a review request to edit the request deadline. Send mail to other directorate secretaries when one secretary makes a change to a request. Fixes #2233 . Commit ready for merge.
...
- Legacy-Id: 14549
2018-01-22 21:43:53 +00:00
Robert Sparks
0a9737a5d2
Include information about previous team reviews in assignement emails. Fixes #2392 . Commit ready for merge.
...
- Legacy-Id: 14466
2017-12-26 22:13:13 +00:00
Robert Sparks
617dac49d6
Send email to reviewer when request is closed with no response. Fixes #2176 . Commit ready to merge.
...
- Legacy-Id: 13897
2017-07-15 12:07:20 +00:00
Henrik Levkowetz
ce1b655fa2
Code reorganization, doing away with multiple urls_* and views_ files in ietf.group. No intentional functionality changes.
...
- Legacy-Id: 13709
2017-06-22 15:18:08 +00:00
Henrik Levkowetz
023a32715d
Merged in ^/branch/iola/author-stats-r13145 from olau@iola.com, with additional features from ^/personal/henrik/6.52.1-authorstats.
...
- Legacy-Id: 13550
2017-06-06 18:36:59 +00:00
Henrik Levkowetz
2bacdd3a00
Merged in [13500] from rjsparks@nostrum.com:
...
Provide assigned dates on review team reviewers page. Fixes #2304 . Related to #2305 .
- Legacy-Id: 13518
Note: SVN reference [13500] has been migrated to Git commit e422717f91eb26a0691347beca9380889d8ee890
2017-06-04 17:31:25 +00:00
Henrik Levkowetz
76628be3fd
Merged in ^/branch/iola/author-stats-r13145 from olau@iola.dk, and fixed some tests in code which moved after the latest merge with trunk. The test suite passes, but the migrations are _not_ ready to run, because of numbering conflicts (again due to code changes on trunk since the latest sync).
...
- Legacy-Id: 13479
2017-05-31 20:59:26 +00:00
Henrik Levkowetz
27ff3850eb
Fixed a place where the LastCallDocEvent expiry value was set as a date instead of a datetime.
...
- Legacy-Id: 13256
2017-04-30 18:57:05 +00:00
Ole Laursen
5b677dc6ba
Merge author stats branch into new branch from trunk
...
- Legacy-Id: 13159
2017-03-28 14:36:40 +00:00
Lars Eggert
8a70e9773d
Fix various "RemovedInDjango20Warning" warnings. Commit ready for merge.
...
- Legacy-Id: 13112
2017-03-25 19:16:45 +00:00
Henrik Levkowetz
4daf66d11c
Added DocEvent rev= parameter througout the code.
...
- Legacy-Id: 12978
2017-03-06 15:08:21 +00:00
Ole Laursen
9308948195
Add person, affiliation and country (through django-countries) to
...
DocumentAuthor, rename author field to email and make it optional (for
modeling old email-less submissions), remove the authors many to many
referencing field from Document as it is not really pointing the right
place.
Update the Secretariat tools to show affiliation and country.
Add migration for getting rid of the fake email addresses that the
migration script created some years ago (just set the author email
field to null).
- Legacy-Id: 12739
2017-01-26 17:10:08 +00:00
Robert Sparks
8e007ce50b
Make changing skip_next on a review assignment an explicit decision of the assigner. Commit ready for merge. Fixes #2148 .
...
- Legacy-Id: 12670
2017-01-19 14:23:09 +00:00
Robert Sparks
10f4892eae
Send mail to team secretaries when a review is explicitly requested. Change the From and Subject for assignment emails to reviewers to make it clearer what the review is for and who assigned it. Fixes #2053 and #2114 . Commit ready for merge.
...
- Legacy-Id: 12593
2016-12-19 22:32:03 +00:00
Henrik Levkowetz
fa684cf6d2
Merged in [12541] from rjsparks@nostrum.com:
...
Provide default filters for reviewer settings. Fixes #2093 .
- Legacy-Id: 12546
Note: SVN reference [12541] has been migrated to Git commit df86798cf3
2016-12-15 21:57:46 +00:00
Henrik Levkowetz
b14e981e66
Merged in [12520] from rjsparks@nostrum.com:
...
Slight refactor of the review models to capture review team settings. Allows configuring review teams to get automatic suggestions for reviews or not. Provides a better admin for creating/managing review teams. Fixes #2048 and #2072 .
- Legacy-Id: 12544
Note: SVN reference [12520] has been migrated to Git commit b24bdb5bc3
2016-12-15 20:55:40 +00:00