Commit graph

235 commits

Author SHA1 Message Date
Henrik Levkowetz 8adae6176d Improved a check for authenticated user.
- Legacy-Id: 16521
2019-07-18 19:30:01 +00:00
Henrik Levkowetz 8c6eb3a30a Python2/3 compatibility: Changed the use of open() and StringIO to io.open() etc.
- Legacy-Id: 16458
2019-07-15 19:14:04 +00:00
Henrik Levkowetz 831fb18f8a Python2/3 compatibility: Added force_str or force_bytes in some places, to ensure the argument right type
- Legacy-Id: 16450
2019-07-15 15:49:35 +00:00
Henrik Levkowetz 2d7c9629aa Added 'from __future__' imports all over the place, to bring code behaviour into closer alignment between python2 and python3
- Legacy-Id: 16446
2019-07-15 15:40:51 +00:00
Henrik Levkowetz f8d4c3c9a6 More assertContains() and BytesIO() related changes.
- Legacy-Id: 16411
2019-07-07 12:45:57 +00:00
Henrik Levkowetz 0679eaa8d4 Removed unused imports.
- Legacy-Id: 16402
2019-07-04 21:06:57 +00:00
Henrik Levkowetz f480799af9 Undid unintentional bulk commit
- Legacy-Id: 16401
2019-07-04 21:04:46 +00:00
Henrik Levkowetz fc09a59950 Added decode() of command pipe output.
- Legacy-Id: 16400
2019-07-04 21:01:39 +00:00
Henrik Levkowetz 97a555936d Changed a large number of test assertions to use assertContains() and removed separate, now unnecessary,status_code checks. Also changed many assertTrue(... in ...) to use assertIn().
- Legacy-Id: 16346
2019-06-30 21:03:34 +00:00
Henrik Levkowetz 36cac48063 Fixed a bunch of str/bytes issues.
- Legacy-Id: 16341
2019-06-30 20:54:09 +00:00
Henrik Levkowetz 15e74e89cb Converted instances of assertTrue(text in response.content) to the recommended assertContains(response, text), and similar for assertFalse(... in ...)
- Legacy-Id: 16336
2019-06-29 13:43:31 +00:00
Henrik Levkowetz 3ec7e864be Converted leading tabs to spaces in ietf/**/*.py
- Legacy-Id: 16310
2019-06-27 14:51:02 +00:00
Henrik Levkowetz d7f5c84182 Initial 2to3 patch with added copyright statement updates.
- Legacy-Id: 16309
2019-06-27 14:40:54 +00:00
Henrik Levkowetz db12f2b948 Fixed some name versus pk issues lingering after the Document/DocAlias primary key refactoring. Fixes issue #2729.
- Legacy-Id: 16288
2019-06-19 12:57:52 +00:00
Henrik Levkowetz 426870b766 Merged in the Document and DocAlias primary key change and m2m work in ^/personal/henrik/6.96.1-docalias.
- Legacy-Id: 16261
2019-06-15 12:00:48 +00:00
Henrik Levkowetz 815602351f This is a series of 50 migrations that changes the Document and DocAlias
primary keys from character strings to integers, and makes corresponding code
changes.

This was prompted by database limitations discovered when trying to make
DocAlias use a m2m document field; with 255 long strings as primary keys for
Document and DocAlias this violated the MySQL database limitations.

Changing the primary keys to integers should also improve efficiency.  

Due to the data migrations which create the new integer primary keys and adds
corresponding integer foreign keys matching the previous string foreign keys
in all tables having foreign keys to Document and DocAlias, some of these
migrations take a long time.  The total set of migrations are expected to have
a runtime on the order of 2 hours.
 - Legacy-Id: 16237
2019-06-10 11:32:46 +00:00
Henrik Levkowetz 8726e74709 Merged in a refactoring of document review code from rjsparks@nostrum.com. This introduces ReviewAssignments, letting us do multiple assingments for a given RevieRequest, without conflating the assignments and their results with the request itself.
- Legacy-Id: 16177
2019-04-30 16:54:06 +00:00
Henrik Levkowetz bb4fe3fbbf Undid previous commit
- Legacy-Id: 16153
2019-04-22 19:22:42 +00:00
Henrik Levkowetz cfcefc2e32 Merged in [16144] from housley@vigilsec.com:
Remove some clutter from I-D upload page.  The information was mived to the Instructions tab, but a higligh to the Note Well and BCP 78 was added. Fixes #2057.
 - Legacy-Id: 16151
Note: SVN reference [16144] has been migrated to Git commit 37851b9742
2019-04-22 17:39:26 +00:00
Robert Sparks 6a2cf42e5c Don't allow users to edit the 'active' value for unknown-email-* addresses. Related to #2696. Commit ready for merge.
- Legacy-Id: 16106
2019-03-27 09:15:06 +00:00
Robert Sparks 0856990683 Checkpoint. Most tests do not fail. Oddness with an API resource, and with one template's coverage
- Legacy-Id: 16031
2019-03-14 18:39:40 +00:00
Henrik Levkowetz b57ad67041 Updated code and templates to use the new docman and groupman group features.
- Legacy-Id: 15922
2019-01-30 15:59:00 +00:00
Henrik Levkowetz 57a4c9f41f Added 9 new group features, and changed list-like char fields to json fields, to get better support for using the values as lists. Modified code to use the group features instead of explicit lists of group types in many places in the code.
- Legacy-Id: 15908
2019-01-22 18:11:46 +00:00
Henrik Levkowetz 753f34fba1 Merged in [15702] from johnl@taugh.com:
Allow email as well as username when logging in.
 - Legacy-Id: 15739
Note: SVN reference [15702] has been migrated to Git commit e4dd65d9f9
2018-11-08 06:42:32 +00:00
John R. Levine e4dd65d9f9 Allow email as well as username when logging in. Commit ready for merge.
- Legacy-Id: 15702
2018-11-03 09:35:55 +00:00
Henrik Levkowetz c305498903 Prevent issues for logins without Person records by not letting Person-less users through login.
- Legacy-Id: 15528
2018-10-07 19:35:54 +00:00
Henrik Levkowetz 3756923f40 Added username validation to the change username form, to avoid database key collision exceptions. Instead give a message to contact the secretariat to resolve the situation.
- Legacy-Id: 15490
2018-09-27 12:52:40 +00:00
Henrik Levkowetz 9067a2da7c Fixed an issue where a user record without matching person record will cause an exception.
- Legacy-Id: 15478
2018-09-20 18:04:23 +00:00
Henrik Levkowetz a5cc83ccb4 Fixed an issue with login().
- Legacy-Id: 15474
2018-09-19 15:22:44 +00:00
Henrik Levkowetz 4fba531e9e Merged in the latest GDPR changes. This refines the handling of the consent checkbox on the account page; refines the Consent Needed warning given on login if consent is needed; tweaks several models to set the on_deletion fields for FK to User and Person appropriately; adds a Person.needs_consent() method to capture the logic of which fields require consent; refines the Person.plain_name() method and the user.log.log() function; and adds 2 management commands to send out consent requests and delete non-consent information, respectively.
- Legacy-Id: 15464
2018-09-16 23:12:43 +00:00
Robert Sparks 02e85340f6 use factories for ietf.ietfauth.tests. Commit ready for merge
- Legacy-Id: 15399
2018-07-19 18:30:49 +00:00
Henrik Levkowetz 5251d0eb78 Changed the handling of the consent field of /account/profile/ to only be required set when information requiring consent is present.
- Legacy-Id: 15261
2018-06-14 19:28:06 +00:00
Henrik Levkowetz 50632482ea Improved the wording of the consent required login warnin. Refactored the login view to use Person.needs_consent() instead of inline logic.
- Legacy-Id: 15260
2018-06-14 19:27:03 +00:00
Henrik Levkowetz bf3074e493 Changed an attribute guard to work with a reverse relationship attribute (using hasattr()).
- Legacy-Id: 15251
2018-06-14 04:35:04 +00:00
Henrik Levkowetz 5f7fb2e0bd Added a guard against trying to access attributes of a None object.
- Legacy-Id: 15236
2018-06-09 13:20:14 +00:00
Henrik Levkowetz cf0061c3a0 Fixed logic of gathering which personal information needs consent confirmation in the code that requests consent on login.
- Legacy-Id: 15218
2018-06-06 15:13:34 +00:00
Henrik Levkowetz adb47d595a Fixed an issue with user.is_authenticated being used as a method rather than a property.
- Legacy-Id: 15212
2018-06-04 16:53:30 +00:00
Henrik Levkowetz ad34a88b31 Added a request to give consent for non-LI information on user login. Addresses issue #2505.
- Legacy-Id: 15211
2018-06-04 15:35:25 +00:00
Henrik Levkowetz eaff1f0825 Fixed a bug in a form clean method.
- Legacy-Id: 15210
2018-06-04 15:31:37 +00:00
Henrik Levkowetz 2fd1f81749 Added assignment of email origin in another place.
- Legacy-Id: 15175
2018-05-26 08:36:50 +00:00
Henrik Levkowetz f6537fda59 Added a dagger at the end of some fields in the account data forms to signify consent-based fields, and made the consent field required.
- Legacy-Id: 15174
2018-05-26 08:36:06 +00:00
Henrik Levkowetz 2522082979 Changed the email origin field during test to hold user.username in order to exercise more of the code. Changed the EmailFactory to also use user.username as origin.
- Legacy-Id: 15172
2018-05-26 08:32:20 +00:00
Henrik Levkowetz 70ed611472 Changed the field type for the Person.consent field.
- Legacy-Id: 15146
2018-05-17 16:45:21 +00:00
Henrik Levkowetz 246c348f1e Disallow profile changes without consent given. Together with previous commits this fixes issues #2505 and #2507.
- Legacy-Id: 15143
2018-05-08 16:26:01 +00:00
Henrik Levkowetz 5f37a71889 Added origin information to all places where we create email address entries.
- Legacy-Id: 15127
2018-05-05 12:40:30 +00:00
Henrik Levkowetz 53c4ac36db Removed the Person.address field, which is not being used. This was a legacy from the 2001 perl-based datatracker tables. Fixes issue #2504.
- Legacy-Id: 15095
2018-04-27 14:00:33 +00:00
Henrik Levkowetz 496da66fc1 Added a new role 'Recording Manager'.
- Legacy-Id: 14964
2018-03-29 10:58:04 +00:00
Henrik Levkowetz ad2139dc8f Fixed a settings typo.
- Legacy-Id: 14725
2018-03-03 18:30:19 +00:00
Robert Sparks 13e8f8982c Add the ability to add a comment to a group's history. Fixes #1483. Commit ready for merge.
- Legacy-Id: 14468
2017-12-28 20:48:58 +00:00
Henrik Levkowetz a08c8dc76f Added an API endpoint to support automation of IESG ballot position posting, at /api/iesg/position. Added tests for the API endpoint, and updated the apikey validation decorator tests. Tweaked the decorator to handle a weakness found during testing.
- Legacy-Id: 14429
2017-12-17 21:55:27 +00:00