altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

chore: Add draft name to review-completed email (#8676)

Browse source 
* chore: Add draft name to review-completed email

Fixes: #7866

* fix: typo

* fix: show title and add test

---------

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
This commit is contained in:
Rich Salz 2025-03-19 05:06:47 -04:00 committed by GitHub
parent c3a296fdb5
commit fde8136df5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
ietf/doc/tests_review.py
View file

@ -902,7 +902,10 @@ class ReviewTests(TestCase):
self.assertEqual(len(outbox), 1)
self.assertIn(assignment.review_request.team.list_email, outbox[0]["To"])
self.assertIn("This is a review", get_payload_text(outbox[0]))
payload = get_payload_text(outbox[0])
self.assertIn("This is a review", payload)
self.assertIn(f"Document: {assignment.review_request.doc.name}", payload)
self.assertIn(f"Title: {assignment.review_request.doc.title}", payload)
self.assertIn(settings.MAILING_LIST_ARCHIVE_URL, assignment.review.external_url)

4
ietf/templates/review/completed_review.txt
View file

@ -1,7 +1,9 @@
{% load ietf_filters %}{% autoescape off %}{% filter maybewordwrap:80 %}{% if assignment.state_id == "part-completed" %}
Review is partially done. Another assignment may be needed to complete it.
{% endif %}Reviewer: {{ assignment.reviewer.person }}
{% endif %}Document: {{ assignment.review_request.doc.name }}
Title: {{ assignment.review_request.doc.title }}
Reviewer: {{ assignment.reviewer.person }}
Review result: {{ assignment.result.name }}
{{ content }}