Rewrite merge-person-records utility script to handle all related objects in a generic manner, remove old User records and handle email primary attribute. Fixes #1627. Commit ready for merge

- Legacy-Id: 10721

ietf/bin/merge-person-records

@@ -2,7 +2,17 @@
 # -*- coding: utf-8 -*-
 # -*- Python -*-
 #
+'''
+This script merges two Person records into one.  It determines which record is the target
+based on most current User record (last_login) unless -f (force) option is used to
+force SOURCE TARGET as specified on the command line.  The order of operations is
+important.  We must complete all source.save() operations before moving the aliases to
+the target, this is to avoid extra "Possible duplicate Person" emails going out, if the
+Person is saved without an alias the Person.save() creates another one, which then
+conflicts with the moved one.
+'''
 
+# Set PYTHONPATH and load environment variables for standalone script -----------------
 import os, sys
 basedir = os.path.abspath(os.path.join(os.path.dirname(__file__), "../.."))
 sys.path = [ basedir ] + sys.path
@@ -10,82 +20,162 @@ os.environ.setdefault("DJANGO_SETTINGS_MODULE", "ietf.settings")
 
 import django
 django.setup()
+# -------------------------------------------------------------------------------------
 
 import argparse
 import pprint
+import syslog
 from django.contrib import admin
 from django.contrib.auth.models import User
 from ietf.person.models import Person
+from ietf.utils.log import log
+from ietf.utils.mail import send_mail
 
-parser = argparse.ArgumentParser()
-parser.add_argument("source_id",type=int)
-parser.add_argument("target_id",type=int)
-args = parser.parse_args()
+def dedupe_aliaises(person):
+    '''
+    Check person for duplicate aliases and purge
+    '''
+    seen = []
+    for alias in person.alias_set.all():
+        if alias.name in seen:
+            alias.delete()
+        else:
+            seen.append(alias.name)
 
-source = Person.objects.get(pk=args.source_id)
-target = Person.objects.get(pk=args.target_id)
+def determine_merge_order(source,target):
+    '''
+    Determine merge order.  Select Person that has related User.  If both have Users
+    select one with most recent login
+    '''
+    if source.user and not target.user:
+        source,target = target,source   # swap merge order
+    if source.user and target.user:
+        source,target = sorted([source,target],key=lambda a: a.user.last_login)
+    return source,target
 
-print "Merging person {}({}) to {}({})".format(source.ascii,source.pk,target.ascii,target.pk)
-response = raw_input('Ok to continue y/n? ')
-if response.lower() != 'y':
-    sys.exit()
-
-# merge emails
-for email in source.email_set.all():
-    print "Merging email: {}".format(email.address)
-    email.person = target
-    email.save()
-
-# merge aliases
-target_aliases = [ a.name for a in target.alias_set.all() ]
-for alias in source.alias_set.all():
-    if alias.name in target_aliases:
-        alias.delete()
+def get_extra_primary(source,target):
+    '''
+    Inspect email addresses and return list of those that should no longer be primary
+    '''
+    if source.email_set.filter(primary=True) and target.email_set.filter(primary=True):
+        return source.email_set.filter(primary=True)
     else:
-        print "Merging alias: {}".format(alias.name)
-        alias.person = target
-        alias.save()
+        return []
 
-# merge DocEvents
-for docevent in source.docevent_set.all():
-    docevent.by = target
-    docevent.save()
-    
-# merge SubmissionEvents
-for subevent in source.submissionevent_set.all():
-    subevent.by = target
-    subevent.save()
+def handle_users(source,target,check_only=False):
+    '''
+    Deletes extra Users.  Retains target user.  If check_only == True, just return a string
+    describing action, otherwise perform user changes and return string.
+    '''
+    if not (source.user or target.user):
+        return "DATATRACKER LOGIN ACTION: none (no login defined)"
+    if not source.user and target.user:
+        return "DATATRACKER LOGIN ACTION: retaining login {}".format(target.user)
+    if source.user and not target.user:
+        message = "DATATRACKER LOGIN ACTION: retaining login {}".format(source.user)
+        if not check_only:
+            target.user = source.user
+            target.save()
+        return message
+    if source.user and target.user:
+        message = "DATATRACKER LOGIN ACTION: retaining login: {}, removing login: {}".format(target.user,source.user)
+        if not check_only:
+            syslog.syslog('merge-person-records: deleting user {}'.format(source.user.username))
+            user = source.user
+            source.user = None
+            source.save()
+            user.delete()
+        return message
 
-# merge Messages
-for message in source.message_set.all():
-    message.by = target
-    message.save()
+def send_notification(person,changes):
+    '''
+    Send an email to the merge target (Person) notifying them of the changes
+    '''
+    send_mail(request = None,
+              to       = person.email_address(),
+              frm      = "IETF Secretariat <ietf-secretariat@ietf.org>",
+              subject  = "IETF Datatracker records merged",
+              template = "utils/merge_person_records.txt",
+              context  = dict(person=person,changes='\n'.join(changes)),
+              extra    = {}
+             )
 
-# merge Constraints
-for constraint in source.constraint_set.all():
-    constraint.person = target
-    constraint.save()
+def main():
+    parser = argparse.ArgumentParser()
+    parser.add_argument("source_id",type=int)
+    parser.add_argument("target_id",type=int)
+    parser.add_argument('-f','--force', help='force merge order',action='store_true')
+    parser.add_argument('-v','--verbose', help='verbose output',action='store_true')
+    args = parser.parse_args()
+    changes = []
+    syslog.openlog(os.path.basename(__file__), syslog.LOG_PID, syslog.LOG_USER)
 
-# merge Roles
-for role in source.role_set.all():
-    role.person = target
-    role.save()
+    source = Person.objects.get(pk=args.source_id)
+    target = Person.objects.get(pk=args.target_id)
 
-# check for any remaining relationships and delete if none
-objs = [source]
-opts = Person._meta
-user = User.objects.filter(is_superuser=True).first()
-admin_site = admin.site
-using = 'default'
+    # set merge order
+    if not args.force:
+        source,target = determine_merge_order(source,target)
 
-deletable_objects, perms_needed, protected = admin.utils.get_deleted_objects(
-    objs, opts, user, admin_site, using)
-    
-if len(deletable_objects) > 1:
-    print "Not Deleting Person: {}({})".format(source.ascii,source.pk)
-    print "Related objects remain:"
-    pprint.pprint(deletable_objects[1])
+    # confirm
+    print "Merging person {}({}) to {}({})".format(source.ascii,source.pk,target.ascii,target.pk)
+    print handle_users(source,target,check_only=True)
+    response = raw_input('Ok to continue y/n? ')
+    if response.lower() != 'y':
+        sys.exit()
 
-else:
-    print "Deleting Person: {}({})".format(source.ascii,source.pk)
+    # write log
+    syslog.syslog("Merging person records {} => {}".format(source.pk,target.pk))
+
+    # handle primary emails
+    for email in get_extra_primary(source,target):
+        email.primary = False
+        email.save()
+        changes.append('EMAIL ACTION: {} no longer marked as primary'.format(email.address))
+
+    # handle users
+    changes.append(handle_users(source,target))
+
+    # find all related objects and migrate
+    for related_object in source._meta.get_all_related_objects():
+        accessor = related_object.get_accessor_name()
+        field_name = related_object.field.name
+        queryset = getattr(source, accessor).all()
+        if args.verbose:
+            print "Merging {}:{}".format(accessor,queryset.count())
+        kwargs = { field_name:target }
+        queryset.update(**kwargs)
+
+    # check aliases
+    dedupe_aliaises(target)
+
+    # copy other attributes
+    for field in ('ascii','ascii_short','address','affiliation'):
+        if getattr(source,field) and not getattr(target,field):
+            setattr(target,field,getattr(source,field))
+            target.save()
+
+    # check for any remaining relationships and exit if more found
+    objs = [source]
+    opts = Person._meta
+    user = User.objects.filter(is_superuser=True).first()
+    admin_site = admin.site
+    using = 'default'
+    deletable_objects, perms_needed, protected = admin.utils.get_deleted_objects(
+        objs, opts, user, admin_site, using)
+
+    if len(deletable_objects) > 1:
+        print "Not Deleting Person: {}({})".format(source.ascii,source.pk)
+        print "Related objects remain:"
+        pprint.pprint(deletable_objects[1])
+        sys.exit(1)
+
+    if args.verbose:
+        print "Deleting Person: {}({})".format(source.ascii,source.pk)
     source.delete()
+
+    # send email notification
+    send_notification(target,changes)
+
+if __name__ == "__main__":
+    main()

ietf/secr/proceedings/proc_utils.py

@@ -10,7 +10,7 @@ import os
 import shutil
 
 from django.conf import settings
-from django.shortcuts import render_to_response
+from django.shortcuts import render_to_response, render
 
 from ietf.doc.models import Document, RelatedDocument, DocEvent, NewRevisionDocEvent, State
 from ietf.group.models import Group, Role
@@ -213,7 +213,7 @@ def write_html(path,content):
 # End Helper Functions
 # -------------------------------------------------
 
-def create_interim_directory():
+def create_interim_directory(request):
     '''
     Create static Interim Meeting directory pages that will live in a different URL space than
     the secretariat Django project
@@ -222,7 +222,7 @@ def create_interim_directory():
     # produce date sorted output
     page = 'proceedings.html'
     meetings = InterimMeeting.objects.order_by('-date')
-    response = render_to_response('proceedings/interim_directory.html',{'meetings': meetings})
+    response = render(request, 'proceedings/interim_directory.html',{'meetings': meetings})
     path = os.path.join(settings.SECR_INTERIM_LISTING_DIR, page)
     f = open(path,'w')
     f.write(response.content)
@@ -232,7 +232,7 @@ def create_interim_directory():
     page = 'proceedings-bygroup.html'
     qs = InterimMeeting.objects.all()
     meetings = sorted(qs, key=lambda a: a.group().acronym)
-    response = render_to_response('proceedings/interim_directory.html',{'meetings': meetings})
+    response = render(request, 'proceedings/interim_directory.html',{'meetings': meetings})
     path = os.path.join(settings.SECR_INTERIM_LISTING_DIR, page)
     f = open(path,'w')
     f.write(response.content)

ietf/secr/proceedings/views.py

@@ -485,7 +485,7 @@ def interim(request, acronym):
                                    type_id='session',
                                   )
 
-            create_interim_directory()
+            create_interim_directory(request)
             make_directories(meeting)
 
             messages.success(request, 'Meeting created')

ietf/templates/utils/merge_person_records.txt

@@ -0,0 +1,25 @@
+{% filter wordwrap:73 %}
+Dear {{ person.plain_name }},
+
+We have noticed that there are two records in the IETF Datatracker for a person named "{{ person.plain_name }}".  These records have been merged.
+
+The merged record is:
+
+Name: {{ person.plain_name }}
+Aliases: {{ person.alias_set.all|join:", " }}
+Address: {{ person.address }}
+Affiliation: {{ person.affiliation }}
+User (login): {{ person.user.username }}
+
+Emails:
+{% for email in person.email_set.all %}{% if email.active %}{{ email.address }}{% if email.primary %} (primary){% endif %}
+{% endif %}{% endfor %}
+
+{% if changes %}Changes of special note:
+{{ changes }}{% endif %}
+
+You can make changes to your profile here: https://datatracker.ietf.org/accounts/profile/
+
+Thank You,
+The IETF Secretariat
+{% endfilter %}