altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

refactor: don't template inside <script> (#8480)

Browse source
This commit is contained in:
Jennifer Richards 2025-01-29 15:11:12 -04:00 committed by GitHub
parent 826f4d8747
commit d3bf0a37dc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ietf/static/js/complete-review.js
View file

@ -24,6 +24,8 @@ $(document)
.before(mailArchiveSearchTemplate); .before(mailArchiveSearchTemplate);
var mailArchiveSearch = form.find(".mail-archive-search"); var mailArchiveSearch = form.find(".mail-archive-search");
const isReviewer = mailArchiveSearch.data('isReviewer');
const searchMailArchiveUrl = mailArchiveSearch.data('searchMailArchiveUrl');
var retrievingData = null; var retrievingData = null;
@ -190,4 +192,4 @@ $(document)
form.find("[name=review_submission][value=link]") form.find("[name=review_submission][value=link]")
.trigger("click"); .trigger("click");
} }
}); });

16
ietf/templates/doc/review/complete_review.html
View file

@ -94,7 +94,13 @@
{% endif %} {% endif %}
<div class="template d-none"> <div class="template d-none">
{% if mail_archive_query_urls %} {% if mail_archive_query_urls %}
<div class="mail-archive-search"> <div class="mail-archive-search"
{% if assignment %}
data-search-mail-archive-url="{% url "ietf.doc.views_review.search_mail_archive" name=doc.name assignment_id=assignment.pk %}"
{% else %}
data-search-mail-archive-url="{% url "ietf.doc.views_review.search_mail_archive" name=doc.name acronym=team.acronym %}"
{% endif %}
data-is-reviewer="{{ is_reviewer|yesno:"true,false" }}">
<div class="offset-md-2 col-md-10"> <div class="offset-md-2 col-md-10">
<label for="mail-archive-subjects" class="form-label">Search {{team.list_email}} mail archive subjects for:</label> <label for="mail-archive-subjects" class="form-label">Search {{team.list_email}} mail archive subjects for:</label>
<div class="input-group mb-3"> <div class="input-group mb-3">
@ -144,13 +150,5 @@
{% endblock %} {% endblock %}
{% block js %} {% block js %}
<script src="{% static 'ietf/js/datepicker.js' %}"></script> <script src="{% static 'ietf/js/datepicker.js' %}"></script>
<script>
{% if assignment %}
var searchMailArchiveUrl = "{% url "ietf.doc.views_review.search_mail_archive" name=doc.name assignment_id=assignment.pk %}";
{% else %}
var searchMailArchiveUrl = "{% url "ietf.doc.views_review.search_mail_archive" name=doc.name acronym=team.acronym %}";
{% endif %}
var isReviewer = {{ is_reviewer|yesno:'true,false' }};
</script>
<script src="{% static 'ietf/js/complete-review.js' %}"></script> <script src="{% static 'ietf/js/complete-review.js' %}"></script>
{% endblock %} {% endblock %}