From cf0061c3a02680b508ecaa78b280fe8b3f0f8e9a Mon Sep 17 00:00:00 2001 From: Henrik Levkowetz Date: Wed, 6 Jun 2018 15:13:34 +0000 Subject: [PATCH] Fixed logic of gathering which personal information needs consent confirmation in the code that requests consent on login. - Legacy-Id: 15218 --- ietf/ietfauth/views.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/ietf/ietfauth/views.py b/ietf/ietfauth/views.py index ca4fe4af0..07b4debbc 100644 --- a/ietf/ietfauth/views.py +++ b/ietf/ietfauth/views.py @@ -590,16 +590,15 @@ def login(request, extra_context=None): person = user.person if person.name != person.name_from_draft: require_consent.append("full name") - elif person.ascii != person.name_from_draft: + if person.ascii != person.name_from_draft: require_consent.append("ascii name") - elif person.biography: + if person.biography: require_consent.append("biography") - elif user.communitylist_set.exists(): + if user.communitylist_set.exists(): require_consent.append("draft notification subscription(s)") - else: - for email in person.email_set.all(): - if not email.origin.split(':')[0] in ['author', 'role', 'reviewer', 'liaison', 'shepherd', ]: - require_consent.append("email address(es)") + for email in person.email_set.all(): + if not email.origin.split(':')[0] in ['author', 'role', 'reviewer', 'liaison', 'shepherd', ]: + require_consent.append("email address(es)") if user: try: identify_hasher(user.password)