From ceff54480c40ffbf9b601d467b1f2a8e07100f7d Mon Sep 17 00:00:00 2001 From: Robert Sparks Date: Wed, 17 May 2017 13:55:39 +0000 Subject: [PATCH] Update the feedback count badge when new feedback is provided. Fixes #2260. Commit ready for merge. - Legacy-Id: 13388 --- ietf/nomcom/tests.py | 2 ++ ietf/nomcom/views.py | 3 +++ 2 files changed, 5 insertions(+) diff --git a/ietf/nomcom/tests.py b/ietf/nomcom/tests.py index fb7696e95..acb75bc09 100644 --- a/ietf/nomcom/tests.py +++ b/ietf/nomcom/tests.py @@ -857,6 +857,8 @@ class NomcomViewsTest(TestCase): self.assertEqual(response.status_code, 200) self.assertContains(response, "alert-success") self.assertNotContains(response, "feedbackform") + q = PyQuery(response.content) + self.assertEqual( int(q("#nominees .badge").text()), Feedback.objects.filter(positions__in=[position],nominees__in=[nominee],type_id='comment').count() ) ## check objects feedback = Feedback.objects.filter(positions__in=[position], diff --git a/ietf/nomcom/views.py b/ietf/nomcom/views.py index e7a156ce5..85b3d8405 100644 --- a/ietf/nomcom/views.py +++ b/ietf/nomcom/views.py @@ -452,6 +452,9 @@ def feedback(request, year, public): form.save() messages.success(request, 'Your feedback has been registered.') form = None + counts.setdefault(position.pk,dict()) + counts[position.pk].setdefault(nominee.pk,0) + counts[position.pk][nominee.pk] += 1 else: if nominee and position: form = FeedbackForm(nomcom=nomcom, user=request.user, public=public,