altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 4 Packages Projects Releases Wiki Activity

Construct Faker objects used for person name generation only once. Results in a roughly 20% speedup of the test-suite. Commit ready for merge.

Browse source 
- Legacy-Id: 18020
This commit is contained in:
Robert Sparks 2020-06-19 19:54:50 +00:00
parent 64de3fcd8c
commit c60cc1b1a0
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ietf/person/factories.py
View file

@ -9,6 +9,7 @@ import os
import random import random
import shutil import shutil
from functools import lru_cache
from unidecode import unidecode from unidecode import unidecode
from django.conf import settings from django.conf import settings
@ -24,14 +25,18 @@ from ietf.person.name import normalize_name, unidecode_name
fake = faker.Factory.create() fake = faker.Factory.create()
def random_faker(): @lru_cache(maxsize=1)
def acceptable_fakers():
# The transliteration of some arabic and devanagari names introduces # The transliteration of some arabic and devanagari names introduces
# non-alphabetic characgters that don't work with the draft author # non-alphabetic characgters that don't work with the draft author
# extraction code, and also don't seem to match the way people with arabic # extraction code, and also don't seem to match the way people with arabic
# names romanize arabic names. Exlude those locales from name generation # names romanize arabic names. Exlude those locales from name generation
# in order to avoid test failures. # in order to avoid test failures.
locales = set( [ l for l in faker.config.AVAILABLE_LOCALES if not (l.startswith('ar_') or l.startswith('sg_')) ] ) locales = set( [ l for l in faker.config.AVAILABLE_LOCALES if not (l.startswith('ar_') or l.startswith('sg_')) ] )
return faker.Faker(random.sample(locales, 1)[0]) return [faker.Faker(locale) for locale in locales]
def random_faker():
return random.sample(acceptable_fakers(), 1)[0]
class UserFactory(factory.DjangoModelFactory): class UserFactory(factory.DjangoModelFactory):
class Meta: class Meta: