From c474b42f2da7fa929e764639affeed5573a2a303 Mon Sep 17 00:00:00 2001 From: Henrik Levkowetz Date: Fri, 18 Oct 2019 14:46:59 +0000 Subject: [PATCH] Send review reminders output to log, rather than stdout (since this is run from cron, stdout and stderr should be quiet if nothing unexpected happens) - Legacy-Id: 16878 --- ietf/bin/send-review-reminders | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/ietf/bin/send-review-reminders b/ietf/bin/send-review-reminders index 3fb206e47..678e284c9 100755 --- a/ietf/bin/send-review-reminders +++ b/ietf/bin/send-review-reminders @@ -26,6 +26,7 @@ from ietf.review.utils import ( review_assignments_needing_secretary_reminder, email_secretary_reminder, send_unavaibility_period_ending_reminder, send_reminder_all_open_reviews, send_review_reminder_overdue_assignment, send_reminder_unconfirmed_assignments) +from ietf.utils.log import log today = datetime.date.today() @@ -39,13 +40,17 @@ for assignment, secretary_role in review_assignments_needing_secretary_reminder( print("Emailed reminder to {} for review of {} in {} (req. id {})".format(secretary_role.email.address, review_req.doc_id, review_req.team.acronym, review_req.pk)) period_end_reminders_sent = send_unavaibility_period_ending_reminder(today) -print('\n'.join(period_end_reminders_sent)) +for msg in period_end_reminders_sent: + log(msg) overdue_reviews_reminders_sent = send_review_reminder_overdue_assignment(today) -print('\n'.join(overdue_reviews_reminders_sent)) +for msg in overdue_reviews_reminders_sent: + log(msg) open_reviews_reminders_sent = send_reminder_all_open_reviews(today) -print('\n'.join(open_reviews_reminders_sent)) +for msg in open_reviews_reminders_sent: + log(msg) unconfirmed_assignment_reminders_sent = send_reminder_unconfirmed_assignments(today) -print('\n'.join(unconfirmed_assignment_reminders_sent)) +for msg in unconfirmed_assignment_reminders_sent: + log(msag)