fix: 404 requests for bibtex for none draft or rfc documents (#6834)

* fix: 404 requests for bibtex for none draft or rfc documents

* test: test rejecting the types with factories already being imported
This commit is contained in:
Robert Sparks 2023-12-21 16:27:48 -06:00 committed by GitHub
parent 50aa3995ee
commit bc74977fcc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions

View file

@ -40,7 +40,7 @@ from ietf.doc.factories import ( DocumentFactory, DocEventFactory, CharterFactor
ConflictReviewFactory, WgDraftFactory, IndividualDraftFactory, WgRfcFactory,
IndividualRfcFactory, StateDocEventFactory, BallotPositionDocEventFactory,
BallotDocEventFactory, DocumentAuthorFactory, NewRevisionDocEventFactory,
StatusChangeFactory, DocExtResourceFactory, RgDraftFactory)
StatusChangeFactory, DocExtResourceFactory, RgDraftFactory, BcpFactory)
from ietf.doc.forms import NotifyForm
from ietf.doc.fields import SearchableDocumentsField
from ietf.doc.utils import create_ballot_if_not_open, uppercase_std_abbreviated_name
@ -1948,6 +1948,12 @@ class DocTestCase(TestCase):
@override_settings(RFC_EDITOR_INFO_BASE_URL='https://www.rfc-editor.ietf.org/info/')
def test_document_bibtex(self):
for factory in [CharterFactory, BcpFactory, StatusChangeFactory, ConflictReviewFactory]: # Should be extended to all other doc types
doc = factory()
url = urlreverse("ietf.doc.views_doc.document_bibtex", kwargs=dict(name=doc.name))
r = self.client.get(url)
self.assertEqual(r.status_code, 404)
rfc = WgRfcFactory.create(
time=datetime.datetime(2010, 10, 10, tzinfo=ZoneInfo(settings.TIME_ZONE))
)

View file

@ -1262,6 +1262,9 @@ def document_bibtex(request, name, rev=None):
doc = get_object_or_404(Document, name=name)
if doc.type_id not in ["rfc", "draft"]:
raise Http404()
doi = None
draft_became_rfc = None
replaced_by = None