altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

fix: Various accumulated fixes (#4106)

Browse source 
This makes (more) sure the table sort chevron doesn't wrap, by removing trailing
whitespace from table headers.

It also fixes various whitespace nits related to buttonlists.
This commit is contained in:
Lars Eggert 2022-06-21 21:00:41 +03:00 committed by GitHub
parent 9b629f6bc4
commit bbeb9aece7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ietf/static/css/ietf.scss
View file

@ -190,7 +190,7 @@ table tbody.meta {
// Add some padding when there are multiple buttons in a line than can wrap
.buttonlist .btn {
margin-top: map.get($spacers, 2);
margin-bottom: map.get($spacers, 1);
}
// Styles for d3.js graphical SVG timelines

8
ietf/static/js/list.js
View file

@ -51,6 +51,14 @@ $(document)
var header_row = $(table)
.find("thead > tr:first");
// we need to strip the trailing whitespace, so the sort chevron doesn't wrap
$(header_row)
.find("th, td")
.each(function () {
const html = $(this).html().trim();
$(this).html(html);
});
// get field classes from first thead row
var fields = $(header_row)
.find("th, td")

4
ietf/templates/doc/document_draft.html
View file

@ -244,6 +244,7 @@
</div>
{% endif %}
{% if file_urls %}
<div class="buttonlist">
{% for label, url in file_urls %}
<a class="btn btn-primary btn-sm" href="{{ url }}">
<i class="bi bi-file-{% if label == 'pdf' %}pdf{% elif label == 'xml' or label == 'htmlized' or label == 'html' %}code{% elif label == 'bibtex' %}ruled{% elif label == 'plain text' %}text{% endif %}">
@ -251,6 +252,7 @@
{{ label }}
</a>
{% endfor %}
</div>
{% else %}
(not online)
{% endif %}
@ -310,7 +312,7 @@
will not review this version
{% endif %}
{% if can_request_review or can_submit_unsolicited_review_for_teams %}
<div class="mt-3">
<div {% if review_assignments or no_review_from_teams %} class="mt-3"{% endif %}>
{% if can_request_review %}
<a class="btn btn-primary btn-sm"
href="{% url "ietf.doc.views_review.request_review" doc.name %}">

2
ietf/templates/doc/search/search_results.html
View file

@ -57,4 +57,4 @@
{% endfor %}
</tbody>
{% endfor %}
{% if end_table %}</table>{% endif %}
{% if end_table %}</table>{% endif %}