Merged in [15677] from rjsparks@nostrum.com:

Tune the recipients when a teams settings or a reviewer indicate ADs should be notified about a review.
 - Legacy-Id: 15682
Note: SVN reference [15677] has been migrated to Git commit 24b83240e0

ietf/mailtrigger/migrations/0003_add_review_notify_ad.py

@@ -13,12 +13,16 @@ def forward(apps, schema_editor):
         desc = "The reviewed document's responsible area director",
         template = '{% if review_req.doc.ad %}{{review_req.doc.ad.email_address}}{% endif %}'
     )
+    Recipient.objects.create(
+        slug = 'review_team_ads',
+        desc = "The ADs of the team reviewing the document"
+    )
 
     review_notify_ad = MailTrigger.objects.create(
         slug = 'review_notify_ad',
         desc = 'Recipients when a team notifies area directors when a review with one of a certain set of results (typically results indicating problem) is submitted',
     )
-    review_notify_ad.to.set(Recipient.objects.filter(slug='review_doc_ad'))
+    review_notify_ad.to.set(Recipient.objects.filter(slug__in=['review_doc_ad','review_team_ads']))
 
 
 def reverse(apps, schema_editor):
@@ -27,6 +31,7 @@ def reverse(apps, schema_editor):
 
     MailTrigger.objects.filter(slug='review_notify_ad').delete()
     Recipient.objects.filter(slug='review_doc_ad').delete()
+    Recipient.objects.filter(slug='review_team_ads').delete()
 
 class Migration(migrations.Migration):
 

ietf/mailtrigger/models.py

@@ -316,3 +316,12 @@ class Recipient(models.Model):
             session = kwargs['session']
             addrs.append(session.requested_by.role_email('chair').address)
         return addrs
+
+    def gather_review_team_ads(self, **kwargs):
+        addrs=[]
+        if 'review_req' in kwargs:
+            review_req = kwargs['review_req']
+            if review_req.team.parent:
+                for role in review_req.team.parent.role_set.filter(name='ad'):
+                    addrs.append(role.email.address)
+        return addrs

ietf/name/fixtures/names.json

@@ -3574,7 +3574,8 @@
       "cc": [],
       "desc": "Recipients when a team notifies area directors when a review with one of a certain set of results (typically results indicating problem) is submitted",
       "to": [
-        "review_doc_ad"
+        "review_doc_ad",
+        "review_team_ads"
       ]
     },
     "model": "mailtrigger.mailtrigger",
@@ -4216,6 +4217,14 @@
     "model": "mailtrigger.recipient",
     "pk": "review_doc_group_mail_list"
   },
+  {
+    "fields": {
+      "desc": "The ADs of the team reviewing the document",
+      "template": null
+    },
+    "model": "mailtrigger.recipient",
+    "pk": "review_team_ads"
+  },
   {
     "fields": {
       "desc": "The review team's email list",
@@ -10494,7 +10503,7 @@
     "fields": {
       "command": "xym",
       "switch": "--version",
-      "time": "2018-11-01T00:08:56.002",
+      "time": "2018-11-02T00:08:27.707",
       "used": true,
       "version": "xym 0.4"
     },
@@ -10505,7 +10514,7 @@
     "fields": {
       "command": "pyang",
       "switch": "--version",
-      "time": "2018-11-01T00:08:57.320",
+      "time": "2018-11-02T00:08:28.485",
       "used": true,
       "version": "pyang 1.7.5"
     },
@@ -10516,7 +10525,7 @@
     "fields": {
       "command": "yanglint",
       "switch": "--version",
-      "time": "2018-11-01T00:08:57.507",
+      "time": "2018-11-02T00:08:28.661",
       "used": true,
       "version": "yanglint 0.14.80"
     },
@@ -10527,7 +10536,7 @@
     "fields": {
       "command": "xml2rfc",
       "switch": "--version",
-      "time": "2018-11-01T00:08:59.405",
+      "time": "2018-11-02T00:08:29.566",
       "used": true,
       "version": "xml2rfc 2.12.3"
     },