altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions6 Packages Projects Releases Wiki Activity

chore: ensure proper return type ()

Browse source 
* chore: ensure proper return type

* test: comment out (intentionally) failing assertion

---------

Co-authored-by: Jennifer Richards <jennifer@staff.ietf.org>
This commit is contained in:
Robert Sparks 2025-02-20 13:13:44 -06:00 committed by GitHub
parent 2f8b9c3cfa
commit aeba63bb41
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions

3
ietf/doc/storage_utils.py
View file

@ -29,8 +29,7 @@ def exists_in_storage(kind: str, name: str) -> bool:
return store.exists_in_storage(kind, name) return store.exists_in_storage(kind, name)
except Exception as err: except Exception as err:
log(f"Blobstore Error: Failed to test existence of {kind}:{name}: {repr(err)}") log(f"Blobstore Error: Failed to test existence of {kind}:{name}: {repr(err)}")
else: return False
return False
def remove_from_storage(kind: str, name: str, warn_if_missing: bool = True) -> None: def remove_from_storage(kind: str, name: str, warn_if_missing: bool = True) -> None:

5
ietf/doc/tests_status_change.py
View file

@ -564,8 +564,9 @@ class StatusChangeSubmitTests(TestCase):
ftp_filepath = Path(settings.FTP_DIR) / "status-changes" / basename ftp_filepath = Path(settings.FTP_DIR) / "status-changes" / basename
self.assertFalse(filepath.exists()) self.assertFalse(filepath.exists())
self.assertFalse(ftp_filepath.exists()) self.assertFalse(ftp_filepath.exists())
with self.assertRaises(FileNotFoundError): # TODO-BLOBSTORE: next assert is disabled because we currently suppress all exceptions
retrieve_str("statchg",basename) # with self.assertRaises(FileNotFoundError):
# retrieve_str("statchg",basename)
r = self.client.post(url,dict(content="Some initial review text\n",submit_response="1")) r = self.client.post(url,dict(content="Some initial review text\n",submit_response="1"))
self.assertEqual(r.status_code,302) self.assertEqual(r.status_code,302)
doc = Document.objects.get(name='status-change-imaginary-mid-review') doc = Document.objects.get(name='status-change-imaginary-mid-review')