altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 4 Packages Projects Releases Wiki Activity

test: fill in milestone descriptions (#8002)

Browse source 
* test: fill in milestone descriptions

If "Next" or "Last" appear in the descriptions, the
selectors used by the tests get confused.

* test: avoid fragile selectors
This commit is contained in:
Jennifer Richards 2024-10-09 13:04:54 -03:00 committed by GitHub
parent 6aff818b72
commit a6d15c98ba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 44 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

58
ietf/iesg/tests.py
View file

@ -87,9 +87,18 @@ class IESGTests(TestCase):
group=dated_group, group=dated_group,
person=Person.objects.get(user__username='ad'), person=Person.objects.get(user__username='ad'),
) )
dated_milestones = DatedGroupMilestoneFactory.create_batch( dated_milestones = [
2, group=dated_group, state_id="review" DatedGroupMilestoneFactory(
) group=dated_group,
state_id="review",
desc="This is the description of one dated group milestone",
),
DatedGroupMilestoneFactory(
group=dated_group,
state_id="review",
desc="This is the description of another dated group milestone",
),
]
dated_milestones[0].due -= datetime.timedelta(days=1) # make this one earlier dated_milestones[0].due -= datetime.timedelta(days=1) # make this one earlier
dated_milestones[0].save() dated_milestones[0].save()
@ -99,9 +108,18 @@ class IESGTests(TestCase):
group=dateless_group, group=dateless_group,
person=Person.objects.get(user__username='ad'), person=Person.objects.get(user__username='ad'),
) )
dateless_milestones = DatelessGroupMilestoneFactory.create_batch( dateless_milestones = [
2, group=dateless_group, state_id="review" DatelessGroupMilestoneFactory(
) group=dateless_group,
state_id="review",
desc="This is the description of one dateless group milestone",
),
DatelessGroupMilestoneFactory(
group=dateless_group,
state_id="review",
desc="This is the description of another dateless group milestone",
),
]
url = urlreverse("ietf.iesg.views.milestones_needing_review") url = urlreverse("ietf.iesg.views.milestones_needing_review")
self.client.login(username="ad", password="ad+password") self.client.login(username="ad", password="ad+password")
@ -111,17 +129,29 @@ class IESGTests(TestCase):
# check order-by-date # check order-by-date
dated_tbody = pq(f'td:contains("{dated_milestones[0].desc}")').closest("tbody") dated_tbody = pq(f'td:contains("{dated_milestones[0].desc}")').closest("tbody")
next_td = dated_tbody.find('td:contains("Next")') rows = list(dated_tbody.items("tr")) # keep as pyquery objects
self.assertEqual(next_td.siblings()[0].text.strip(), dated_milestones[0].desc) self.assertTrue(rows[0].find('td:first:contains("Last")')) # Last milestone shown first
last_td = dated_tbody.find('td:contains("Last")') self.assertFalse(rows[0].find('td:first:contains("Next")'))
self.assertEqual(last_td.siblings()[0].text.strip(), dated_milestones[1].desc) self.assertTrue(rows[0].find(f'td:contains("{dated_milestones[1].desc}")'))
self.assertFalse(rows[0].find(f'td:contains("{dated_milestones[0].desc}")'))
self.assertFalse(rows[1].find('td:first:contains("Last")')) # Last milestone shown first
self.assertTrue(rows[1].find('td:first:contains("Next")'))
self.assertFalse(rows[1].find(f'td:contains("{dated_milestones[1].desc}")'))
self.assertTrue(rows[1].find(f'td:contains("{dated_milestones[0].desc}")'))
# check order-by-order # check order-by-order
dateless_tbody = pq(f'td:contains("{dateless_milestones[0].desc}")').closest("tbody") dateless_tbody = pq(f'td:contains("{dateless_milestones[0].desc}")').closest("tbody")
next_td = dateless_tbody.find('td:contains("Next")') rows = list(dateless_tbody.items("tr")) # keep as pyquery objects
self.assertEqual(next_td.siblings()[0].text.strip(), dateless_milestones[0].desc) self.assertTrue(rows[0].find('td:first:contains("Last")')) # Last milestone shown first
last_td = dateless_tbody.find('td:contains("Last")') self.assertFalse(rows[0].find('td:first:contains("Next")'))
self.assertEqual(last_td.siblings()[0].text.strip(), dateless_milestones[1].desc) self.assertTrue(rows[0].find(f'td:contains("{dateless_milestones[1].desc}")'))
self.assertFalse(rows[0].find(f'td:contains("{dateless_milestones[0].desc}")'))
self.assertFalse(rows[1].find('td:first:contains("Last")')) # Last milestone shown first
self.assertTrue(rows[1].find('td:first:contains("Next")'))
self.assertFalse(rows[1].find(f'td:contains("{dateless_milestones[1].desc}")'))
self.assertTrue(rows[1].find(f'td:contains("{dateless_milestones[0].desc}")'))
def test_review_decisions(self): def test_review_decisions(self):