altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

fix(ui): debounce the scroll event to make chrome happy (#3958)

Browse source 
* fix: Debounce the scroll event, to make Chrome happy

* Address review comments

* fix: Prevent overscrolling from scrolling the main content

Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
This commit is contained in:
Lars Eggert 2022-05-18 12:01:22 -07:00 committed by GitHub
parent de6d8b2b2a
commit a1518e4dcb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pnp.cjs generated
View file

@ -53,6 +53,7 @@ function $$SETUP_STATE(hydrateRuntimeState, basePath) {
["jquery-ui-dist", "npm:1.13.1"],\ ["jquery-ui-dist", "npm:1.13.1"],\
["js-cookie", "npm:3.0.1"],\ ["js-cookie", "npm:3.0.1"],\
["list.js", "npm:2.3.1"],\ ["list.js", "npm:2.3.1"],\
["lodash", "npm:4.17.21"],\
["moment", "npm:2.29.3"],\ ["moment", "npm:2.29.3"],\
["moment-timezone", "npm:0.5.34"],\ ["moment-timezone", "npm:0.5.34"],\
["parcel", "npm:2.5.0"],\ ["parcel", "npm:2.5.0"],\
@ -5162,6 +5163,7 @@ function $$SETUP_STATE(hydrateRuntimeState, basePath) {
["jquery-ui-dist", "npm:1.13.1"],\ ["jquery-ui-dist", "npm:1.13.1"],\
["js-cookie", "npm:3.0.1"],\ ["js-cookie", "npm:3.0.1"],\
["list.js", "npm:2.3.1"],\ ["list.js", "npm:2.3.1"],\
["lodash", "npm:4.17.21"],\
["moment", "npm:2.29.3"],\ ["moment", "npm:2.29.3"],\
["moment-timezone", "npm:0.5.34"],\ ["moment-timezone", "npm:0.5.34"],\
["parcel", "npm:2.5.0"],\ ["parcel", "npm:2.5.0"],\

1
ietf/static/css/ietf.scss
View file

@ -177,6 +177,7 @@ table tbody.meta {
#righthand-nav { #righthand-nav {
height: 70vh; height: 70vh;
width: inherit; width: inherit;
overscroll-behavior-y: none; // Prevent overscrolling from scrolling the main content
} }
// Add some padding when there are multiple buttons in a line than can wrap // Add some padding when there are multiple buttons in a line than can wrap

12
ietf/static/js/ietf.js
View file

@ -24,6 +24,8 @@ if (!process.env.BUILD_DEPLOY) {
import Cookies from "js-cookie"; import Cookies from "js-cookie";
import debounce from "lodash/debounce";
// setup CSRF protection using jQuery // setup CSRF protection using jQuery
function csrfSafeMethod(method) { function csrfSafeMethod(method) {
// these HTTP methods do not require CSRF protection // these HTTP methods do not require CSRF protection
@ -244,15 +246,17 @@ $(function () {
extraNav.remove(); extraNav.remove();
} }
$(window) $(document)
.on("scroll", function () { // Chrome apparently wants this debounced to something >10ms,
// otherwise the main view doesn't scroll?
.on("scroll", debounce(function () {
const item = $('#righthand-nav') const item = $('#righthand-nav')
.find(".active") .find(".active")
.last(); .last();
if (item.length) { if (item.length) {
item[0].scrollIntoView({ block: "center" }); item[0].scrollIntoView({ block: "center", behavior: "smooth" });
} }
}); }, 100));
// offset the scrollspy to account for the menu bar // offset the scrollspy to account for the menu bar
const contentOffset = contentElement ? contentElement.offset().top : 0; const contentOffset = contentElement ? contentElement.offset().top : 0;

1
package.json
View file

@ -18,6 +18,7 @@
"jquery-ui-dist": "1.13.1", "jquery-ui-dist": "1.13.1",
"js-cookie": "3.0.1", "js-cookie": "3.0.1",
"list.js": "2.3.1", "list.js": "2.3.1",
"lodash": "4.17.21",
"moment": "2.29.3", "moment": "2.29.3",
"moment-timezone": "0.5.34", "moment-timezone": "0.5.34",
"select2": "4.1.0-rc.0", "select2": "4.1.0-rc.0",

3
yarn.lock
View file

@ -3409,7 +3409,7 @@ browserlist@latest:
languageName: node languageName: node
linkType: hard linkType: hard
"lodash@npm:^4.17.21": "lodash@npm:4.17.21, lodash@npm:^4.17.21":
version: 4.17.21 version: 4.17.21
resolution: "lodash@npm:4.17.21" resolution: "lodash@npm:4.17.21"
checksum: eb835a2e51d381e561e508ce932ea50a8e5a68f4ebdd771ea240d3048244a8d13658acbd502cd4829768c56f2e16bdd4340b9ea141297d472517b83868e677f7 checksum: eb835a2e51d381e561e508ce932ea50a8e5a68f4ebdd771ea240d3048244a8d13658acbd502cd4829768c56f2e16bdd4340b9ea141297d472517b83868e677f7
@ -4284,6 +4284,7 @@ browserlist@latest:
jquery-ui-dist: 1.13.1 jquery-ui-dist: 1.13.1
js-cookie: 3.0.1 js-cookie: 3.0.1
list.js: 2.3.1 list.js: 2.3.1
lodash: 4.17.21
moment: 2.29.3 moment: 2.29.3
moment-timezone: 0.5.34 moment-timezone: 0.5.34
parcel: 2.5.0 parcel: 2.5.0