altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

Merged in [14466] from rjsparks@nostrum.com:

Browse source 
Include information about previous team reviews in assignement emails. Fixes #2392.
 - Legacy-Id: 14469
Note: SVN reference [14466] has been migrated to Git commit 0a9737a5d2
This commit is contained in:
Henrik Levkowetz 2017-12-29 12:48:34 +00:00
parent a26296d6d5 0a9737a5d2
commit 9f806c19ec
3 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ietf/doc/tests_review.py
View file

@ -276,6 +276,7 @@ class ReviewTests(TestCase):
type=ReviewTypeName.objects.get(slug="early"), type=ReviewTypeName.objects.get(slug="early"),
team=review_req.team, team=review_req.team,
state=ReviewRequestStateName.objects.get(slug="completed"), state=ReviewRequestStateName.objects.get(slug="completed"),
result_id='serious-issues',
reviewed_rev="01", reviewed_rev="01",
deadline=datetime.date.today() - datetime.timedelta(days=80), deadline=datetime.date.today() - datetime.timedelta(days=80),
reviewer=reviewer_email, reviewer=reviewer_email,

18
ietf/review/utils.py
View file

@ -451,10 +451,26 @@ def assign_review_request_to_reviewer(request, review_req, reviewer, add_skip=Fa
state=None, state=None,
) )
msg = "%s has assigned you as a reviewer for this document." % request.user.person.ascii
prev_team_reviews = ReviewRequest.objects.filter(
doc=review_req.doc,
state="completed",
team=review_req.team,
)
if prev_team_reviews.exists():
msg = msg + '\n\nThis team has completed other reviews of this document:\n'
for req in prev_team_reviews:
msg += u'%s %s -%s %s\n'% (
req.review_done_time().strftime('%d %b %Y'),
req.reviewer.person.ascii,
req.reviewed_rev or req.requested_rev,
req.result.name,
)
email_review_request_change( email_review_request_change(
request, review_req, request, review_req,
"%s %s assignment: %s" % (review_req.team.acronym.capitalize(), review_req.type.name,review_req.doc.name), "%s %s assignment: %s" % (review_req.team.acronym.capitalize(), review_req.type.name,review_req.doc.name),
"%s has assigned you as a reviewer for this document." % request.user.person, msg ,
by=request.user.person, notify_secretary=False, notify_reviewer=True, notify_requested_by=False) by=request.user.person, notify_secretary=False, notify_reviewer=True, notify_requested_by=False)
def possibly_advance_next_reviewer_for_team(team, assigned_review_to_person_id, add_skip=False): def possibly_advance_next_reviewer_for_team(team, assigned_review_to_person_id, add_skip=False):

2
ready-for-merge
View file

@ -7,7 +7,7 @@
# --- Add entries at the top --- # --- Add entries at the top ---
/personal/housley/6.65.2.dev0@14467
/personal/housley/6.56.1.dev0@14062 /personal/housley/6.56.1.dev0@14062
#/personal/sbirkholz/6.56.1.dev0@13917 #/personal/sbirkholz/6.56.1.dev0@13917
/personal/alireza/6.56.1.dev0@13916 /personal/alireza/6.56.1.dev0@13916