altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

Use .assertIn(...) in tests instead of .assertTrue(x in y) as the failure messages are much more informative

Browse source 
- Legacy-Id: 15026
This commit is contained in:
Henrik Levkowetz 2018-04-07 10:09:07 +00:00
parent 96e4059e43
commit 9bd18df83b
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
ietf/submit/tests.py
View file

@ -282,17 +282,17 @@ class SubmitTests(TestCase):
self.assertEqual(draft.relations_that_doc("possibly-replaces").count(), 1)
self.assertTrue(draft.relations_that_doc("possibly-replaces").first().target, sug_replaced_alias)
self.assertEqual(len(outbox), mailbox_before + 4)
self.assertTrue((u"I-D Action: %s" % name) in outbox[-3]["Subject"])
self.assertTrue(author.ascii in unicode(outbox[-3]))
self.assertTrue("New Version Notification" in outbox[-2]["Subject"])
self.assertTrue(name in unicode(outbox[-2]))
self.assertTrue("mars" in unicode(outbox[-2]))
self.assertIn((u"I-D Action: %s" % name), outbox[-3]["Subject"])
self.assertIn(author.ascii, unicode(outbox[-3]))
self.assertIn("New Version Notification",outbox[-2]["Subject"])
self.assertIn(name, unicode(outbox[-2]))
self.assertIn("mars", unicode(outbox[-2]))
# Check "Review of suggested possible replacements for..." mail
self.assertTrue("review" in outbox[-1]["Subject"].lower())
self.assertTrue(name in unicode(outbox[-1]))
self.assertTrue(sug_replaced_alias.name in unicode(outbox[-1]))
self.assertTrue("ames-chairs@" in outbox[-1]["To"].lower())
self.assertTrue("mars-chairs@" in outbox[-1]["To"].lower())
self.assertIn("review", outbox[-1]["Subject"].lower())
self.assertIn(name, unicode(outbox[-1]))
self.assertIn(sug_replaced_alias.name, unicode(outbox[-1]))
self.assertIn("ames-chairs@", outbox[-1]["To"].lower())
self.assertIn("mars-chairs@", outbox[-1]["To"].lower())
# fetch the document page
url = urlreverse('ietf.doc.views_doc.document_main', kwargs={'name':name})