From 93e9f8e8504739952d4cfec4c89814192541b92c Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Fri, 19 May 2023 14:36:08 -0300 Subject: [PATCH] fix: Do not set update_fields when saving new instance --- ietf/doc/tests_draft.py | 4 ++-- ietf/nomcom/models.py | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/ietf/doc/tests_draft.py b/ietf/doc/tests_draft.py index 0ebfd6b8f..5b6dd63b9 100644 --- a/ietf/doc/tests_draft.py +++ b/ietf/doc/tests_draft.py @@ -573,7 +573,7 @@ class ResurrectTests(DraftFileMixin, TestCase): r = self.client.get(url) self.assertEqual(r.status_code, 200) q = PyQuery(r.content) - self.assertEqual(len(q('form [type=submit]')), 1) + self.assertEqual(len(q('#content form [type=submit]')), 1) # request resurrect @@ -609,7 +609,7 @@ class ResurrectTests(DraftFileMixin, TestCase): r = self.client.get(url) self.assertEqual(r.status_code, 200) q = PyQuery(r.content) - self.assertEqual(len(q('form [type=submit]')), 1) + self.assertEqual(len(q('#content form [type=submit]')), 1) # complete resurrect events_before = draft.docevent_set.count() diff --git a/ietf/nomcom/models.py b/ietf/nomcom/models.py index 28116354c..6c1281f9b 100644 --- a/ietf/nomcom/models.py +++ b/ietf/nomcom/models.py @@ -187,11 +187,10 @@ class NomineePosition(models.Model): ordering = ['nominee'] def save(self, **kwargs): - update_fields = kwargs.pop("update_fields", None) if not self.pk and not self.state_id: + # Don't need to set update_fields because the self.pk test means this is a new instance self.state = NomineePositionStateName.objects.get(slug='pending') - update_fields = {"slug"}.union(update_fields or set()) - super().save(update_fields=update_fields, **kwargs) + super().save(**kwargs) def __str__(self): return "%s - %s - %s" % (self.nominee, self.state, self.position)