altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 4 Packages Projects Releases Wiki Activity

chore: remove workspace chown from dev init script + add warning when using root

Browse source
This commit is contained in:
Nicolas Giard 2022-05-21 00:18:24 -04:00 committed by GitHub
parent 49cf639f16
commit 9316429e0e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docker/app.Dockerfile
View file

@ -1,4 +1,4 @@
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.236.0/containers/python-3/.devcontainer/base.Dockerfile # Based on image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.236.0/containers/python-3/.devcontainer/base.Dockerfile
# [Choice] Python version (use -bullseye variants on local arm64/Apple Silicon): 3, 3.10, 3.9, 3.8, 3.7, 3.6, 3-bullseye, 3.10-bullseye, 3.9-bullseye, 3.8-bullseye, 3.7-bullseye, 3.6-bullseye, 3-buster, 3.10-buster, 3.9-buster, 3.8-buster, 3.7-buster, 3.6-buster # [Choice] Python version (use -bullseye variants on local arm64/Apple Silicon): 3, 3.10, 3.9, 3.8, 3.7, 3.6, 3-bullseye, 3.10-bullseye, 3.9-bullseye, 3.8-bullseye, 3.7-bullseye, 3.6-bullseye, 3-buster, 3.10-buster, 3.9-buster, 3.8-buster, 3.7-buster, 3.6-buster
ARG VARIANT=3-bullseye ARG VARIANT=3-bullseye

1
docker/run
View file

@ -54,6 +54,7 @@ if [ $NEW_UID -gt 0 ]; then
echo "GROUP ID: $NEW_GID" echo "GROUP ID: $NEW_GID"
else else
echo "Running as root, will use default user/group mapping..." echo "Running as root, will use default user/group mapping..."
echo "NOT RECOMMENDED - You may experience permission issues."
NEW_UID=1000 NEW_UID=1000
NEW_GID=1000 NEW_GID=1000
fi fi

1
docker/scripts/app-init.sh
View file

@ -8,7 +8,6 @@ sudo service rsyslog start
echo "Fixing volumes ownership..." echo "Fixing volumes ownership..."
sudo chown -R vscode:vscode "$WORKSPACEDIR/.parcel-cache" sudo chown -R vscode:vscode "$WORKSPACEDIR/.parcel-cache"
sudo chown -R vscode:vscode "$WORKSPACEDIR/__pycache__" sudo chown -R vscode:vscode "$WORKSPACEDIR/__pycache__"
sudo chown -R vscode:vscode "$WORKSPACEDIR"
# Build node packages that requrie native compilation # Build node packages that requrie native compilation
echo "Compiling native node packages..." echo "Compiling native node packages..."