From 9133b9469e556081b6fb8c3ba24225944e4cdc27 Mon Sep 17 00:00:00 2001
From: Lars Eggert <lars@eggert.org>
Date: Wed, 22 Jul 2015 14:06:02 +0000
Subject: [PATCH] Style the metadata tables for groups, documents, etc. like
 Henrik prefers.

Commit ready for merge.
 - Legacy-Id: 9856
---
 ietf/templates/doc/document_charter.html      | 22 +++++-----
 .../doc/document_conflict_review.html         | 16 +++----
 ietf/templates/doc/document_draft.html        | 42 +++++++++----------
 .../templates/doc/document_status_change.html | 18 ++++----
 ietf/templates/group/group_about.html         | 27 ++++++------
 static/css/ietf.css                           |  7 +++-
 6 files changed, 69 insertions(+), 63 deletions(-)

diff --git a/ietf/templates/doc/document_charter.html b/ietf/templates/doc/document_charter.html
index 4c131542d..27b1378cc 100644
--- a/ietf/templates/doc/document_charter.html
+++ b/ietf/templates/doc/document_charter.html
@@ -27,11 +27,11 @@
        </tr>
     </thead>
 
-    <tbody>
+    <tbody class="meta">
 
       <tr>
 	<th>Document</th>
-	<th class="text-right">
+	<th>
 	  {% if doc.get_state_slug != "approved" %}
 	    Proposed charter
 	  {% else %}
@@ -49,7 +49,7 @@
 	</td>
       </tr>
 
-      <tr class="plain">
+      <tr>
         <td></td>
 	<th>Title</th>
 	<td class="edit">
@@ -60,14 +60,14 @@
 	<td>{{ doc.title }}</td>
       </tr>
 
-      <tr class="plain">
+      <tr>
         <td></td>
 	<th>Last updated</th>
 	<td class="edit"></td>
 	<td>{{ doc.time|date:"Y-m-d" }}</td>
       </tr>
 
-      <tr class="plain">
+      <tr>
         <td></td>
 	<th><a href="/doc/help/state/charter/">State</a></th>
 	<td class="edit">
@@ -89,19 +89,19 @@
 
     </tbody>
 
-    <tbody>
+    <tbody class="meta">
       <tr>
 	<th>WG</th>
-	<th class="text-right">State</th>
+	<th>State</th>
 	<td class="edit"></td>
 	<td>{{ group.state.name }}</td>
       </tr>
     </tbody>
 
-    <tbody>
+    <tbody class="meta">
       <tr>
 	<th>IESG</th>
-	<th class="text-right">Responsible AD</th>
+	<th>Responsible AD</th>
 	<td class="edit">
 	  {% if can_manage %}
 	    {% doc_edit_button "charter_edit_ad" name=doc.name %}
@@ -113,7 +113,7 @@
       </tr>
 
       {% if not snapshot and chartering %}
-	<tr class="plain">
+	<tr>
 	  <td></td>
 	  <th>Telechat date</th>
 	  <td class="edit">
@@ -135,7 +135,7 @@
       </tr>
       {% endif %}
 
-      <tr class="plain">
+      <tr>
 	<td></td>
 	<th>Send notices to</th>
 	<td class="edit">
diff --git a/ietf/templates/doc/document_conflict_review.html b/ietf/templates/doc/document_conflict_review.html
index 456c3f73e..1dcb5ab9a 100644
--- a/ietf/templates/doc/document_conflict_review.html
+++ b/ietf/templates/doc/document_conflict_review.html
@@ -23,10 +23,10 @@
        </tr>
     </thead>
 
-    <tbody>
+    <tbody class="meta">
       <tr>
 	<th>Document</th>
-	<th class="text-right">
+	<th>
 	  {% if doc.get_state_slug not in approved_states %}
 	    Proposed conflict review
 	  {% else %}
@@ -46,14 +46,14 @@
 	</td>
       </tr>
 
-      <tr class="plain">
+      <tr>
       	<td></td>
 	<th>Last updated</th>
 	<td class="edit"></td>
 	<td>{{ doc.time|date:"Y-m-d" }}</td>
       </tr>
 
-      <tr class="plain">
+      <tr>
       	<td></td>
 	<th><a href="/doc/help/state/conflict-review/">State</a></th>
 	<td class="edit">
@@ -67,10 +67,10 @@
       </tr>
 
     </tbody>
-    <tbody>
+    <tbody class="meta">
       <tr>
 	<th>IESG</th>
-	<th class="text-right">Shepherding AD</th>
+	<th>Shepherding AD</th>
 	<td class="edit">
 	  {% if not snapshot and user|has_role:"Area Director,Secretariat" and doc.get_state_slug not in approved_states %}
 	    <a class="btn btn-default btn-xs pull-right" href="{% url "conflict_review_ad" name=doc.name %}">Edit</a>
@@ -82,7 +82,7 @@
       </tr>
 
       {% if not snapshot %}
-	<tr class="plain">
+	<tr>
 	  <td></td>
 	  <th>Telechat date</th>
 	  <td class="edit">
@@ -105,7 +105,7 @@
 	</tr>
       {% endif %}
 
-      <tr class="plain">
+      <tr>
 	<td></td>
 	<th>Send notices to</th>
 	<td class="edit">
diff --git a/ietf/templates/doc/document_draft.html b/ietf/templates/doc/document_draft.html
index 23caab284..5998e7ea7 100644
--- a/ietf/templates/doc/document_draft.html
+++ b/ietf/templates/doc/document_draft.html
@@ -38,7 +38,7 @@
        </tr>
     </thead>
 
-    <tbody>
+    <tbody class="meta">
       <tr>
 	<th>Document</th>
 	<th>Type</th>
@@ -64,7 +64,7 @@
       </tr>
 
       <tr>
-      	<th class="plain"></th>
+      	<th></th>
 	<th>Last updated</th>
 	<td class="edit"></td>
 	<td>
@@ -77,7 +77,7 @@
 
       {% if replaces or can_edit_stream_info %}
 	<tr>
-	  <th class="plain"></th>
+	  <th></th>
 	  <th>Replaces</th>
 	  <td class="edit">
 	    {% if can_edit_stream_info %}
@@ -92,7 +92,7 @@
 
       {% if replaced_by %}
 	<tr>
-	  <th class="plain"></th>
+	  <th></th>
 	  <th>Replaced by</th>
 	  <td class="edit"></td>
 	  <td>
@@ -132,7 +132,7 @@
       {% endif %}
 
       <tr>
-        <th class="plain"></th>
+        <th></th>
 	<th>Stream</th>
 	<td class="edit">
 	  {% if can_change_stream %}
@@ -146,7 +146,7 @@
 
       {% if doc.get_state_slug != "rfc" %}
 	<tr>
-	  <th class="plain"></th>
+	  <th></th>
 	  <th>Intended RFC status</th>
 	  <td class="edit">
 	    {% if can_edit or can_edit_stream_info %}
@@ -160,7 +160,7 @@
       {% endif %}
 
       <tr>
-        <th class="plain"></th>
+        <th></th>
 	<th>Formats</th>
 	<td class="edit"></td>
 	<td>
@@ -179,7 +179,7 @@
 
       {% if conflict_reviews %}
 	<tr>
-          <th class="plain"></th>
+          <th></th>
 	  <th>IETF conflict review</th>
 	  <td class="edit"></td>
 	  <td>{{ conflict_reviews|join:", "|urlize_ietf_docs }}</td>
@@ -187,7 +187,7 @@
       {% endif %}
 
     </tbody>
-    <tbody>
+    <tbody class="meta">
       <tr>
 	<th>Stream</th>
 	{% if doc.stream %}
@@ -225,7 +225,7 @@
 
       {% if consensus %}
 	<tr>
-	  <th class="plain"></th>
+	  <th></th>
 	  <th>Consensus</th>
 	  <td class="edit">
 	    {% if can_edit or can_edit_stream_info %}
@@ -239,7 +239,7 @@
       {% endif %}
 
       <tr>
-        <th class="plain"></th>
+        <th></th>
 	<th>Document shepherd</th>
 	<td class="edit">
 	  {% if can_edit_stream_info %}
@@ -255,7 +255,7 @@
 
       {% if shepherd_writeup or can_edit_shepherd_writeup %}
 	<tr>
-	  <th class="plain"></th>
+	  <th></th>
 	  <th>Shepherd write-up</th>
 	  <td class="edit">
 	    {% if can_edit_shepherd_writeup %}
@@ -278,13 +278,13 @@
 
       {% if published and started_iesg_process and published.time < started_iesg_process.time %}
 	<tr>
-	  <th class="plain"></th>
+	  <th></th>
 	  <th colspan="3" class="warning">This information refers to IESG processing after the RFC was initially published:</th>
 	</tr>
       {% endif %}
 
     </tbody>
-    <tbody>
+    <tbody class="meta">
       <tr>
 	<th>IESG</th>
 	<th><a href="{% url "ietf.help.views.state" doc=doc.type.slug type="iesg" %}">IESG state</a></th>
@@ -299,7 +299,7 @@
       </tr>
 
       <tr>
-        <th class="plain"></th>
+        <th></th>
 	<th>Telechat date</th>
 	<td class="edit">
 	  {% if can_edit %}
@@ -325,7 +325,7 @@
       </tr>
 
       <tr>
-        <th class="plain"></th>
+        <th></th>
 	<th>Responsible AD</th>
 	<td class="edit">
 	  {% if can_edit %}
@@ -340,7 +340,7 @@
       {% if iesg_state %}
 	{% if doc.note or can_edit %}
 	  <tr>
-	    <th class="plain"></th>
+	    <th></th>
 	    <th>IESG note</th>
 	    <td class="edit">
 	      {% if can_edit %}
@@ -355,7 +355,7 @@
       {% endif %}
 
       <tr>
-        <th class="plain"></th>
+        <th></th>
 	<th>Send notices to</th>
 	<td class="edit">
 	  {% if can_edit_notify %}
@@ -370,7 +370,7 @@
     </tbody>
 
     {% if iana_review_state %}
-    <tbody>
+    <tbody class="meta">
       <tr>
 	<th>IANA</th>
 	<th><a href="{% url "ietf.help.views.state" doc=doc.type.slug type="iana-review" %}">IANA review state</a></th>
@@ -385,7 +385,7 @@
       </tr>
 
       <tr>
-        <th class="plain"></th>
+        <th></th>
 	<th>IANA action state</th>
 	<td class="edit">
 	  {% if can_edit_iana_state %}
@@ -399,7 +399,7 @@
     </tbody>
     {% endif %}
 
-    <tbody>
+    <tbody class="meta">
       {% if rfc_editor_state %}
 	<tr>
 	  <th>RFC Editor</th>
diff --git a/ietf/templates/doc/document_status_change.html b/ietf/templates/doc/document_status_change.html
index c02cd876f..d6542332a 100644
--- a/ietf/templates/doc/document_status_change.html
+++ b/ietf/templates/doc/document_status_change.html
@@ -23,10 +23,10 @@
        </tr>
     </thead>
 
-    <tbody>
+    <tbody class="meta">
       <tr>
 	<th>Document</th>
-	<th class="text-right">
+	<th>
 	  {% if doc.get_state_slug not in approved_states %}
 	    Proposed status change
 	  {% else %}
@@ -46,7 +46,7 @@
 	</td>
       </tr>
 
-      <tr class="plain">
+      <tr>
         <th></th>
 	<th>Last updated</th>
 	<td class="edit"></td>
@@ -56,7 +56,7 @@
 
     {% regroup sorted_relations by relationship.name as relation_groups %}
       {% for relation_group in relation_groups %}
-	<tr class="plain">
+	<tr>
           <th></th>
 	  <th>{{relation_group.grouper}}</th>
 	  <td class="edit"></td>
@@ -64,7 +64,7 @@
 	</tr>
       {% endfor %}
 
-      <tr class="plain">
+      <tr>
         <th></th>
 	<th><a href="{% url "state_help" type="status-change" %}">State</a></th>
 	<td class="edit">
@@ -78,10 +78,10 @@
       </tr>
 
     </tbody>
-    <tbody>
+    <tbody class="meta">
       <tr>
 	<th>IESG</th>
-	<th class="text-right">Telechat date</th>
+	<th>Telechat date</th>
 	<td class="edit">
 	  {% if not snapshot and user|has_role:"Area Director,Secretariat" and doc.get_state_slug not in approved_states %}
 	    <a class="btn btn-default btn-xs pull-right" href="{% url "status_change_telechat_date" name=doc.name %}">Edit</a>
@@ -101,7 +101,7 @@
 	</td>
       </tr>
 
-      <tr class="plain">
+      <tr>
         <th></th>
 	<th>Shepherding AD</th>
 	<td class="edit">
@@ -114,7 +114,7 @@
 	</td>
       </tr>
 
-      <tr class="plain">
+      <tr>
         <th></th>
 	<th>Send notices to</th>
 	<td class="edit">
diff --git a/ietf/templates/group/group_about.html b/ietf/templates/group/group_about.html
index dcbf15461..c3f4565ba 100644
--- a/ietf/templates/group/group_about.html
+++ b/ietf/templates/group/group_about.html
@@ -10,8 +10,9 @@
     <p class="alert alert-warning"><b>Note:</b> The data for concluded {{ group.type.name }}s is occasionally incorrect.</p>
   {% endif %}
 
+  <br>
   <table class="table table-condensed">
-     <tbody>
+     <tbody class="meta">
     <tr>
       <th>{{ group.type.name }}</th>
       <th>Name</th>
@@ -19,13 +20,13 @@
     </tr>
 
     <tr>
-      <td class="plain"></td>
+      <td></td>
       <th>Acronym</th>
       <td>{{ group.acronym }}</td>
     </tr>
 
     <tr>
-      <td class="plain"></td>
+      <td></td>
       {% if group.parent and group.parent.type_id == "area" %}
         <th>{{ group.parent.type.name }}</th>
         <td>{{ group.parent.name }} ({{ group.parent.acronym }})</td>
@@ -35,7 +36,7 @@
     </tr>
 
     <tr>
-      <td class="plain"></td>
+      <td></td>
       <th>State</th>
       <td>
         {{ group.state.name }}
@@ -47,7 +48,7 @@
 
     {% if group.features.has_chartering_process %}
       <tr>
-        <td class="plain"></td>
+        <td></td>
         <th>Charter</th>
         <td>
           {% if group.charter %}
@@ -67,7 +68,7 @@
       {% with group.groupurl_set.all as urls %}
         {% if urls %}
 	<tr>
-          <td class="plain"></td>
+          <td></td>
           <th>More info</th>
           <td>
             {% for url in urls %}
@@ -78,13 +79,13 @@
         {% endif %}
       {% endwith %}
     </tbody>
-    <tbody>
+    <tbody class="meta">
     {% for slug, label, roles in group.personnel %}
       <tr>
 	{% if forloop.first %}
 	<th>Personnel</th>
   {% else %}
-  <td class="plain"></td>
+  <td></td>
 	{% endif %}
         <th>{{ label }}</th>
         <td>
@@ -101,18 +102,18 @@
 
 
     {% if group.list_email %}
-    <tbody>
+    <tbody class="meta">
       <tr>
 	 <th>Mailing list</th>
 	 <th>Address</th><td>{{ group.list_email|urlize }}</td>
       </tr>
-      <tr><td class="plain"></td><th>To subscribe</th><td>{{ group.list_subscribe|urlize }}</td></tr>
-      <tr><td class="plain"></td><th>Archive</th><td>{{ group.list_archive|urlize }}</td></tr>
+      <tr><td></td><th>To subscribe</th><td>{{ group.list_subscribe|urlize }}</td></tr>
+      <tr><td></td><th>Archive</th><td>{{ group.list_archive|urlize }}</td></tr>
     </tbody>
     {% endif %}
 
     {% if group.state_id != "conclude" and group.type_id != "sdo" and group.type_id != "rfcedtyp" and group.type_id != "isoc" %}
-    <tbody>
+    <tbody class="meta">
       <tr>
 	 <th>Jabber chat</th>
         <th>Room address</th>
@@ -120,7 +121,7 @@
       </tr>
 
       <tr>
-        <td class="plain"></td>
+        <td></td>
         <th>Logs</th>
         <td><a href="https://jabber.ietf.org/logs/{{ group.acronym }}/">https://jabber.ietf.org/logs/{{ group.acronym }}/</a></td>
       </tr>
diff --git a/static/css/ietf.css b/static/css/ietf.css
index 262a5f479..e68b3e878 100644
--- a/static/css/ietf.css
+++ b/static/css/ietf.css
@@ -392,7 +392,12 @@ footer {
 */
 
 
-table tbody td.plain, table tbody th.plain { border-top: 0; }
+table tbody.meta th, table tbody.meta td { border-top: 0; }
+
+table tbody.meta th:nth-child(2), table tbody.meta td:nth-child(2) {
+	text-align: right;
+}
+
 
 td.ad div { border-bottom: solid #ccc 1px; }