From 8ef92312d0590c2ee336921f4c0d3027afce8b59 Mon Sep 17 00:00:00 2001
From: Lars Eggert <lars@eggert.org>
Date: Thu, 19 May 2022 10:31:29 -0700
Subject: [PATCH] fix: Don't urlencode all resource URLs (#3988)

While this does suppress errors, it breaks even valid URLs. Instead, just
suppress the validation error for those few cases in the database.
---
 ietf/templates/doc/document_bofreq.html | 2 +-
 ietf/templates/doc/document_draft.html  | 2 +-
 ietf/templates/group/group_about.html   | 2 +-
 ietf/utils/test_runner.py               | 1 +
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/ietf/templates/doc/document_bofreq.html b/ietf/templates/doc/document_bofreq.html
index 1409167bf..7ed139d58 100644
--- a/ietf/templates/doc/document_bofreq.html
+++ b/ietf/templates/doc/document_bofreq.html
@@ -107,7 +107,7 @@
                             {% if resources %}
                                 {% for resource in resources|dictsort:"display_name" %}
                                     {% if resource.name.type.slug == 'url' or resource.name.type.slug == 'email' %}
-                                        <a href="{{ resource.value|urlencode }}" title="{{ resource.name.name }}">
+                                        <a href="{{ resource.value }}" title="{{ resource.name.name }}">
                                             {% firstof resource.display_name resource.name.name %}
                                         </a>
                                         <br>
diff --git a/ietf/templates/doc/document_draft.html b/ietf/templates/doc/document_draft.html
index f05c496c0..6f5561653 100644
--- a/ietf/templates/doc/document_draft.html
+++ b/ietf/templates/doc/document_draft.html
@@ -366,7 +366,7 @@
                             {% if resources or doc.group and doc.group.list_archive %}
                                 {% for resource in resources|dictsort:"display_name" %}
                                     {% if resource.name.type.slug == 'url' or resource.name.type.slug == 'email' %}
-                                        <a href="{{ resource.value|urlencode }}" title="{{ resource.name.name }}">
+                                        <a href="{{ resource.value }}" title="{{ resource.name.name }}">
                                             {% firstof resource.display_name resource.name.name %}
                                         </a>
                                         <br>
diff --git a/ietf/templates/group/group_about.html b/ietf/templates/group/group_about.html
index 41e524c8c..3bdd4da21 100644
--- a/ietf/templates/group/group_about.html
+++ b/ietf/templates/group/group_about.html
@@ -150,7 +150,7 @@
                                 {% for resource in resources|dictsort:"display_name" %}
                                     {# Maybe make how a resource displays itself a method on the class so templates aren't doing this switching #}
                                     {% if resource.name.type.slug == 'url' or resource.name.type.slug == 'email' %}
-                                        <a href="{{ resource.value|urlencode }}" title="{{ resource.name.name }}">
+                                        <a href="{{ resource.value }}" title="{{ resource.name.name }}">
                                             {% firstof resource.display_name resource.name.name %}</a>{% else %}
                                         <span title="{{ resource.name.name }}">
                                             {% firstof resource.display_name resource.name.name %}: {{ resource.value|escape }}
diff --git a/ietf/utils/test_runner.py b/ietf/utils/test_runner.py
index ee3763f44..77c82d2fd 100644
--- a/ietf/utils/test_runner.py
+++ b/ietf/utils/test_runner.py
@@ -177,6 +177,7 @@ def vnu_filter_message(msg, filter_db_issues, filter_test_issues):
     "True if the vnu message is a known false positive"
     if filter_db_issues and re.search(
         r"""^Forbidden\ code\ point\ U\+|
+             Illegal\ character\ in\ query:\ '\['|
             'href'\ on\ element\ 'a':\ Percentage\ \("%"\)\ is\ not\ followed|
             ^Saw\ U\+\d+\ in\ stream|
             ^Document\ uses\ the\ Unicode\ Private\ Use\ Area""",