From 83f1b6229e02924a006f4cdce54e61857a8e5637 Mon Sep 17 00:00:00 2001 From: Robert Sparks <rjsparks@nostrum.com> Date: Wed, 21 Jul 2021 22:38:15 +0000 Subject: [PATCH] Correct calculation of bofreq_responsible mailtrigger.Recipient to return no addresses for documents that are not of type bofreq. Commit ready for merge. Fixes #3358. - Legacy-Id: 19255 --- ietf/mailtrigger/models.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/ietf/mailtrigger/models.py b/ietf/mailtrigger/models.py index 1ead8b804..a1b712c57 100644 --- a/ietf/mailtrigger/models.py +++ b/ietf/mailtrigger/models.py @@ -406,13 +406,14 @@ class Recipient(models.Model): def gather_bofreq_responsible(self, **kwargs): addrs = [] if 'doc' in kwargs: - bofreq = kwargs['doc'] - responsible = bofreq_responsible(bofreq) - if responsible: - addrs.extend([leader.email_address() for leader in responsible]) - else: - addrs.extend(Recipient.objects.get(slug='iab').gather(**{})) - addrs.extend(Recipient.objects.get(slug='iesg').gather(**{})) + doc = kwargs['doc'] + if doc.type_id=='bofreq': + responsible = bofreq_responsible(doc) + if responsible: + addrs.extend([leader.email_address() for leader in responsible]) + else: + addrs.extend(Recipient.objects.get(slug='iab').gather(**{})) + addrs.extend(Recipient.objects.get(slug='iesg').gather(**{})) return addrs def gather_bofreq_previous_responsible(self, **kwargs):