From 7f7b7716503918f37872bec81d588565be7079aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Jim=C3=A9nez?= Date: Fri, 22 Mar 2013 09:03:58 +0000 Subject: [PATCH] Improve save questionnaire data. See #970 - Legacy-Id: 5583 --- ietf/nomcom/forms.py | 6 +----- ietf/nomcom/views.py | 1 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/ietf/nomcom/forms.py b/ietf/nomcom/forms.py index f833d8bfa..7505ff39c 100644 --- a/ietf/nomcom/forms.py +++ b/ietf/nomcom/forms.py @@ -608,20 +608,16 @@ class QuestionnaireForm(BaseNomcomForm, forms.ModelForm): def save(self, commit=True): feedback = super(QuestionnaireForm, self).save(commit=False) - nominee = self.cleaned_data.get("nominee") - positions = self.cleaned_data.get("positions") - author = get_user_email(self.user) if author: feedback.author = author feedback.nomcom = self.nomcom - feedback.nominee = nominee feedback.user = self.user feedback.type = FeedbackType.objects.get(slug='questio') feedback.save() - feedback.positions = positions + self.save_m2m() class Meta: model = Feedback diff --git a/ietf/nomcom/views.py b/ietf/nomcom/views.py index 190443226..df94cb39c 100644 --- a/ietf/nomcom/views.py +++ b/ietf/nomcom/views.py @@ -308,6 +308,7 @@ def feedback(request, year, public): 'selected': 'feedback'}, RequestContext(request)) +@member_required(role='chair') def private_questionnaire(request, year): nomcom = get_nomcom_by_year(year) has_publickey = nomcom.public_key and True or False