Don't create empty Alias records. Fixes issue #1603.

- Legacy-Id: 9086
This commit is contained in:
Henrik Levkowetz 2015-02-13 13:04:42 +00:00
parent a85725e146
commit 7bd647c0d6
2 changed files with 4 additions and 2 deletions

View file

@ -92,7 +92,7 @@ class Person(PersonInfo):
))
send_mail_preformatted(None, msg)
self.alias_set.get_or_create(name=self.name)
if self.name != self.ascii:
if self.ascii and self.name != self.ascii:
self.alias_set.get_or_create(name=self.ascii)
#this variable, if not None, may be used by url() to keep the sitefqdn.

View file

@ -173,7 +173,9 @@ def edit(request, id):
for field in ('name','ascii','ascii_short'):
if field in person_form.changed_data:
person.alias_set.filter(name=getattr(person,field)).delete()
Alias.objects.get_or_create(person=person,name=person_form.cleaned_data[field])
alias = person_form.cleaned_data[field]
if alias:
Alias.objects.get_or_create(person=person,name=alias)
person_form.save()
email_formset.save()