From 7bc5e4fbfce1715b7d739e0372431a443e485d4b Mon Sep 17 00:00:00 2001
From: Henrik Levkowetz <henrik@levkowetz.com>
Date: Thu, 23 Jul 2020 14:58:21 +0000
Subject: [PATCH] Added a check for inallowable characters in slide titles at
 upload time.  - Legacy-Id: 18239

---
 ietf/meeting/tests_views.py | 17 +++++++++++++++++
 ietf/meeting/views.py       |  3 +++
 2 files changed, 20 insertions(+)

diff --git a/ietf/meeting/tests_views.py b/ietf/meeting/tests_views.py
index 596b9b3a1..cdaa4f417 100644
--- a/ietf/meeting/tests_views.py
+++ b/ietf/meeting/tests_views.py
@@ -2635,6 +2635,23 @@ class MaterialsTests(TestCase):
         self.assertEqual(sp.rev,'01')
         self.assertEqual(sp.document.rev,'01')
  
+    def test_upload_slide_title_bad_unicode(self):
+        session1 = SessionFactory(meeting__type_id='ietf')
+        url = urlreverse('ietf.meeting.views.upload_session_slides',kwargs={'num':session1.meeting.number,'session_id':session1.id})
+        login_testing_unauthorized(self,"secretary",url)
+        r = self.client.get(url)
+        self.assertEqual(r.status_code, 200)
+        q = PyQuery(r.content)
+        self.assertIn('Upload', str(q("title")))
+        self.assertFalse(session1.sessionpresentation_set.filter(document__type_id='slides'))
+        test_file = BytesIO(b'this is not really a slide')
+        test_file.name = 'not_really.txt'
+        r = self.client.post(url,dict(file=test_file,title='title with bad character \U0001fabc '))
+        self.assertEqual(r.status_code, 200)
+        q = PyQuery(r.content)
+        self.assertTrue(q('form .has-error'))
+        self.assertIn("Unicode BMP", q('form .has-error div').text())
+
     def test_remove_sessionpresentation(self):
         session = SessionFactory(meeting__type_id='ietf')
         doc = DocumentFactory(type_id='slides')
diff --git a/ietf/meeting/views.py b/ietf/meeting/views.py
index e2b86ad29..a4e7f60dc 100644
--- a/ietf/meeting/views.py
+++ b/ietf/meeting/views.py
@@ -1993,6 +1993,9 @@ class UploadSlidesForm(FileUploadForm):
 
     def clean_title(self):
         title = self.cleaned_data['title']
+        # THe current tables only handles Unicode BMP:
+        if ord(max(title)) > 0xffff:
+            raise forms.ValidationError("The title contains characters outside the Unicode BMP, which is not currently supported")
         if self.session.meeting.type_id=='interim':
             if re.search(r'-\d{2}$', title):
                 raise forms.ValidationError("Interim slides currently may not have a title that ends with something that looks like a revision number (-nn)")