From 78e4fa623e3fbb074074fdf6c0624c0f0aea016f Mon Sep 17 00:00:00 2001 From: Ole Laursen Date: Mon, 17 Oct 2016 21:52:07 +0000 Subject: [PATCH] Tweak the sort order so that the minimum interval between reviews is considered of lower importance compared to previous reviews/wishes to review the document - Legacy-Id: 12167 --- ietf/review/utils.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ietf/review/utils.py b/ietf/review/utils.py index 46632ac05..894d3ce89 100644 --- a/ietf/review/utils.py +++ b/ietf/review/utils.py @@ -702,18 +702,18 @@ def make_assignment_choices(email_queryset, review_req): if periods: explanations.append(", ".join(format_period(p) for p in periods)) - # minimum interval between reviews - days_needed = days_needed_for_reviewers.get(e.person_id, 0) - scores.append(-days_needed) - if days_needed > 0: - explanations.append("max frequency exceeded, ready in {} {}".format(days_needed, "day" if days_needed == 1 else "days")) - # misc add_boolean_score(+1, e.pk in has_reviewed_previous, "reviewed document before") add_boolean_score(+1, e.person_id in wish_to_review, "wishes to review document") add_boolean_score(-1, e.pk in connections, connections.get(e.pk)) # reviewer is somehow connected: bad add_boolean_score(-1, settings.filter_re and any(re.search(settings.filter_re, n) for n in aliases), "filter regexp matches") + # minimum interval between reviews + days_needed = days_needed_for_reviewers.get(e.person_id, 0) + scores.append(-days_needed) + if days_needed > 0: + explanations.append("max frequency exceeded, ready in {} {}".format(days_needed, "day" if days_needed == 1 else "days")) + # skip next scores.append(-settings.skip_next) if settings.skip_next > 0: