From 73a41bb7e61db005d984820c5ad207666769fd87 Mon Sep 17 00:00:00 2001 From: Ole Laursen Date: Mon, 12 Oct 2015 15:03:00 +0000 Subject: [PATCH] Summary: Fix problem with three NomCom tests that had a hard-coded id, which doesn't necessarily work with the way transactions work in MySQL - Legacy-Id: 10190 --- ietf/nomcom/tests.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/ietf/nomcom/tests.py b/ietf/nomcom/tests.py index f54401280..2d14e3e11 100644 --- a/ietf/nomcom/tests.py +++ b/ietf/nomcom/tests.py @@ -108,7 +108,7 @@ class NomcomViewsTest(TestCase): def create_nominees_for_states(self, base_state): cnominee = Nominee.objects.get(email__person__user__username=COMMUNITY_USER) position = Position.objects.get(name='APP') - NomineePosition.objects.create(position=position, + nom_pos = NomineePosition.objects.create(position=position, nominee=cnominee, state=NomineePositionStateName.objects.get(slug=base_state)) position = Position.objects.get(name='INT') @@ -119,12 +119,13 @@ class NomcomViewsTest(TestCase): NomineePosition.objects.create(position=position, nominee=cnominee, state=NomineePositionStateName.objects.get(slug=base_state)) + return nom_pos def test_private_index_post_accept(self): - self.create_nominees_for_states('pending') + nom_pos = self.create_nominees_for_states('pending') login_testing_unauthorized(self, CHAIR_USER, self.private_index_url) test_data = {"action": "set_as_accepted", - "selected": [1]} + "selected": [nom_pos.pk]} r = self.client.post(self.private_index_url, test_data) self.assertEqual(r.status_code, 200) q = PyQuery(r.content) @@ -133,10 +134,10 @@ class NomcomViewsTest(TestCase): self.client.logout() def test_private_index_post_decline(self): - self.create_nominees_for_states('pending') + nom_pos = self.create_nominees_for_states('pending') login_testing_unauthorized(self, CHAIR_USER, self.private_index_url) test_data = {"action": "set_as_declined", - "selected": [1]} + "selected": [nom_pos.pk]} r = self.client.post(self.private_index_url, test_data) self.assertEqual(r.status_code, 200) q = PyQuery(r.content) @@ -145,10 +146,10 @@ class NomcomViewsTest(TestCase): self.client.logout() def test_private_index_post_pending(self): - self.create_nominees_for_states('declined') + nom_pos = self.create_nominees_for_states('declined') login_testing_unauthorized(self, CHAIR_USER, self.private_index_url) test_data = {"action": "set_as_pending", - "selected": [1]} + "selected": [nom_pos.pk]} r = self.client.post(self.private_index_url, test_data) self.assertEqual(r.status_code, 200) q = PyQuery(r.content)