altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

fix: Listen for show.bs.modal on document (#5565)

Browse source 
Avoids losing the listener when DOM is changed dynamically.
This commit is contained in:
Jennifer Richards 2023-05-02 14:50:38 -04:00 committed by GitHub
parent 1359a5998f
commit 6986cae1bf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
ietf/static/js/ietf.js
View file

@ -255,25 +255,26 @@ $(document)
// Bootstrap doesn't load modals via href anymore, so let's do it ourselves. // Bootstrap doesn't load modals via href anymore, so let's do it ourselves.
// See https://stackoverflow.com/a/48934494/2240756 // See https://stackoverflow.com/a/48934494/2240756
// Instead of attaching to the modal elements as in that example, though,
// listen on document and filter with the .modal selector. This allows handling
// of modals that are added dynamically (e.g., list.js apparently replaces DOM
// elements with identical copies, minus any attached listeners).
$(document) $(document)
.ready(function () { .on('show.bs.modal', '.modal', function (e) {
$('.modal') var button = $(e.relatedTarget);
.on('show.bs.modal', function (e) { if (!$(button)
var button = $(e.relatedTarget); .attr("href")) {
if (!$(button) return;
.attr("href")) { }
return; var loc = $(button)
} .attr("href")
var loc = $(button) .trim();
.attr("href") // load content from value of button href
.trim(); if (loc !== undefined && loc !== "#") {
// load content from value of button href $(this)
if (loc !== undefined && loc !== "#") { .find('.modal-content')
$(this) .load(loc);
.find('.modal-content') }
.load(loc);
}
});
}); });
// Handle history snippet expansion. // Handle history snippet expansion.