From 65ea426793746a5293a3f0a97cc4a58df3b8473b Mon Sep 17 00:00:00 2001 From: Jennifer Richards Date: Thu, 18 May 2023 13:15:58 -0300 Subject: [PATCH] fix: Add changed fields to update_fields in Model.save() methods --- ietf/nomcom/models.py | 4 +++- ietf/stats/models.py | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ietf/nomcom/models.py b/ietf/nomcom/models.py index f2f9c7b31..28116354c 100644 --- a/ietf/nomcom/models.py +++ b/ietf/nomcom/models.py @@ -187,9 +187,11 @@ class NomineePosition(models.Model): ordering = ['nominee'] def save(self, **kwargs): + update_fields = kwargs.pop("update_fields", None) if not self.pk and not self.state_id: self.state = NomineePositionStateName.objects.get(slug='pending') - super(NomineePosition, self).save(**kwargs) + update_fields = {"slug"}.union(update_fields or set()) + super().save(update_fields=update_fields, **kwargs) def __str__(self): return "%s - %s - %s" % (self.nominee, self.state, self.position) diff --git a/ietf/stats/models.py b/ietf/stats/models.py index 422c5b78a..0871804b0 100644 --- a/ietf/stats/models.py +++ b/ietf/stats/models.py @@ -24,7 +24,8 @@ class AffiliationAlias(models.Model): def save(self, *args, **kwargs): self.alias = self.alias.lower() - super(AffiliationAlias, self).save(*args, **kwargs) + update_fields = {"alias"}.union(kwargs.pop("update_fields", set())) + super(AffiliationAlias, self).save(update_fields=update_fields, *args, **kwargs) class Meta: verbose_name_plural = "affiliation aliases"