altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

fix: Format NomCom feedback table per suggestion of @richsalz (#4625)

Browse source 
Also makes table header alignment the same as for columns, site-wide.

Fixes #4529
This commit is contained in:
Lars Eggert 2022-10-21 19:04:10 +03:00 committed by GitHub
parent 26e2e23418
commit 5ac3874ce9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ietf/static/js/list.js
View file

@ -86,10 +86,9 @@ $(document)
$(header_row) $(header_row)
.children("[data-sort]") .children("[data-sort]")
.addClass("sort"); .addClass("sort");
// $(header_row) $(header_row)
// .children("th, td") .children("th, td")
// .wrapInner('<span class="tablesorter-th"></span>'); .each((i, e) => field_magic(i, e, fields));
// // .each((i, e) => field_magic(i, e, fields));
if ($(header_row) if ($(header_row)
.text() .text()

8
ietf/templates/nomcom/private_index.html
View file

@ -8,7 +8,7 @@
{% block nomcom_content %} {% block nomcom_content %}
{% origin %} {% origin %}
<h2 class="mt-3">Nomination status</h2> <h2 class="mt-3">Nomination status</h2>
<table class="table table-sm table-striped table-hover tablesorter"> <table class="table table-sm table-striped-columns table-hover tablesorter">
<thead class="wrap-anywhere"> <thead class="wrap-anywhere">
<tr> <tr>
<th scope="col" data-sort="position">Position</th> <th scope="col" data-sort="position">Position</th>
@ -156,7 +156,7 @@
<i class="bi bi-check"></i> <i class="bi bi-check"></i>
</th> </th>
{% endif %} {% endif %}
<th scope="col" data-sort="nominee" colspan="2"> <th scope="col" data-sort="nominee">
Nominee Nominee
</th> </th>
<th scope="col" data-sort="position"> <th scope="col" data-sort="position">
@ -194,9 +194,7 @@
<a href="{% url 'ietf.person.views.profile' email_or_name=np.nominee.name %}"> <a href="{% url 'ietf.person.views.profile' email_or_name=np.nominee.name %}">
{{ np.nominee.email.name_and_email }} {{ np.nominee.email.name_and_email }}
</a> </a>
</td> <a class="btn btn-primary btn-sm float-end"
<td>
<a class="btn btn-primary btn-sm"
href="{% url 'ietf.nomcom.views.view_feedback_nominee' year=year nominee_id=np.nominee.id %}#comment"> href="{% url 'ietf.nomcom.views.view_feedback_nominee' year=year nominee_id=np.nominee.id %}#comment">
View feedback View feedback
</a> </a>