From 54bc9ff596a56956c544b3b90775d068c637d30b Mon Sep 17 00:00:00 2001 From: Ole Laursen Date: Wed, 2 Nov 2016 16:58:03 +0000 Subject: [PATCH] Modify importer to close review requests for done documents as status "Unknown" instead of auto-closing those where the IESG state is further in the process on - this seems to leave more requests in genart open, but hopefully the extra data for genart will fix this problem shortly. - Legacy-Id: 12247 --- ietf/review/import_from_review_tool.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/ietf/review/import_from_review_tool.py b/ietf/review/import_from_review_tool.py index f4b85ba32..8cf3fd003 100755 --- a/ietf/review/import_from_review_tool.py +++ b/ietf/review/import_from_review_tool.py @@ -189,6 +189,8 @@ for t in ReviewTypeName.objects.filter(slug__in=["early", "lc", "telechat"]): # review requests +ReviewRequestStateName.objects.get_or_create(slug="unknown", name="Unknown", order=20, used=False) + states = { n.slug: n for n in ReviewRequestStateName.objects.all() } # map some names states["assigned"] = states["requested"] @@ -676,8 +678,8 @@ with db_con.cursor() as c: print "imported review document", review_req.doc, review.name - if review_req.state_id in ("requested", "accepted") and review_req.doc.get_state_slug("draft-iesg") in ["approved", "ann", "rfcqueue", "pub"]: - review_req.state = states["overtaken"] + if review_req.state_id in ("requested", "accepted") and status == "done": + review_req.state = states["unknown"] review_req.save() if "closed" not in event_collection and "assigned" in event_collection: @@ -692,6 +694,6 @@ with db_con.cursor() as c: e.save() completion_event = e print "imported event closed_review_request (generated upon closing)", e.desc, e.doc_id - + print "imported review request", row.reviewid, "as", review_req.pk, review_req.time, review_req.deadline, review_req.type, review_req.doc_id, review_req.state, review_req.doc.get_state_slug("draft-iesg")