altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 4 Packages Projects Releases Wiki Activity

fix: removew assumption about what pks tests milestones get (#8243)

Browse source
This commit is contained in:
Robert Sparks 2024-11-20 11:40:23 -06:00 committed by GitHub
parent c3e0d28cad
commit 51a76c603d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 32 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

61
ietf/group/tests_info.py
View file

@ -1431,7 +1431,7 @@ class MilestoneTests(TestCase):
RoleFactory(group=group,name_id='chair',person=PersonFactory(user__username='marschairman')) RoleFactory(group=group,name_id='chair',person=PersonFactory(user__username='marschairman'))
draft = WgDraftFactory(group=group) draft = WgDraftFactory(group=group)
m1 = GroupMilestone.objects.create(id=1, m1 = GroupMilestone.objects.create(
group=group, group=group,
desc="Test 1", desc="Test 1",
due=date_today(DEADLINE_TZINFO), due=date_today(DEADLINE_TZINFO),
@ -1439,7 +1439,7 @@ class MilestoneTests(TestCase):
state_id="active") state_id="active")
m1.docs.set([draft]) m1.docs.set([draft])
m2 = GroupMilestone.objects.create(id=2, m2 = GroupMilestone.objects.create(
group=group, group=group,
desc="Test 2", desc="Test 2",
due=date_today(DEADLINE_TZINFO), due=date_today(DEADLINE_TZINFO),
@ -1580,13 +1580,14 @@ class MilestoneTests(TestCase):
events_before = group.groupevent_set.count() events_before = group.groupevent_set.count()
# add # add
r = self.client.post(url, { 'prefix': "m1", mstr = f"m{m1.id}"
'm1-id': m1.id, r = self.client.post(url, { 'prefix': mstr,
'm1-desc': m1.desc, f'{mstr}-id': m1.id,
'm1-due': m1.due.strftime("%B %Y"), f'{mstr}-desc': m1.desc,
'm1-resolved': m1.resolved, f'{mstr}-due': m1.due.strftime("%B %Y"),
'm1-docs': pklist(m1.docs), f'{mstr}-resolved': m1.resolved,
'm1-review': "accept", f'{mstr}-docs': pklist(m1.docs),
f'{mstr}-review': "accept",
'action': "save", 'action': "save",
}) })
self.assertEqual(r.status_code, 302) self.assertEqual(r.status_code, 302)
@ -1606,13 +1607,14 @@ class MilestoneTests(TestCase):
events_before = group.groupevent_set.count() events_before = group.groupevent_set.count()
# delete # delete
r = self.client.post(url, { 'prefix': "m1", mstr = f"m{m1.id}"
'm1-id': m1.id, r = self.client.post(url, { 'prefix': mstr,
'm1-desc': m1.desc, f'{mstr}-id': m1.id,
'm1-due': m1.due.strftime("%B %Y"), f'{mstr}-desc': m1.desc,
'm1-resolved': "", f'{mstr}-due': m1.due.strftime("%B %Y"),
'm1-docs': pklist(m1.docs), f'{mstr}-resolved': "",
'm1-delete': "checked", f'{mstr}-docs': pklist(m1.docs),
f'{mstr}-delete': "checked",
'action': "save", 'action': "save",
}) })
self.assertEqual(r.status_code, 302) self.assertEqual(r.status_code, 302)
@ -1635,13 +1637,14 @@ class MilestoneTests(TestCase):
due = self.last_day_of_month(date_today(DEADLINE_TZINFO) + datetime.timedelta(days=365)) due = self.last_day_of_month(date_today(DEADLINE_TZINFO) + datetime.timedelta(days=365))
mstr = f"m{m1.id}"
# faulty post # faulty post
r = self.client.post(url, { 'prefix': "m1", r = self.client.post(url, { 'prefix': mstr,
'm1-id': m1.id, f'{mstr}-id': m1.id,
'm1-desc': "", # no description f'{mstr}-desc': "", # no description
'm1-due': due.strftime("%B %Y"), f'{mstr}-due': due.strftime("%B %Y"),
'm1-resolved': "", f'{mstr}-resolved': "",
'm1-docs': doc_pks, f'{mstr}-docs': doc_pks,
'action': "save", 'action': "save",
}) })
self.assertEqual(r.status_code, 200) self.assertEqual(r.status_code, 200)
@ -1653,13 +1656,13 @@ class MilestoneTests(TestCase):
# edit # edit
mailbox_before = len(outbox) mailbox_before = len(outbox)
r = self.client.post(url, { 'prefix': "m1", r = self.client.post(url, { 'prefix': mstr,
'm1-id': m1.id, f'{mstr}-id': m1.id,
'm1-desc': "Test 2 - changed", f'{mstr}-desc': "Test 2 - changed",
'm1-due': due.strftime("%B %Y"), f'{mstr}-due': due.strftime("%B %Y"),
'm1-resolved': "Done", f'{mstr}-resolved': "Done",
'm1-resolved_checkbox': "checked", f'{mstr}-resolved_checkbox': "checked",
'm1-docs': doc_pks, f'{mstr}-docs': doc_pks,
'action': "save", 'action': "save",
}) })
self.assertEqual(r.status_code, 302) self.assertEqual(r.status_code, 302)