Don't use EmptyQuerySet directly; return Class.objects.none() instead.

- Legacy-Id: 12013
This commit is contained in:
Henrik Levkowetz 2016-09-21 11:23:57 +00:00
parent d0c3331f9f
commit 5089651e17
2 changed files with 2 additions and 4 deletions

View file

@ -7,7 +7,6 @@ import hashlib
import json import json
from django.conf import settings from django.conf import settings
from django.db.models.query import EmptyQuerySet
from django.forms import ValidationError from django.forms import ValidationError
from django.utils.html import escape from django.utils.html import escape
from django.core.urlresolvers import reverse as urlreverse from django.core.urlresolvers import reverse as urlreverse
@ -146,7 +145,7 @@ def needed_ballot_positions(doc, active_positions):
elif isinstance(doc,DocHistory): elif isinstance(doc,DocHistory):
related_set = doc.relateddochistory_set related_set = doc.relateddochistory_set
else: else:
related_set = EmptyQuerySet() related_set = RelatedDocHistory.objects.none()
for rel in related_set.filter(relationship__slug__in=['tops', 'tois', 'tohist', 'toinf', 'tobcp', 'toexp']): for rel in related_set.filter(relationship__slug__in=['tops', 'tois', 'tohist', 'toinf', 'tobcp', 'toexp']):
if (rel.target.document.std_level.slug in ['bcp','ps','ds','std']) or (rel.relationship.slug in ['tops','tois','tobcp']): if (rel.target.document.std_level.slug in ['bcp','ps','ds','std']) or (rel.relationship.slug in ['tops','tois','tobcp']):
needed = two_thirds_rule(recused=len(recuse)) needed = two_thirds_rule(recused=len(recuse))

View file

@ -38,7 +38,6 @@ from django.conf import settings
from django.core.cache import cache from django.core.cache import cache
from django.core.urlresolvers import reverse as urlreverse from django.core.urlresolvers import reverse as urlreverse
from django.db.models import Q from django.db.models import Q
from django.db.models.query import EmptyQuerySet
from django.http import Http404, HttpResponseBadRequest, HttpResponse, HttpResponseRedirect, QueryDict from django.http import Http404, HttpResponseBadRequest, HttpResponse, HttpResponseRedirect, QueryDict
from django.shortcuts import render from django.shortcuts import render
from django.utils.cache import _generate_cache_key from django.utils.cache import _generate_cache_key
@ -144,7 +143,7 @@ def retrieve_search_results(form, all_types=False):
types.extend(query["doctypes"]) types.extend(query["doctypes"])
if not types: if not types:
return EmptyQuerySet() return Document.objects.none()
docs = Document.objects.filter(type__in=types) docs = Document.objects.filter(type__in=types)