altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

Make Person.role_email a bit smarter, make Person.email_address (which

Browse source 
seems to be a wrapper for old code at the moment) always return a string
 - Legacy-Id: 3747
This commit is contained in:
Ole Laursen 2011-12-07 18:56:19 +00:00
parent 896347bf7c
commit 4f48cb2ff6
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
redesign/person/models.py
View file

@ -29,14 +29,17 @@ class PersonInfo(models.Model):
prefix, first, middle, last, suffix = self.ascii_parts()
return (first and first[0]+"." or "")+(middle or "")+" "+last+(suffix and " "+suffix or "")
def role_email(self, role_name, group=None):
"""Lookup email for role for person, optionally on group which
may be an object or the group acronym."""
if group:
if isinstance(group, str) or isinstance(group, unicode):
group = Group.objects.get(acronym=group)
e = Email.objects.filter(person=self, role__group=group, role__name=role_name)
if e:
return e[0]
else:
e = Email.objects.filter(person=self, role__group__state="active", role__name=role_name)
if e:
return e[0]
if e:
return e[0]
# no cigar, try the complete set before giving up
e = self.email_set.order_by("-active")
if e:
return e[0]
@ -44,7 +47,7 @@ class PersonInfo(models.Model):
def email_address(self):
e = self.email_set.filter(active=True)
if e:
return e[0]
return e[0].address
else:
return ""
def formatted_email(self):