altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

Turn post_admin and archive_private into IntegerField instead of

Browse source 
BooleanField.  They are used as booleans, but represented in the
database as integers, so pretending they're boolean causes trouble
when saving empty values.
 - Legacy-Id: 266
This commit is contained in:
Bill Fenner 2007-06-08 18:12:23 +00:00
parent d6b6f38424
commit 4e3769c963
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ietf/mailinglists/models.py
View file

@ -67,6 +67,10 @@ class MailingList(models.Model):
(1, 'List members only'), (1, 'List members only'),
(2, 'Open'), (2, 'Open'),
) )
YESNO_CHOICES = (
(0, 'NO'),
(1, 'YES'),
) # for integer "boolean" fields
mailing_list_id = models.CharField('Unique ID', primary_key=True, maxlength=25, editable=False) mailing_list_id = models.CharField('Unique ID', primary_key=True, maxlength=25, editable=False)
request_date = models.DateField(default=datetime.now, editable=False) request_date = models.DateField(default=datetime.now, editable=False)
requestor = models.CharField("Requestor's full name", maxlength=250) requestor = models.CharField("Requestor's full name", maxlength=250)
@ -81,8 +85,8 @@ class MailingList(models.Model):
welcome_new = models.TextField('Provide a welcome message for new subscriber(s)(optional)', blank=True) welcome_new = models.TextField('Provide a welcome message for new subscriber(s)(optional)', blank=True)
subscription = models.IntegerField('What steps are required for subscription?', choices=SUBSCRIPTION_CHOICES) subscription = models.IntegerField('What steps are required for subscription?', choices=SUBSCRIPTION_CHOICES)
post_who = models.IntegerField('Messages to this list can be posted by', choices=POSTWHO_CHOICES) post_who = models.IntegerField('Messages to this list can be posted by', choices=POSTWHO_CHOICES)
post_admin = models.BooleanField('Do postings need to be approved by an administrator?') post_admin = models.IntegerField('Do postings need to be approved by an administrator?', default=0, choices=YESNO_CHOICES)
archive_private = models.BooleanField('Are the archives private?') archive_private = models.IntegerField('Are the archives private?', default=0, choices=YESNO_CHOICES)
archive_remote = models.TextField('Provide specific information about how to access and move the existing archive (optional)', blank=True) archive_remote = models.TextField('Provide specific information about how to access and move the existing archive (optional)', blank=True)
add_comment = models.TextField(blank=True) add_comment = models.TextField(blank=True)
mail_type = models.IntegerField(choices=MAILTYPE_CHOICES) mail_type = models.IntegerField(choices=MAILTYPE_CHOICES)