altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

fix: improvements to submit form validation

Browse source
This commit is contained in:
Robert Sparks 2023-07-07 15:08:41 -05:00
parent ff058e3c63
commit 457b95094a
No known key found for this signature in database
GPG key ID: 6E2A6A5775F91318
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ietf/submit/forms.py
View file

@ -707,7 +707,7 @@ class SubmissionAutoUploadForm(SubmissionBaseUploadForm):
elif alias.document.get_state_slug() == "rfc": elif alias.document.get_state_slug() == "rfc":
self.add_error( self.add_error(
'replaces', 'replaces',
forms.ValidationError("An Internet-Draft cannot replace an RFC"), forms.ValidationError("An Internet-Draft cannot replace another Internet-Draft that has become an RFC"),
) )
elif alias.document.get_state_slug('draft-iesg') in ('approved', 'ann', 'rfcqueue'): elif alias.document.get_state_slug('draft-iesg') in ('approved', 'ann', 'rfcqueue'):
self.add_error( self.add_error(

6
ietf/submit/tests.py
View file

@ -3099,13 +3099,15 @@ class SubmissionUploadFormTests(BaseSubmitTestCase):
# can't replace RFC # can't replace RFC
rfc = WgRfcFactory() rfc = WgRfcFactory()
draft = WgDraftFactory(states=[("draft", "rfc")])
draft.relateddocument_set.create(relationship_id="became_rfc", target=rfc.docalias.first())
form = SubmissionAutoUploadForm( form = SubmissionAutoUploadForm(
request_factory.get('/some/url'), request_factory.get('/some/url'),
data={'user': auth.user.username, 'replaces': rfc.name}, data={'user': auth.user.username, 'replaces': draft.name},
files=files_dict, files=files_dict,
) )
self.assertFalse(form.is_valid()) self.assertFalse(form.is_valid())
self.assertIn('An Internet-Draft cannot replace an RFC', form.errors['replaces']) self.assertIn('An Internet-Draft cannot replace another Internet-Draft that has become an RFC', form.errors['replaces'])
# can't replace draft approved by iesg # can't replace draft approved by iesg
existing_drafts[0].set_state(State.objects.get(type='draft-iesg', slug='approved')) existing_drafts[0].set_state(State.objects.get(type='draft-iesg', slug='approved'))