altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 3 Packages Projects Releases Wiki Activity

fix: Show overfull style based on max, not sum, of session durations (#5044)

Browse source 
* fix: Show overfull style based on max, not sum, of session durations

* style: Avoid shadowing 'sessions' from outer scope
This commit is contained in:
Jennifer Richards 2023-01-27 18:24:24 -04:00 committed by GitHub
parent 23f38e2ebc
commit 408c1ea9a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ietf/static/js/edit-meeting-schedule.js
View file

@ -647,12 +647,9 @@ $(function () {
function updateTimeSlotDurationViolations() {
timeslots.each(function () {
let total = 0;
jQuery(this).find(".session").each(function () {
total += +jQuery(this).data("duration");
});
jQuery(this).toggleClass("overfull", total > +jQuery(this).data("duration"));
const sessionsInSlot = Array.from(this.getElementsByClassName('session'));
const requiredDuration = Math.max(sessionsInSlot.map(elt => Number(elt.dataset.duration)));
this.classList.toggle('overfull', requiredDuration > Number(this.dataset.duration));
});
}