From 3c2b01b3ffa676279868bc002b5d0cf5dce33e96 Mon Sep 17 00:00:00 2001 From: Sasha Romijn Date: Mon, 21 Oct 2019 14:15:08 +0000 Subject: [PATCH] Fix #2277 - Do not allow reviewers to reject overdue reviews. If a review request is past the deadline, reviewers will no longer be able to reject the assignment. Commit ready for merge. - Legacy-Id: 16883 --- ietf/doc/tests_review.py | 24 +++++++++++++++++++ ietf/doc/views_review.py | 4 +++- .../review/reject_reviewer_assignment.html | 24 ++++++++++++------- 3 files changed, 42 insertions(+), 10 deletions(-) diff --git a/ietf/doc/tests_review.py b/ietf/doc/tests_review.py index d8de39c28..f4f1f728b 100644 --- a/ietf/doc/tests_review.py +++ b/ietf/doc/tests_review.py @@ -473,6 +473,8 @@ class ReviewTests(TestCase): r = self.client.get(reject_url) self.assertEqual(r.status_code, 200) self.assertContains(r, str(assignment.reviewer.person)) + self.assertNotContains(r, 'can not be rejected') + self.assertContains(r, ' - {% endbuttons %} - + {% buttons %} + Cancel + + {% endbuttons %} + + {% else %} +

+ This review assignment can not be rejected, as the deadline of the review request has already passed. +

+ {% endif %} {% endblock %}