altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 6 Packages Projects Releases Wiki Activity

fix: appropriate metadata for editorial stream docs (#7195)

Browse source
This commit is contained in:
Robert Sparks 2024-03-15 23:16:09 -05:00 committed by GitHub
parent b21706ef5c
commit 3bfb9303bc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 131 additions and 119 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ietf/doc/tests_draft.py
View file

@ -20,7 +20,7 @@ from django.utils.html import escape
import debug # pyflakes:ignore
from ietf.doc.expire import get_expired_drafts, send_expire_notice_for_draft, expire_draft
from ietf.doc.factories import IndividualDraftFactory, WgDraftFactory, RgDraftFactory, DocEventFactory
from ietf.doc.factories import EditorialDraftFactory, IndividualDraftFactory, WgDraftFactory, RgDraftFactory, DocEventFactory
from ietf.doc.models import ( Document, DocReminder, DocEvent,
ConsensusDocEvent, LastCallDocEvent, RelatedDocument, State, TelechatDocEvent,
WriteupDocEvent, DocRelationshipName, IanaExpertDocEvent )
@ -2161,3 +2161,13 @@ class ShepherdWriteupTests(TestCase):
self.assertContains(r, "for Group Documents", status_code=200)
r = self.client.post(url,dict(reset_text=''))
self.assertContains(r, "for Group Documents", status_code=200)
class EditorialDraftMetadataTests(TestCase):
def test_editorial_metadata(self):
draft = EditorialDraftFactory()
url = urlreverse("ietf.doc.views_doc.document_main", kwargs=dict(name=draft.name))
r = self.client.get(url)
q = PyQuery(r.content)
top_level_metadata_headings = q("tbody>tr>th:first-child").text()
self.assertNotIn("IESG", top_level_metadata_headings)
self.assertNotIn("IANA", top_level_metadata_headings)

4
ietf/templates/doc/document_draft.html
View file

@ -267,7 +267,7 @@
</tr>
{% endif %}
</tbody>
{% if not doc.stream_id == 'iab' %}
{% if doc.stream_id != 'iab' and doc.stream_id != 'editorial' %}
<tbody class="meta border-top">
<tr>
<th scope="row">
@ -447,6 +447,7 @@
</tr>
</tbody>
{% endif %}
{% if doc.stream_id != 'editorial' %}
{% if can_edit_iana_state or iana_review_state or iana_experts_state or iana_experts_comment %}
<tbody class="meta border-top">
{% if iana_review_state or can_edit_iana_state %}
@ -567,6 +568,7 @@
{% endif %}
</tbody>
{% endif %}
{% endif %}
{% if rfc_editor_state %}
<tbody class="meta border-top">
<tr>