From 2c6fe0383c1dee943033a74e77de27e27f0f1d2a Mon Sep 17 00:00:00 2001
From: Robert Sparks <rjsparks@nostrum.com>
Date: Fri, 7 Jul 2023 17:31:24 -0500
Subject: [PATCH] fix: adjust gating of review requests
---
ietf/doc/tests_review.py | 10 +++++++++-
ietf/doc/views_review.py | 2 +-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/ietf/doc/tests_review.py b/ietf/doc/tests_review.py
index 1f84303a9..2b9dd6a07 100644
--- a/ietf/doc/tests_review.py
+++ b/ietf/doc/tests_review.py
@@ -137,10 +137,18 @@ class ReviewTests(TestCase):
url = urlreverse('ietf.doc.views_review.request_review', kwargs={ "name": doc.name })
login_testing_unauthorized(self, "ad", url)
- # get should fail
+ # get should fail - all non draft types 404
+ r = self.client.get(url)
+ self.assertEqual(r.status_code, 404)
+
+ # Can only request reviews on active draft documents
+ doc = WgDraftFactory(states=[("draft","rfc")])
+ url = urlreverse('ietf.doc.views_review.request_review', kwargs={ "name": doc.name })
r = self.client.get(url)
self.assertEqual(r.status_code, 403)
+
+
def test_doc_page(self):
doc = WgDraftFactory(group__acronym='mars',rev='01')
diff --git a/ietf/doc/views_review.py b/ietf/doc/views_review.py
index fa6e3a7ff..2ded177f5 100644
--- a/ietf/doc/views_review.py
+++ b/ietf/doc/views_review.py
@@ -117,7 +117,7 @@ class RequestReviewForm(forms.ModelForm):
@login_required
def request_review(request, name):
- doc = get_object_or_404(Document, name=name)
+ doc = get_object_or_404(Document, type_id="draft", name=name)
if not can_request_review_of_doc(request.user, doc):
permission_denied(request, "You do not have permission to perform this action")