From 2c2effde4fa02123105fdb177e12571f9e7b5f29 Mon Sep 17 00:00:00 2001 From: Henrik Levkowetz <henrik@levkowetz.com> Date: Thu, 4 Oct 2018 18:03:41 +0000 Subject: [PATCH] Added a form clean() for the reminder dates of the nomcom edit form, to make something appropriate out of edits that remove reminder dates, rather than clicking 'delete'. This fixes a potential exception, when a blank date cannot be saved, and also does what the user expected (deletes a blanked date). - Legacy-Id: 15521 --- ietf/nomcom/forms.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/ietf/nomcom/forms.py b/ietf/nomcom/forms.py index 59d0eb330..cf355ce55 100644 --- a/ietf/nomcom/forms.py +++ b/ietf/nomcom/forms.py @@ -661,6 +661,14 @@ class ReminderDatesForm(forms.ModelForm): super(ReminderDatesForm, self).__init__(*args, **kwargs) self.fields['date'].required = False + def clean(self): + cleaned_data = super(ReminderDatesForm, self).clean() + date = cleaned_data.get('date') + delete = cleaned_data.get('DELETE') + if date is None: + cleaned_data['date'] = '' + cleaned_data['DELETE'] = True + return cleaned_data class MutableFeedbackForm(forms.ModelForm):