From 24c320f763e1218069a45a44d144bf4e9380605b Mon Sep 17 00:00:00 2001 From: Henrik Levkowetz Date: Wed, 27 Jun 2007 22:24:24 +0000 Subject: [PATCH] Restrict all found IPRs to status 1 and 3. Only show links to, and display details of, IPRs with status 1. - Legacy-Id: 720 --- ietf/ipr/feeds.py | 2 +- ietf/ipr/new.py | 3 +++ ietf/ipr/urls.py | 2 +- ietf/ipr/views.py | 3 +++ ietf/templates/ipr/details.html | 2 +- 5 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ietf/ipr/feeds.py b/ietf/ipr/feeds.py index d26ca249f..cb006cab5 100644 --- a/ietf/ipr/feeds.py +++ b/ietf/ipr/feeds.py @@ -13,7 +13,7 @@ class LatestIprDisclosures(Feed): feed_url = "/feeds/ipr/" def items(self): - return IprDetail.objects.order_by('-submitted_date')[:5] + return IprDetail.objects.filter(status__in=[1,3]).order_by('-submitted_date')[:5] def item_link(self, item): return "/ipr/ipr-%s" % item.ipr_id diff --git a/ietf/ipr/new.py b/ietf/ipr/new.py index 6b2dc51a3..86893850d 100644 --- a/ietf/ipr/new.py +++ b/ietf/ipr/new.py @@ -8,6 +8,7 @@ import django.newforms as forms from datetime import datetime from django.shortcuts import render_to_response as render from django.template import RequestContext +from django.http import Http404 from ietf.utils import log from ietf.utils.mail import send_mail from ietf.ipr.view_sections import section_table @@ -337,6 +338,8 @@ def update(request, ipr_id=None): submitter = form.clean_data ipr = models.IprDetail.objects.get(ipr_id=ipr_id) + if not ipr.status in [1,3]: + raise Http404 type = "specific" if ipr.generic: type = "generic" diff --git a/ietf/ipr/urls.py b/ietf/ipr/urls.py index e263fcab8..cf503ff0f 100644 --- a/ietf/ipr/urls.py +++ b/ietf/ipr/urls.py @@ -13,7 +13,7 @@ urlpatterns = patterns('', (r'^search/$', search.search), ) -queryset = models.IprDetail.objects.all() +queryset = models.IprDetail.objects.filter(status__in=[1,3]) archive = {'queryset':queryset, 'date_field': 'submitted_date', 'allow_empty':True } urlpatterns += patterns('django.views.generic.date_based', diff --git a/ietf/ipr/views.py b/ietf/ipr/views.py index 98e1822ca..6243abfb2 100644 --- a/ietf/ipr/views.py +++ b/ietf/ipr/views.py @@ -4,6 +4,7 @@ import django.utils.html from django.shortcuts import render_to_response as render from django.template import RequestContext from django.utils.html import escape +from django.http import Http404 from ietf.idtracker.models import IETFWG from ietf.ipr.models import IprDetail, SELECT_CHOICES, LICENSE_CHOICES from ietf.ipr.view_sections import section_table @@ -47,6 +48,8 @@ def show(request, ipr_id=None): """Show a specific IPR disclosure""" assert ipr_id != None ipr = IprDetail.objects.get(ipr_id=ipr_id) + if not ipr.status == 1: + raise Http404 section_list = get_section_list(ipr) contacts = ipr.contact.all() for contact in contacts: diff --git a/ietf/templates/ipr/details.html b/ietf/templates/ipr/details.html index 53ead2b0a..e87649243 100644 --- a/ietf/templates/ipr/details.html +++ b/ietf/templates/ipr/details.html @@ -62,7 +62,7 @@
This IPR disclosure updates IPR disclosure ID #{{ item.updated.ipr_id }}, - {% ifequal item.status_to_be 1 %} + {% ifequal item.status 1 %} "{{ item.updated.title }}". {% else %} "{{ item.updated.title }}", which was removed at the request of the submitter.