altf4arnold/datatracker
1
0
Fork 0
Code Issues Pull requests Actions 4 Packages Projects Releases Wiki Activity

Changed the handling of the group edit form so as to generate a ChangeStateGroupEvent for state changes, instead of a generic GroupEvent of type 'info_changed'.

Browse source 
- Legacy-Id: 9119
This commit is contained in:
Henrik Levkowetz 2015-02-24 18:36:02 +00:00
parent ca8d554b78
commit 219a2ea204
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ietf/group/edit.py
View file

@ -231,7 +231,7 @@ def edit(request, group_type=None, acronym=None, action="edit"):
def diff(attr, name):
v = getattr(group, attr)
if clean[attr] != v:
changes.append(desc(name, clean[attr], v))
changes.append((attr, clean[attr], desc(name, clean[attr], v)))
setattr(group, attr, clean[attr])
# update the attributes, keeping track of what we're doing
@ -251,9 +251,9 @@ def edit(request, group_type=None, acronym=None, action="edit"):
new = [ new.role_email('ad'),] if new else []
old = Email.objects.filter(role__group=group, role__name=slug).select_related("person")
if set(new) != set(old):
changes.append(desc(title,
changes.append((attr, new, desc(title,
", ".join(x.get_name() for x in new),
", ".join(x.get_name() for x in old)))
", ".join(x.get_name() for x in old))))
group.role_set.filter(name=slug).delete()
for e in new:
Role.objects.get_or_create(name_id=slug, email=e, group=group, person=e.person)
@ -273,7 +273,7 @@ def edit(request, group_type=None, acronym=None, action="edit"):
new_urls = clean['urls']
old_urls = format_urls(group.groupurl_set.order_by('url'), ", ")
if ", ".join(sorted(new_urls)) != old_urls:
changes.append(desc('Urls', ", ".join(sorted(new_urls)), old_urls))
changes.append(('urls', new_urls, desc('Urls', ", ".join(sorted(new_urls)), old_urls)))
group.groupurl_set.all().delete()
# Add new ones
for u in new_urls:
@ -288,8 +288,11 @@ def edit(request, group_type=None, acronym=None, action="edit"):
group.time = datetime.datetime.now()
if changes and not new_group:
for c in changes:
GroupEvent.objects.create(group=group, by=request.user.person, type="info_changed", desc=c)
for attr, new, desc in changes:
if attr == 'state':
ChangeStateGroupEvent.objects.create(group=group, time=group.time, state=new, by=request.user.person, type="changed_state", desc=desc)
else:
GroupEvent.objects.create(group=group, time=group.time, by=request.user.person, type="info_changed", desc=desc)
group.save()